Merge pull request #1381 from CEED/jrwrigh/fixup_coords

fluids: Remove coordinates from IFunction_NodalSgs

fluids: Use enums in advection

Drop Coordinate Basis from IJacobian (without breaking IDL) (#1380)

* compute IDL coefficient in IFunction that has access to coordinates, append this to jac_data so that IJacobian can avoid pulling

Drop Coordinate Basis from IJacobian (without breaking IDL) (#1380)

* compute IDL coefficient in IFunction that has access to coordinates, append this to jac_data so that IJacobian can avoid pulling coordinates through basis to apply IDL

Co-authored-by: James Wright <james@jameswright.xyz>

show more ...

fluids: Remove coordinates from IFunction_NodalSgs

- Stragler from previous PR

style errors induced by dropping coordinates where not used

deleted all the unused coordinate references that were throwing warnings

reverting the change to IC that caused divergence on first step...guess I was too sleepy to drive last night

quick attempt at taking potential out of the initial condition makes the error norm much smaller but still probably cannot compare solutions with different Etot variables

adding body force term to energy equation...for now the b vector is using what is put into gravity

last one maybe

more style edits

style cleanup

missed some places that BI restoration requires

Potential energy removed from all state helpers so no more x (or dx) dependence for them. Interior integrals still need x for IDL but boundary elements don't so removed. This touches lots of qfuncti

Potential energy removed from all state helpers so no more x (or dx) dependence for them. Interior integrals still need x for IDL but boundary elements don't so removed. This touches lots of qfunctions that make state calls and a few problems as well

show more ...

fluids: Add StatePhysicalGradientFromReference util

fluids: Add ASAN, Correct memory out-of-bounds error

fluids: Use explicit array size for new_bounds

- `new_bounds` was previously changed to remove the explicit array size
declaration because Sycl's online compiler didn't like it.
- Trying to do

fluids: Use explicit array size for new_bounds

- `new_bounds` was previously changed to remove the explicit array size
declaration because Sycl's online compiler didn't like it.
- Trying to do a direct cast results in:
```
/home/jrwrigh/software/libCEED/examples/fluids/problems/../qfunctions/sgs_dd_model.h:67:39: error: used type 'const CeedScalar[6][2]' (aka 'const double[6][2]') where arithmetic or pointer type is required
const CeedScalar new_bounds[6][2] = (const CeedScalar[6][2]) & sgsdd_ctx->data[sgsdd_ctx->offsets.out_scaling];
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
- This represents the best compromise; can't do a direct pointer cast
(requiring more compiler work to be efficient and obfuscating what's
happening), but can at least keep the explicit array sizes for
`new_bounds`

show more ...

fluids: Change variable name "local" to appease ocloc

- For reasons only God knows, ocloc (online compiler for OpenCL for
Intel hardware) doesn't approve of the variable name `local`. It
returns

fluids: Change variable name "local" to appease ocloc

- For reasons only God knows, ocloc (online compiler for OpenCL for
Intel hardware) doesn't approve of the variable name `local`. It
returns:
```
$ build/fluids-navierstokes -ceed /gpu/sycl/ref -options_file examples/fluids/tests-output/stats_test.yaml -test_type solver -compare_final_state_atol 1e-11 -compare_final_state_filename examples/fluids/tests-output/fluids-navierstokes-turb-spanstats-stats.bin
Command was: ocloc -q -spv_only -device pvc -64 -options "-cl-std=CL3.0 -Dint32_t=int" -file main.cl
[0]PETSC ERROR: --------------------- Error Message --------------------------------------------------------------
[0]PETSC ERROR: Error in external library
[0]PETSC ERROR: /home/jczhang/libCEED/backends/sycl/ceed-sycl-compile.sycl.cpp:73 in CeedJitCompileSource_Sycl(): ocloc reported compilation errors: {
Build failed with error code: -11
}
```

show more ...

Merge pull request #1315 from CEED/jeremy/queep

Backend Consistency Fixes

fluids: Fix Sycl related arguments

- These arguments work fine in CUDA and HIP, but OpenCL (specifically,
the online compiler used for Sunspot) isn't happy with these minor
changes in pointer de

fluids: Fix Sycl related arguments

- These arguments work fine in CUDA and HIP, but OpenCL (specifically,
the online compiler used for Sunspot) isn't happy with these minor
changes in pointer definitions.

show more ...

fluids: Add QF value qdata packing/unpacking

fluids: Make function names in consistent format

- Mainly remove `_` and acronymns with more than 2 letters should
respect CamelCase (ie. `StgFunction` not `STGFunction`)

fluids: Add DMSetupByOrder_* helper function

Merge pull request #1223 from CEED/jrwrigh/decompose_sgs_dd

Fluids: Decompose SGS DD input and output processing

Merge pull request #1298 from CEED/jrwrigh/taylor-green-vortex

Fluids: Add Taylor-Green vortex problem