Merge pull request #1318 from CEED/jrwrigh/fix_collocated_basis

fix: Add `CEED_BASIS_COLLOCATED` to ceed.h

fix: Add `CEED_BASIS_COLLOCATED` to ceed.h

- `CEED_BASIS_COLLOCATED` is deprecated, so should still be available
to use

Merge pull request #1314 from CEED/jed/fix-realloc

preconditioning: fix realloc use-after-free bug

preconditioning: fix realloc use-after-free bug

realloc(&p, size) may change the value of p. In this function, we stored
the local variable into a struct, then call realloc again on
the (untrue) ass

preconditioning: fix realloc use-after-free bug

realloc(&p, size) may change the value of p. In this function, we stored
the local variable into a struct, then call realloc again on
the (untrue) assumption that the value would not change.

==31299== Invalid read of size 4
==31299== at 0x65A38F5: CeedSingleOperatorAssembleAddDiagonal_Core (ceed-preconditioning.c:329)
==31299== by 0x65A5321: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1751)
==31299== by 0x65A529E: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1743)
==31299== by 0x65A52F8: CeedCompositeOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:433)
==31299== by 0x65A52F8: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1749)
==31299== by 0x65A54B8: CeedOperatorLinearAssembleDiagonal (ceed-preconditioning.c:1694)
==31299== by 0x48C6437: RatelGetDiagonal (ratel-petsc-ops.c:71)
==31299== by 0x558FA59: MatGetDiagonal_Shell (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x55A20A7: MatGetDiagonal (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x5960EF4: PCSetUp_Jacobi (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x59611C1: PCApply_Jacobi (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x5936522: PCApply (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x58F1BE5: KSPSolve_PREONLY (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== Address 0xaf09f20 is 0 bytes inside a block of size 4 free'd
==31299== at 0x484DCD3: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==31299== by 0x6595067: CeedReallocArray (ceed.c:252)
==31299== by 0x65A2217: CeedOperatorAssemblyDataCreate (ceed-preconditioning.c:1265)
==31299== by 0x65A2628: CeedOperatorGetOperatorAssemblyData (ceed-preconditioning.c:1129)
==31299== by 0x65A3526: CeedSingleOperatorAssembleAddDiagonal_Core (ceed-preconditioning.c:295)
==31299== by 0x65A5321: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1751)
==31299== by 0x65A529E: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1743)
==31299== by 0x65A52F8: CeedCompositeOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:433)
==31299== by 0x65A52F8: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1749)
==31299== by 0x65A54B8: CeedOperatorLinearAssembleDiagonal (ceed-preconditioning.c:1694)
==31299== by 0x48C6437: RatelGetDiagonal (ratel-petsc-ops.c:71)
==31299== by 0x558FA59: MatGetDiagonal_Shell (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x55A20A7: MatGetDiagonal (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== Block was alloc'd at
==31299== at 0x48487A9: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==31299== by 0x6595067: CeedReallocArray (ceed.c:252)
==31299== by 0x65A1D24: CeedOperatorAssemblyDataCreate (ceed-preconditioning.c:1201)
==31299== by 0x65A2628: CeedOperatorGetOperatorAssemblyData (ceed-preconditioning.c:1129)
==31299== by 0x65A3526: CeedSingleOperatorAssembleAddDiagonal_Core (ceed-preconditioning.c:295)
==31299== by 0x65A5321: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1751)
==31299== by 0x65A529E: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1743)
==31299== by 0x65A52F8: CeedCompositeOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:433)
==31299== by 0x65A52F8: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1749)
==31299== by 0x65A54B8: CeedOperatorLinearAssembleDiagonal (ceed-preconditioning.c:1694)
==31299== by 0x48C6437: RatelGetDiagonal (ratel-petsc-ops.c:71)
==31299== by 0x558FA59: MatGetDiagonal_Shell (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x55A20A7: MatGetDiagonal (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)

Reported-by: Rezgar Shakeri

show more ...

Merge pull request #1270 from CEED/jeremy/constantinople

Rename CEED_BASIS_COLLOCATED to CEED_BASIS_NONE

Merge pull request #1313 from CEED/sjg/ceed-composite-operator-fix

Tiny fix to use CeedCompositeOperator API

Tiny fix to use CeedCompositeOperator API

doc - further explain change from COLLOCATED to NONE

interface - rename CEED_BASIS_COLLOCATED to CEED_BASIS_NONE

Merge pull request #1281 from CEED/jeremy/simplify-parent

Clarify op fallback parent interface

doc - clarify documentation on CeedOperatorGetFallbackParent(Ceed)

op - update return value convention for CeedOperatorGetFallbackParentCeed

op - clarify op fallback parent interface

Interface consistency fixes (#1312)

* format - consistency fixes

* format - test name consistency

* format - drop comma operator

* format - drop git add . in favor coercion

* format - ad

Interface consistency fixes (#1312)

* format - consistency fixes

* format - test name consistency

* format - drop comma operator

* format - drop git add . in favor coercion

* format - add CeedScalarSwap macro

show more ...

Merge pull request #1309 from CEED/jrwrigh/elem_restr_refactor

fluids: Add DMPlexCeedElemRestriction*Create

fixup! fluids: Add DMPlexCeedElemRestriction*Create

fluids: Document and clarify spanstats restriction creation

- The restriction creation for the spanwise statistics is a pretty
special case, so better name the functions and document what exactl

fluids: Document and clarify spanstats restriction creation

- The restriction creation for the spanwise statistics is a pretty
special case, so better name the functions and document what exactly
it is doing

show more ...

fluids: Add DMPlexCeedElemRestriction*Create

Replaces CreateRestrictionFromPlex and GetRestrictionForDomain

Merge pull request #1259 from CEED/jrwrigh/fluids-cleanup

fluids: Misc cleanup

fluids: Misc changes to functions

fluids: Rename files with *_NS suffix

fluids: Correct PetscFunction{Return,BeginUser} placement

- Respect the PETSc standard for style (https://petsc.org/release/developers/style/#coding-conventions-and-style)

fluids: Remove misc comments

- Either by inaccuracy of unnecessary

fluids: Make function names in consistent format

- Mainly remove `_` and acronymns with more than 2 letters should
respect CamelCase (ie. `StgFunction` not `STGFunction`)

Merge pull request #1311 from CEED/jrwrigh/fix-fluids-preload

fluids: Fix preloading vector