Merge branch 'barry/2022-04-14/fix-rebalance' into 'main'

Major repairs for DMPlexRebalanceSharedVertices()

See merge request petsc/petsc!5234

Fix rebalancing of ghost pointers for DMPLEX

/spend 25h

Commit-type: optimization, bug-fix, style-fix, feature

Merge branch 'knepley/fix-dm-periodicity' into 'main'

Fixes for periodicity

See merge request petsc/petsc!5391

Merge branch 'jczhang/fix-dpcpp-compilation-warnings' into 'main'

Fix some compilation warnings with the new Intel dpcpp compiler

See merge request petsc/petsc!5380

Merge branch 'jed/fix-dm-plex-insert-boundary-values' into 'main'

DMPlex: add failing test of DMPlexInsertBoundaryValues with DMPlexSetClosurePermutationTensor

See merge request petsc/petsc!5393

DMPlex: add test of DMPlexInsertBoundaryValues with DMPlexSetClosurePermutationTensor

The output was generated using 49e1cd229ef9342bfd55ee54c9ac99d5195bdec8,
which is the parent of 6858538e710279fe

DMPlex: add test of DMPlexInsertBoundaryValues with DMPlexSetClosurePermutationTensor

The output was generated using 49e1cd229ef9342bfd55ee54c9ac99d5195bdec8,
which is the parent of 6858538e710279fe46cd8279ab34c98b10293bbd, which
introduced this bug. Disabling DMPlexSetClosurePermutationTensor(cdm,
...) restores correct behavior.

[This commit has been rebased after the fix, which is now its parent.]

show more ...

Plex: Instead of forcing periodic coordinates to [0, L], it should be [lower, lower + L]

plex ex60: test general metric intersection
-The inputs are not necessarily SPD, so we need to call EnforceSPD first

plex metric: fix general metric intersection
-Take the *maximum* eigenvalue, not the minimum.
-This corresponds to the *minimum* metric magnitude (h = 1/sqrt(lambda))
-Fix some indexing errors
-Alway

plex metric: fix general metric intersection
-Take the *maximum* eigenvalue, not the minimum.
-This corresponds to the *minimum* metric magnitude (h = 1/sqrt(lambda))
-Fix some indexing errors
-Always index matmult alphabetically, to avoid confusion

show more ...

Use DMLabelStratumHasPoint() in CheckPoint_Private()

plex test ex61 shows there are corner cases where checking the labelId is necessary

Add a broken test for boundary condition insertion

make test search=dm_impls_plex_tests-ex61_0 FORCE=1 DIFF_NUMBERS=1

Shows that we need to fix CheckPoints_Private() to actually test the label valu

Add a broken test for boundary condition insertion

make test search=dm_impls_plex_tests-ex61_0 FORCE=1 DIFF_NUMBERS=1

Shows that we need to fix CheckPoints_Private() to actually test the label value before insertion

show more ...

Merge branch 'wence/petsc-check-do-while' into 'main'

Wrap PetscCheck and PetscAssert in do { } while (0)

Closes #1199

See merge request petsc/petsc!5291

plexgmsh: fix compilation warnings in floating-point comparison with the Intel dpcpp compiler

warning: floating-point comparison is always true; constant cannot be represented exactly in type 'float

plexgmsh: fix compilation warnings in floating-point comparison with the Intel dpcpp compiler

warning: floating-point comparison is always true; constant cannot be represented exactly in type 'float' [-Wliteral-range]
PetscCheck(version >= 2.2,PETSC_COMM_SELF, PETSC_ERR_SUP, "Gmsh file version %3.1f must be at least 2.2", (double)version);

show more ...

Plex ex49: Test libCEED numbering

Fixed examples

DM+FE: Create DG coordinate DS and add PetscFECreateFromSpaces()
- Refactor FE creation
- Create DS for DG coordinates
- Error on DG face coordinates

DM: Reorganized periodic coordinates into a separate representation
- Split coordinates into two representations
- No longer specify the boundary type for periodicity. We can tell if a
given boundary

DM: Reorganized periodic coordinates into a separate representation
- Split coordinates into two representations
- No longer specify the boundary type for periodicity. We can tell if a
given boundary is periodic by a positive L[d]
- Added DMPlexGetCellCoordinates_Internal() to get localized cell
coordinates automatically, and used in plexgeometry.c
- Moved coordinate functions into dmcoordinates.c
- Moved periodicity functions into dmperiodicity.c

show more ...

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these macros being "if (...)
statement_without_semicolon". Fixes #1199.

show more ...

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$[ ]*}\$?\1if (\2) PetscCall(\3$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

for i in `git ls-files | grep "\.[hc]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ }else]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$\([ ]*\)} \([- ._+=a-z0-9A-Z>*,()]*);\)\$?\1if (\2) PetscCall(\3$\4\5$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

Yes, really ugly but Barry still cannot master awk

Commit-type: housekeeping

show more ...

Plex: Fix communicator

DM: Fix label completion for DMCopyDS
- Move function to dm.c

Plex: During section creation, label completion needed to be fixed for parallelism

Plex: Should not assemble after hybrid Jacobian integration

Plex: Allow a user to create a custom parallel overlap using labels - The test is in PyLith

Merge branch 'ksagiyam/dmplex_reorder_1d_options' into 'main'

plex: add DMPlexReorder{Set,Get}Default()

See merge request petsc/petsc!5245