Plex: Fix VecViewDraw for periodic boundaries

ViewerVTK: fix connectivity offset calculation for PetscVTKInt

Reported-by: Mike Michell <mi.mike1021@gmail.com>

ViewerVTK: use header_type="UInt64" to use 64-bit byte counts in binary appended

This feature is mentioned under `HeaderType` in these docs, and seems to
have been supported for a long time.

http

ViewerVTK: use header_type="UInt64" to use 64-bit byte counts in binary appended

This feature is mentioned under `HeaderType` in these docs, and seems to
have been supported for a long time.

https://kitware.github.io/paraview-docs/v5.7.0/python/paraview.simple.XMLPUnstructuredGridWriter.html

It was not documented in the usual file format docs, which have not been
updated in ages.

https://vtk.org/wp-content/uploads/2015/04/file-formats.pdf (PDF was created in 2003)
https://kitware.github.io/vtk-examples/site/VTKFileFormats/#xml-file-formats

I've tested that these files work in Paraview and VisIt.

Thanks-to: Dave May <dave.mayhem23@gmail.com>

show more ...

Fixbug: allocate enough space for coords when transform is true

Plex ex15: Fix test

Plex: Fix global-to-natural in view

Plex: Add size check to DMPlexGlobalToNaturalBegin()

Merge branch 'jacobf/2023-01-21/improve-ci-coverage' into 'main'

Improve CI Coverage

See merge request petsc/petsc!6000

Inline all of the PetscStr* functions that map to basic str functions so __builtin_ variants can be used by compiler

Improve Mat and DM coverage by ifdef-ing out unused code that otherwise should not count
towards coverage

Merge branch 'jolivet/fix-warnings' into 'main'

Fix -Wunused-parameter -Wunused-but-set-parameter

See merge request petsc/petsc!6023

Merge remote-tracking branch 'origin/release'

Fix Typos

Fix -Wunused-parameter -Wunused-but-set-parameter

Make PetscErrorCode a non-discardable enum

Merge branch 'release'

Fix -Wimplicit-fallthrough

Merge remote-tracking branch 'origin/release'

Modernize and clean up petscsys.h

- Deprecate PETSC_NULL.
- Switch from preprocessor defines to anonymous enums for constant expressions.
- Surround macro arguments in ().
- Remove redundant casts.

Modernize and clean up petscsys.h

- Deprecate PETSC_NULL.
- Switch from preprocessor defines to anonymous enums for constant expressions.
- Surround macro arguments in ().
- Remove redundant casts.
- Clean up overly complex preprocessor defines in various PetscMem*() functions.

show more ...

Plex: Fix 1d geometry with 3D coordinates

Merge branch 'jed/fe-simplex-quadrature' into 'main'

PetscFE simplex quadrature

See merge request petsc/petsc!5525

Merge branch 'bourdin/fix-DMPlexCreateNaturalVector' into 'main'

Fixed a bug when setting up natural vector block size

See merge request petsc/petsc!5960

Fixed a bug when setting up natural vector block size

DMPlex/DT: update tests for efficient simplex quadrature

DMPlex tests/ex5: update tri and tet numerical values for prior code

This commit is in preparation for a change to the quadrature that will
not affect these numerical values. I bisected on ex5_tet_0

DMPlex tests/ex5: update tri and tet numerical values for prior code

This commit is in preparation for a change to the quadrature that will
not affect these numerical values. I bisected on ex5_tet_0 to find two
commits that introduced numerical changes and summarize their impact
here. I'm expecting the other changes to be similar.

The first numerical change was caused by

commit e1a13dae02585224ddd4368ee030f3c5e77a306b
Author: Matthew Knepley <knepley@gmail.com>
Date: Thu Apr 28 10:27:14 2022 -0400

Plex: Fix fault face division
- Should not split a face that only touches the fault on unsplit points

src/dm/impls/plex/plexsubmesh.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)

which has the numerical change:

diff --git 1/base.out 2/here.out
index df7196b66a9..9534c0139ad 100644
--- 1/base.out
+++ 2/here.out
@@ -150,15 +150,15 @@ Vec Object: Local Solution 1 MPI process
0.
1.5
1.
-0.
-1.
-0.
0.5
0.
0.
-0.5
0.
0.
+0.
+1.
+0.
Discrete System with 2 fields
cell total dim 27 total comp 6
cohesive cell
@@ -222,23 +222,23 @@ Vec Object: Local Residual 1 MPI process
0.
0.
0.
--3.46945e-18
-0.0833333
-0.0833333
0.0208333
-0.0625
+0.0208333
0.0416667
-0.0208333
-0.0208333
0.0416667
+0.0833333
0.
+0.104167
+0.0416667
0.
+-1.34017e-17
0.
0.
+-9.26063e-18
0.
0.
-0.
-0.
+7.55411e-18
0.
Mat Object: Jacobian 1 MPI process
type: seqaij

The second commit

commit d6177c40aeff79f5090ba5db2353273bea8a20ec
Author: Toby Isaac <toby.isaac@gmail.com>
Date: Wed Jun 29 10:29:10 2022 -0400

Use DMLabelStratumHasPoint() in CheckPoint_Private()

plex test ex61 shows there are corner cases where checking the labelId is necessary

src/dm/impls/plex/plex.c | 12 ++++--------
src/dm/impls/plex/tests/ex61.c | 1 -
2 files changed, 4 insertions(+), 9 deletions(-)

which had the numerical change

diff --git 1/base2.out 2/here.out
index 9534c0139ad..5af4b0229e2 100644
--- 1/base2.out
+++ 2/here.out
@@ -142,14 +142,14 @@ Vec Object: Local Solution 1 MPI process
1.
1.5
0.
-0.5
-1.
-1.
-1.
-1.
0.
-1.5
-1.
+0.
+0.
+0.
+0.
+0.
+0.
+0.
0.5
0.
0.
@@ -231,15 +231,15 @@ Vec Object: Local Residual 1 MPI process
0.
0.104167
0.0416667
-0.
--1.34017e-17
-0.
-0.
--9.26063e-18
-0.
-0.
-7.55411e-18
-0.
+0.0416667
+0.145833
+0.166667
+0.0833333
+0.166667
+0.166667
+0.0416667
+0.1875
+0.166667
Mat Object: Jacobian 1 MPI process
type: seqaij
row 0: (0, 0.) (1, 0.) (2, 0.) (3, 0.) (4, 0.) (5, 0.) (6, 0.) (7, 0.) (8, 0.) (9, 0.) (10, 0.) (11, 0.)

show more ...