cast memzeros to void to avoid compiler complaints about const qualifiers

DMLabel: added PETSCSECTIONSYMLABEL

Different symmetries are applied to different points (e.g. edges and
facets), so this is the most universal way I could come up with to

- break up the points in

DMLabel: added PETSCSECTIONSYMLABEL

Different symmetries are applied to different points (e.g. edges and
facets), so this is the most universal way I could come up with to

- break up the points in the section's chart into different symmetry
types, and
- specify what symmetries are acceptable (i.e., not assume automatically
that the range in [-coneSize,coneSize)

show more ...

DMLabel: use ISGetMinMax() in DMLabelGetStratumBounds

Patched and reported by: Stephan Kramer <s.kramer@imperial.ac.uk>

Building out the whole set of indices each time is bad for IS
implementations

DMLabel: use ISGetMinMax() in DMLabelGetStratumBounds

Patched and reported by: Stephan Kramer <s.kramer@imperial.ac.uk>

Building out the whole set of indices each time is bad for IS
implementations other than ISGeneral.

show more ...

DMLabel: Clear PetscBT when clearing point (fix regression)

Reported-by: Lawrence Mitchell <lawrence.mitchell@imperial.ac.uk>

Thanks to Lawrence for this patch. Here is his report:

Dear all (but

DMLabel: Clear PetscBT when clearing point (fix regression)

Reported-by: Lawrence Mitchell <lawrence.mitchell@imperial.ac.uk>

Thanks to Lawrence for this patch. Here is his report:

Dear all (but mostly Toby),

some recent changes in DMLabel changed the semantics of DMLabelHasPoint.

In particular, after ad8374f (DMLabel: switch internal storage from
array to IS), clearing a label value produces bad results. Consider
the following:

int main(int argc, char **argv)
{
PetscErrorCode ierr;
DMLabel label;
PetscInt val;
PetscBool flg;
PetscInitialize(&argc, &argv, NULL, NULL);

ierr = DMLabelCreate("foo", &label);CHKERRQ(ierr);

ierr = DMLabelCreateIndex(label, 0, 1);CHKERRQ(ierr);
ierr = DMLabelSetValue(label, 0, 1);CHKERRQ(ierr);
ierr = DMLabelHasPoint(label, 0, &flg);CHKERRQ(ierr);
ierr = DMLabelGetValue(label, 0, &val);CHKERRQ(ierr);
PetscPrintf(PETSC_COMM_WORLD, "Label has point %d, value is %d\n",
flg, val);CHKERRQ(ierr);

ierr = DMLabelClearValue(label, 0, 1);CHKERRQ(ierr);
ierr = DMLabelHasPoint(label, 0, &flg);CHKERRQ(ierr);
ierr = DMLabelGetValue(label, 0, &val);CHKERRQ(ierr);
PetscPrintf(PETSC_COMM_WORLD, "Label has point %d, value is %d\n",
flg, val);CHKERRQ(ierr);

PetscFinalize();
return 0;
}

Before this change:

$ ./bork
Label has point 1, value is 1
Label has point 0, value is -1

After the change:

$ ./bork
Label has point 1, value is 1
Label has point 1, value is -1

So you can see that although the point has been cleared from the point
of view of GetValue, it has not if I use HasPoint.

The problem appears to be that the invalidation of the label after
ClearValue no longer clears the PetscBT entry that exists if an index
has been created.

show more ...

DMLabel: use ISLocate()

DMLabel: added DMLabelSetStratumIS()

DMLabel: switch internal storage from array to IS

This is intended to allow for more efficient storage of common label types, such as the depth label,
where each stratum is contiguous. In the long

DMLabel: switch internal storage from array to IS

This is intended to allow for more efficient storage of common label types, such as the depth label,
where each stratum is contiguous. In the long view, I think this will be useful when making DA and
Plex use the same interface. For a DA, it might be convenient to specify a subset (for, e.g.,
boundary conditions), using an ISStride or some kind of tbd ISSlice.

show more ...

DMLabel: Fixed DMLabelGather()
- The leaves are not compact, but rather follow the local numbering, so we need to allocate nroots space

DMLabel: Removed unused variable

DMLabel: Added DMLabelHasStratum()

Plex: Determination of stratum indices from strum values was flawed

DMLabel: Add missing cleanup for DMLabelGather()

Merge branch 'tisaac/dmforest' into mlange/fix-plex-multi-level-overlap

Conflicts:
src/dm/impls/plex/examples/tests/output/ex12_5.out
src/dm/label/dmlabel.c