Manual fixes needed for linter for the KSP directory
Profiling: Improve !defined(PETSC_USE_LOG) #defines- If we cast macro arguments to void, we can avoid unused errors that have forced lots of conditionally included code like this:```c #if def
Profiling: Improve !defined(PETSC_USE_LOG) #defines- If we cast macro arguments to void, we can avoid unused errors that have forced lots of conditionally included code like this:```c #if defined(PETSC_USE_LOG) PetscLogEvent event; #endif```- Having global counters like petsc_TotalFlops externed event if !PetscDefined(USE_LOG) helps to remove a lot of needless `#ifdef`s around code that can instead be placed in `if (PetscDefined(USE_LOG)) {}` blocks.
show more ...
Track levels of nesting of KSP, for example KSPBJACOBI has nesting 1 higher than the calling KSP
... and apply it
Rename PetscValidPointer -> PetscAssertPointer
Deploy new PetscValidPointer, remove PetscValidXXXPointer
Lint apply: ksp
HAVE_FORTRAN should be USE_FORTRAN_BINDINGS since it is about generating the Fortran bindings, not about if the Fortran compiler exists
PCMG: in principle any failure should trigger the setup error
Format the ftn-custom files with clang-format. Apparently no particular reason we did not format them initially
More manual page fixes
non-test and tutorial makefiles only need rules.doc not the full rulesCommit-type: documentation
Only makefiles in the test and tutorial directories need lib/petsc/conf/testCommit-type: housekeeping
Fix manual pages based on reports from Jacob's lint toolCommit-type: documentation
Remove now unneeded SOURCE* variables from makefilesCommit-type: configure, housekeeping
Remove unneeded SOURCEH from makefilesNo longer used by docs or build
Remove empty preprocessor variables
Remove unneeded declarations of LOCDIR from all the makefilesCommit-type:documentation
Inline all of the PetscStr* functions that map to basic str functions so __builtin_ variants can be used by compiler
Make PetscErrorCode a non-discardable enum
Merge remote-tracking branch 'origin/release'
Fix some typos
Remove unneeded " on xxx" from most Collective comments in manual pagesThe phrase was unneeded 99% of the timeI did not remove in the dm directory since another MR is still active that affects th
Remove unneeded " on xxx" from most Collective comments in manual pagesThe phrase was unneeded 99% of the timeI did not remove in the dm directory since another MR is still active that affects that directoryCommit-type: documentation/spend 20m
clean up some dangling seterrqs
12345678910>>...21