Merge branch 'barry/2023-07-18/manual-linter-fixes-ksp' into 'main'

Manual fixes needed for linter for the KSP directory

See merge request petsc/petsc!6735

Fix typos

Fix missing new lines at the end of PetscInfo() calls

Manual fixes needed for linter for the KSP directory

Merge branch 'tisaac/feature-log-handler' into 'main'

Deglobalize logging into PetscLogHandler and PetscLogState

See merge request petsc/petsc!6709

Merge branch 'jose/fix-warn-pcmpi' into 'main'

Fix compile warning in pcmpi.c with debugging=1

See merge request petsc/petsc!6759

Make PCLSC scalable

Fix compile warning in pcmpi.c with debugging=1

petsc/src/ksp/pc/impls/mpi/pcmpi.c: In function 'PCMPICreate':
petsc/src/ksp/pc/impls/mpi/pcmpi.c:129:12: error: 'found' may be used uninitialized in

Fix compile warning in pcmpi.c with debugging=1

petsc/src/ksp/pc/impls/mpi/pcmpi.c: In function 'PCMPICreate':
petsc/src/ksp/pc/impls/mpi/pcmpi.c:129:12: error: 'found' may be used uninitialized in this function [-Werror=maybe-uninitialized]
129 | *found = 0;
| ~~~~~~~^~~

show more ...

Profiling: Improve !defined(PETSC_USE_LOG) #defines

- If we cast macro arguments to void, we can avoid unused errors that have
forced lots of conditionally included code like this:

```c
#if def

Profiling: Improve !defined(PETSC_USE_LOG) #defines

- If we cast macro arguments to void, we can avoid unused errors that have
forced lots of conditionally included code like this:

```c
#if defined(PETSC_USE_LOG)
PetscLogEvent event;
#endif
```

- Having global counters like petsc_TotalFlops externed event
if !PetscDefined(USE_LOG) helps to remove a lot of needless
`#ifdef`s around code that can instead be placed in
`if (PetscDefined(USE_LOG)) {}` blocks.

show more ...

Change the options database API for PCMPI to eliminate the -mpi_ options prefix; thus one can run -mpi_linear_solver_server -ksp_type cg -pc_type gamg to get the parallel version of these preconditio

Change the options database API for PCMPI to eliminate the -mpi_ options prefix; thus one can run -mpi_linear_solver_server -ksp_type cg -pc_type gamg to get the parallel version of these preconditioners.

Commit-type: usability

show more ...

Track levels of nesting of KSP, for example KSPBJACOBI has nesting 1 higher than the calling KSP

Remove nested declaration of variable pc

Commit-type: housekeeping

... and apply it

Rename MatChop() into MatFilter()

Rename PetscValidPointer -> PetscAssertPointer

Deploy new PetscValidPointer, remove PetscValidXXXPointer

PCApplyTranspose_FieldSplit(): fix Schur complement implementation

Reported-by: Chris Douglas <douglas@ladhyx.polytechnique.fr>

[0]PETSC ERROR: --------------------- Error Message -----------------

PCApplyTranspose_FieldSplit(): fix Schur complement implementation

Reported-by: Chris Douglas <douglas@ladhyx.polytechnique.fr>

[0]PETSC ERROR: --------------------- Error Message --------------------------------------------------------------
[0]PETSC ERROR: Object is in wrong state
[0]PETSC ERROR: Mat object's type is not set: Argument # 1
[0]PETSC ERROR: #1 MatGetFactorAvailable() at src/mat/interface/matrix.c:4820
[0]PETSC ERROR: #2 PCGetDefaultType_Private() at src/ksp/pc/interface/precon.c:25
[0]PETSC ERROR: #3 PCSetUp() at src/ksp/pc/interface/precon.c:1109
[0]PETSC ERROR: #4 KSPSetUp() at src/ksp/ksp/interface/itfunc.c:406
[0]PETSC ERROR: #5 KSPSolve_Private() at src/ksp/ksp/interface/itfunc.c:826
[0]PETSC ERROR: #6 KSPSolveTranspose() at src/ksp/ksp/interface/itfunc.c:1122
[0]PETSC ERROR: #7 PCApplyTranspose_FieldSplit() at src/ksp/pc/impls/fieldsplit/fieldsplit.c:1487
[0]PETSC ERROR: #8 PCApplyTranspose() at src/ksp/pc/interface/precon.c:715
[0]PETSC ERROR: #9 KSP_PCApply() at include/petsc/private/kspimpl.h:380
[0]PETSC ERROR: #10 KSPInitialResidual() at src/ksp/ksp/interface/itres.c:63
[0]PETSC ERROR: #11 KSPSolve_GMRES() at src/ksp/ksp/impls/gmres/gmres.c:226
[0]PETSC ERROR: #12 KSPSolve_Private() at src/ksp/ksp/interface/itfunc.c:900
[0]PETSC ERROR: #13 KSPSolveTranspose() at src/ksp/ksp/interface/itfunc.c:1122
[0]PETSC ERROR: #14 main() at ex9.c:80
[0]PETSC ERROR: Reached the main program with an out-of-range error code 1. This should never happen

show more ...

Merge remote-tracking branch 'origin/release'

PCGAMG: must call PCReset_MG during PCReset_GAMG

Fix -Wextra-semi-stmt

PCHPDDM: fix wrong Fortran interface

Manual linter fixes: ksp

Lint apply: ksp

PC: fix a bug -- we need to get the diagonal block A if pmat is derived from MPIAIJ

Merge remote-tracking branch 'origin/release'