MatProduct: proper cleanup of additional data structure

Do not mess with view/destroy routine, add an extra slot to MatProduct struct to stash the data, destroy/view routines
Deprecate MatFreeInterm

MatProduct: proper cleanup of additional data structure

Do not mess with view/destroy routine, add an extra slot to MatProduct struct to stash the data, destroy/view routines
Deprecate MatFreeIntermediateStructures in favor of MatProductClear
Clean up base headers for matrix classes
Update tests (remove some todos from ex70 because now the tests work properly)
MatProductSetType should not set the setfromoptions operation!
MatProductClear should reset operations
Remove no longer needed function composition
Add few more PetscInfo messages
Single dispatch routine
MatProductSetFromOptions routines are now allowed to fail
MatProductSetFromOptions_SeqXBAIJ_SeqDense: support for MATPRODUCT_AtB
MatTransposeMatMultNumeric_SeqAIJ_SeqDense: fix bug with leading dimensions
Make internal functions PETSC_INTERN
Fix a couple of places where the destroy routine of the matrix was changed
Products should all use internal data (or composed data attached to the internal data)
Fix few bugs in MPIAIJ_MPIDENSE product with stages

show more ...

Merge remote-tracking branch 'origin/hzhng/matproduct-api'

This branch reorganizes the API of mat-mat operations: A*B, At*B, A*Bt, PtAP, RARt, A*B*C
- See matproduct.c for detailed description of new API
- removed API function XXXSymbolic() and XXXNumeric()

This branch reorganizes the API of mat-mat operations: A*B, At*B, A*Bt, PtAP, RARt, A*B*C
- See matproduct.c for detailed description of new API
- removed API function XXXSymbolic() and XXXNumeric()
- removed subroutines MatMatMult_xxx, MatPtAP_xxx, ...
- modified MatxxxSymbolic_XXX() prototype (product is an input now)
- selection of algorithm is in MatProductSetFromOptions_xxx()

show more ...

Merge remote-tracking branch 'origin/maint'

Merge branch 'balay/fix-cuda-pgi/maint' into 'maint'

cuda: fix build error with pgc++

See merge request petsc/petsc!2561

PETSC_SKIP_IMMINTRIN_H_CUDAWORKAROUND should not be used in aijperm.c

Merge remote-tracking branch 'origin/maint'

Merge branch 'hongzh/fix-avx512-aijperm' into 'maint'

Fix AVX512 for old gcc compilers (rebased on maint)

See merge request petsc/petsc!2224

Fix AVX512 for old gcc compilers

--with-avx512-kernels=0 does not work for old gcc compilers

Reported-by: Lisandro Dalcin <dalcinl@gmail.com>

Merge remote-tracking branch 'origin/barry/add-petscarrayxxx-ops' [PR #1771]

Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new forms

Replace a couple multi-mallocs with a single malloc
Replace backwards loops in MatSetValues_*()

Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new forms

Replace a couple multi-mallocs with a single malloc
Replace backwards loops in MatSetValues_*() with PetscArraymove()

Commit-type: style-fix, feature

show more ...

Merged in barry/update-collective-on (pull request #1744)

Update the use of Collective on in the manual pages to reflect the new style

Update the use of Collective on in the manual pages to reflect the new style

Commit-type: style-fix, documentation
Thanks-to: Patrick Sanan <patrick.sanan@gmail.com>

Merged in psanan/man-pages-remove-keywords (pull request #1717)

Man pages: Remove .keywords fields

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be unif

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be uniformly used or maintained.

Thus, remove all .keywords: fields, and a following blank line, if present.

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find src/ -type f -exec gsed -i '/keywords:/d' {} +
find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find include/ -type f -exec gsed -i '/keywords:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod
Remove use of common block from MPIUNI code
use was in wrong location
Fortran line extends past 72 char
Moved the rest of the PETSc common block variables over to petscsys module
tests: fix breakage due to cd93b0e13c6da70ee1e038f55989cf888bc1d1c5
Need to use petscsys to get PETSC_COMM_SELF defined in example
Mat ex23 and ex40: fix errors reported from nightly tests
Put declaration on too lines because otherwise it generates an error for truncated line
Move PETSC_COMM_WORLD and PETSC_COMM_SELF from common blocks to petscsys module
tests: fix requires - and create out files for seqaijmkl tests
KSP ex72: nested dissection is likely to be different between machines
cmake: downgrade to version 3.9 - as newer versions require cxx11 compiler [which is not universal]. However stick with version 3.11 on opensolaris
Mat ex23: fix memory leaks
Bib: Some new refs
KSP examples: add missing casts to double in printf
updated GAMG KSP tests
PetscRound() should be PetscRoundReal() in __fp16
...

Conflicts:
include/petsclog.h
src/sys/logging/plog.c
src/sys/logging/utils/eventlog.c

show more ...

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to ne

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to new ANL style
Hash: Quick documentation fix
PetscBinaryViewerRead -> PetscViewerBinaryRead
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for DrMemory which may serve as an alternative to valgrind on Windows
Finish Gail's copyedits for developers manual.
openmpi: fix namespace conflict [with static build on ppc64le]
two pages of Gail's edits to developers guide
Another chapter of Gail's copyedits for the developers guide
Gail's copyedits on two more chapters of the developers guide
Fix more %d to %D in GAMG code. Fix code style in GAMG code
DMPlexVTK: vertices is int! need to use %d instead of %D
TS ex18: update outputs (reported by nightly tests)
Use %D in error messages for GAMG hash; fix style issues with GAMG hash
config: Update petsc4py git commit
Fix bad plain extern declaration.
Add Gail's copyedits for the initial portion of the developers guide
Add missing common block to subroutine
fix mpiuni tests with xl compilers
...

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (107 commits)
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for

Merge branch 'master' into knepley/feature-pc-patch

* master: (107 commits)
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for DrMemory which may serve as an alternative to valgrind on Windows
Finish Gail's copyedits for developers manual.
openmpi: fix namespace conflict [with static build on ppc64le]
two pages of Gail's edits to developers guide
Another chapter of Gail's copyedits for the developers guide
Gail's copyedits on two more chapters of the developers guide
Fix more %d to %D in GAMG code. Fix code style in GAMG code
DMPlexVTK: vertices is int! need to use %d instead of %D
TS ex18: update outputs (reported by nightly tests)
Use %D in error messages for GAMG hash; fix style issues with GAMG hash
config: Update petsc4py git commit
Fix bad plain extern declaration.
Add Gail's copyedits for the initial portion of the developers guide
Add missing common block to subroutine
fix mpiuni tests with xl compilers
Copy & paste the change on PetscSparseDensePlusDot
Fix a wrong macro
PetscInfo: Add missing errorchecking
Log: various fixes and cleanups
...

Conflicts:
src/dm/impls/plex/plex.c

show more ...

Merge branch 'rmills/fix-aijperm-add-MatPtAP_is_seqaijperm'

Added missing composed function MatPtAP_is_seqaijperm_C().

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing CHKERRQ()
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Add a test for ex21
Fix error in ex21
Add missing fortran interface that handles null objects
DMComposite: add missing guards
MatPreallocate: fix overpreallocation of local rows
style fixes
MatView_MPI_DA: do not print twice the class prefix
MatSetOperation: stash the original MatView_XXX in the viewnative function pointer
DMCreateInterpolation_DA gracefully error instead of catching FPE signals
MatIncreaseOverlap: preserve communicator of index sets
MatMPIAIJ: fix indentation and missing CHKERRQ
ISBuildTwoSided: remove tabs and fix style
Fix documentation
PetscViewerDraw: fix unininitialized warning from valgrind
MatConvert_SeqAIJ_SeqBAIJ: remove error for non square matrices and add MAT_REUSE_MATRIX case
Mat: MAT_INPLACE_MATRIX can be used for transposition with rectangular matrices
...

Conflicts:
src/dm/dt/interface/dtfe.c
src/dm/impls/plex/plex.c
src/dm/impls/plex/plexfem.c
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/makefile
src/snes/examples/tutorials/output/ex62_18.out
src/snes/examples/tutorials/output/ex62_19.out
src/snes/examples/tutorials/output/ex62_20.out
src/snes/examples/tutorials/output/ex62_20_parmetis.out
src/snes/examples/tutorials/output/ex62_21.out
src/snes/examples/tutorials/output/ex62_22.out
src/snes/examples/tutorials/output/ex62_23.out
src/snes/examples/tutorials/output/ex62_24.out
src/snes/examples/tutorials/output/ex62_25.out
src/snes/examples/tutorials/output/ex62_26.out
src/snes/examples/tutorials/output/ex62_27.out
src/snes/examples/tutorials/output/ex62_28.out
src/snes/examples/tutorials/output/ex62_29.out
src/snes/examples/tutorials/output/ex62_2d_p3_1.out
src/snes/examples/tutorials/output/ex62_30.out
src/snes/examples/tutorials/output/ex62_31.out
src/snes/examples/tutorials/output/ex62_32.out
src/snes/examples/tutorials/output/ex62_33.out
src/snes/examples/tutorials/output/ex62_34.out
src/snes/examples/tutorials/output/ex62_35.out
src/snes/examples/tutorials/output/ex62_36.out
src/snes/examples/tutorials/output/ex62_pc_simple.out
src/snes/examples/tutorials/output/ex62_pc_simplec.out
src/snes/examples/tutorials/output/ex62_quad_q2p1_full.out
src/snes/examples/tutorials/output/ex62_quad_q2q1_full.out
src/snes/utils/dmplexsnes.c

show more ...

Merge branch 'master' into knepley/feature-error-logging

* master: (221 commits)
dashboard: count and list example compile failures like:
fix fix-pr879-jczhang-optimize-vecscatter-multi-copy
a

Merge branch 'master' into knepley/feature-error-logging

* master: (221 commits)
dashboard: count and list example compile failures like:
fix fix-pr879-jczhang-optimize-vecscatter-multi-copy
add manual page cross links for SNESLineSearchSetPostCheck() and related routines
fix help manual of MatCreateSubmatrices() Reported-by: Tim Steinhoff <kandanovian@gmail.com>
Add manual pages for PetscRealPart() and PetscImaginaryPart()
fix compile error with missing MPI_C_DOBULE_COMPLEX
fix typo Reported-by: Febrian Setianto <febrian.setianto@gmail.com>
plex tutorial ex5: updated test requirements
DMPlexLoad_HDF5_Xdmf_Internal: fix for complex PetscScalar.
DMPlexLoad_HDF5_Xdmf_Internal: fix for 64-bit PetscInt.
DMPlexBuildFromCellList_Internal: use DMPlexInvertCell_Internal (with PetscInt* arg)
petscviewer.h: removed notice which is no longer relevant
DMPlexCreateFromFile: document option
check only if PETSC_USE_DEBUG
DMPlexBuildFromCellList_Internal optionally inverts cells.
ex5: new test 4 with -compare without repartitioning
ex5: new test 3 using -compare
ex5: HDF5 write+read moved to separate function
ex5: option -format processed in ProcessOptions()
ex5: added missing hdf5 requirement
...

Conflicts:
include/petsclog.h

show more ...