Remove some PetscCheckFalse()
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX() -> PetscCallThrow()- CHKERRCXX() -> PetscCallCXX()- CHKERRCUDA() -> PetscCallCUDA()- CHKERRCUBLAS() -> PetscCallCUBLAS()- CHKERRCUSPARSE() -> PetscCallCUSPARSE()- CHKERRCUSOLVER() -> PetscCallCUSOLVER()- CHKERRCUFFT() -> PetscCallCUFFT()- CHKERRCURAND() -> PetscCallCURAND()- CHKERRHIP() -> PetscCallHIP()- CHKERRHIPBLAS() -> PetscCallHIPBLAS()- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()- CHKERRQ_CEED() -> PetscCallCEED()- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()- CHKERRMKL() -> PetscCallMKL()- CHKERRMMG() -> PetscCallMMG()- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()- CHKERRCGNS() -> PetscCallCGNS()- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()- CHKERRSTR() -> PetscCallSTR()- CHKERRTC() -> PetscCallTC()
show more ...
PetscInitialize() and PetscFinalize() wrapped:- ierr = PetscInitialize();if (ierr) return ierr;+ CHKERRQ(PetscInitialize());- ierr = PetscFinalize();- return ierr;+ CHKERRQ(PetscFinalize());+
PetscInitialize() and PetscFinalize() wrapped:- ierr = PetscInitialize();if (ierr) return ierr;+ CHKERRQ(PetscInitialize());- ierr = PetscFinalize();- return ierr;+ CHKERRQ(PetscFinalize());+ return 0;
pluck ~1000 low hanging PetscCheckFalse() -> PetscCheck() fruit
chkerr and friends wrapped
rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()
add PetscAssert() and PetscAssertFalse()
SETERRQ[1-9]+ begone
applied attribute format fixes to mat headers
Some missing CHKERR[Q|MPI]
Remove all double blank lines from sourceCommit-type: petsc-style/2h
For factorization types/packages that do not perform a seperate symbolic phase do not log the event.Also log the "numerical" factorization as an entire factorizationAn alternative would be to pro
For factorization types/packages that do not perform a seperate symbolic phase do not log the event.Also log the "numerical" factorization as an entire factorizationAn alternative would be to provide MatXXXFactorSetUp_XXX that is called in lieu of the symbolic functionfor such types/packages but requires more changes to the code.Commit-type: bug fix for logging/spend 45mReported-by: Xiaoye S. Li <xsli@lbl.gov>Reported-by: Stephen Jardin <jardin@pppl.gov>Reported-by: Jin Chen <jchen@pppl.gov>Reported-by: Nan Ding <nanding@lbl.gov>Reported-by: Yang Liu <liuyangzhuan@lbl.gov>
Turn on checkbadSource test to generate an error when found; fix all source code that causes errorsCommit-type: portability-fix, testing-fix, style-fix, feature, maintainability/spend 1.5h
Single petscdir.mk
build: add more support for not needing to set PETSC_DIR yet build with PETSc, also support for GNU make to directly use "make test" instead of "make -f gmakefile.test"Still needs -include ../petsc
build: add more support for not needing to set PETSC_DIR yet build with PETSc, also support for GNU make to directly use "make test" instead of "make -f gmakefile.test"Still needs -include ../petscdir.mk in many of the makefilesStill needs the link for ../petscdir.mk in many directoriesGNUMakefile: call legacy makefile recursively instead of including itGNUMakefile: promote default "all" target; "libs" builds libpetsc*GNUMakefile: If gnumake < 4.2 prefer makefile wrapper interface over direct gmakefile interface to avoid the following warningsgmakefile.test:92: arch-ci-linux-cxx-cmplx-pkgs-64idx/tests/testfiles: No such file or directorygmakefile:67: arch-ci-linux-cxx-cmplx-pkgs-64idx/lib/petsc/conf/files: No such file or directoryCommit-type: testing-fix, feature, usabilityThanks-to: Jed Brown jed@jedbrown.org
Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new formsReplace a couple multi-mallocs with a single mallocReplace backwards loops in MatSetValues_*()
Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new formsReplace a couple multi-mallocs with a single mallocReplace backwards loops in MatSetValues_*() with PetscArraymove()Commit-type: style-fix, feature
Add documentation that MATLAB-PETSc and PETSc->Mat transfers of matrices resultin the transpose of the matrix on the other side.Commit-type: documentationReported-by: Jose E. Roman <jroman@dsic.u
Add documentation that MATLAB-PETSc and PETSc->Mat transfers of matrices resultin the transpose of the matrix on the other side.Commit-type: documentationReported-by: Jose E. Roman <jroman@dsic.upv.es>
Fix MatSeqAIJFromMatlab() it assumed that the inode structure could changeonly if the number of nonzeros changed in the matrix but, in fact, the strutureof the matrix could change while the number
Fix MatSeqAIJFromMatlab() it assumed that the inode structure could changeonly if the number of nonzeros changed in the matrix but, in fact, the strutureof the matrix could change while the number of nonzeros remained the same.Fixed memory leak in example and missing CHKERRQ(ierr);Commit-type: bug-fix, testing-fixReported-by: Alp Dener <adener@anl.gov>
Man pages: add newlines after "Notes:"This allows for proper formatting from sowing.On OS X (using gsed, not the default BSD sed), from the PETSc root directory: find src include -type f \(
Man pages: add newlines after "Notes:"This allows for proper formatting from sowing.On OS X (using gsed, not the default BSD sed), from the PETSc root directory: find src include -type f \( -name "*.c" -or -name "*.h" -or -name "*.cxx" \) | xargs gsed -i 's/Notes\s*:\s*\(\w.*\)/Notes:\n \1/'This adds a newline and 4 spaces whenever "Notes:" is followed by any "word" character, in any .c, .h, or .cxx file in src/ or include/
change MatSolverType to be a const char* typedef to match other XXTypeCommit-type: style-fixReported-by: Franck Houssen <franck.houssen@inria.fr>
Fix name MatSolverPackage since it is better to be consistent and use the terminology Type.Commit-type: style-fix, documentation
fix terrible name for routines that view the info level of matrixResulted in links from MatFactorInfo to MatFactorInfo_XXX() which are really unrelated routinesCommit-type: documentation
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-t
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-to: Andreas Mang <andreas@ices.utexas.edu>
Refactored ./configures handling of package requirements for precision. Now each package indicateswhat it supports withself.precisions = ['single','double','__float128']Updated the package files t
Refactored ./configures handling of package requirements for precision. Now each package indicateswhat it supports withself.precisions = ['single','double','__float128']Updated the package files to indicate what they supportRemoved unneeded #requires arguments from makefiles for external packages.Time: 2 hoursReported-by: Patrick Sanan <patrick.sanan@gmail.com>
Cleaned up MatGetFactor_seqaij_matlab()No longer creates dummy SeqAIJ matrix for factorClears matrix and factors from Matlab memory when PETSc Mat object is destroyedRemoved unneeded mention of -
Cleaned up MatGetFactor_seqaij_matlab()No longer creates dummy SeqAIJ matrix for factorClears matrix and factors from Matlab memory when PETSc Mat object is destroyedRemoved unneeded mention of -with-matlab-engine from Matlab.py
1234567