Merge branch 'barry/2022-03-30/strip-petscall-petsctrymethod' into 'main'Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallSee merge request petsc/petsc!5051
Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codesBoth for debug and optimized buildsAlso removes shadow declaration errors from use of mpiu_allreduceCommit-type: error-
Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codesBoth for debug and optimized buildsAlso removes shadow declaration errors from use of mpiu_allreduceCommit-type: error-checkingReported-by: Lisandro Dalcin <dalcinl@gmail.com>
show more ...
Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallIt produces shadow declarations and also serves no purpose since these macros do the appropriate error checking alreadyThere may be addit
Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallIt produces shadow declarations and also serves no purpose since these macros do the appropriate error checking alreadyThere may be additions needed for running with a static error checkerCommit-type: error-checking/spend 15mReported-by:Lisandro Dalcin <dalcinl@gmail.com>
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX() -> PetscCallThrow()- CHKERRCXX() -> PetscCallCXX()- CHKERRCUDA() -> PetscCallCUDA()- CHKERRCUBLAS() -> PetscCallCUBLAS()- CHKERRCUSPARSE() -> PetscCallCUSPARSE()- CHKERRCUSOLVER() -> PetscCallCUSOLVER()- CHKERRCUFFT() -> PetscCallCUFFT()- CHKERRCURAND() -> PetscCallCURAND()- CHKERRHIP() -> PetscCallHIP()- CHKERRHIPBLAS() -> PetscCallHIPBLAS()- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()- CHKERRQ_CEED() -> PetscCallCEED()- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()- CHKERRMKL() -> PetscCallMKL()- CHKERRMMG() -> PetscCallMMG()- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()- CHKERRCGNS() -> PetscCallCGNS()- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()- CHKERRSTR() -> PetscCallSTR()- CHKERRTC() -> PetscCallTC()
pluck ~1000 low hanging PetscCheckFalse() -> PetscCheck() fruit
chkerr and friends wrapped
Fix compilation warnings-Wmissing-field-initializers -Wunused-but-set-variable
Remove PetscAssertFalse(), change some incorrect use of PetscAssert*() for OUTOFRANGE to PetscCheck()Commit-type: error-checking, style-fix/spend 1h
Enforce PetscCheck() and PetscAssert() usage via checkbadSource
rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()
add PetscAssert() and PetscAssertFalse()
make PetscInfo() variadic
SETERRQ[1-9]+ begone
Slightly improve the manual pages for MATSELLCommit-type: documentation\spend 45m
remove trailing newline from SETERRQ
applied attribute format fixes to mat headers
Mat: add code to view Mvctx
Style: replace "!rank" with "rank == 0"In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds les
Style: replace "!rank" with "rank == 0"In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds lesstightly, so the result of the computation would otherwise change.
Fix spelling errors in manpages and comments
Mat: more on removing the unneeded +1 in memory allocation for garray
Mat: remove the unneeded +1 in memory allocation for garray
Remove all double blank lines from sourceCommit-type: petsc-style/2h
Merge remote-tracking branch 'origin/release'
fix gcc-11 warnings for -Wstringop-overflow - however can't fix MPI calls - so also use -Wno-stringop-overflow
All MPIU_ functions except MPIU_File return MPI error codes for checkingUpdate checkbadSource to find use of CHKERRQ with MPIU_ functionsCommit-type: i.e. error-checking, optimization, bug-fix, p
All MPIU_ functions except MPIU_File return MPI error codes for checkingUpdate checkbadSource to find use of CHKERRQ with MPIU_ functionsCommit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, exampleFunded-by:Project:Time: hoursReported-by:Thanks-to:Development Tools: Vim, Emacs, Eclipse
1234567