Merge remote-tracking branch 'origin/release'

Some documentation and visibility fixes

Mat: fix SELL HIP warnings on pragma unroll with rocm-5.4.0

/path/to/sellhip.hip.cpp:309:3: warning: loop not unrolled: the optimizer was unable to perform the requested transformation; the transfor

Mat: fix SELL HIP warnings on pragma unroll with rocm-5.4.0

/path/to/sellhip.hip.cpp:309:3: warning: loop not unrolled: the optimizer was unable to perform the requested transformation; the transformation might be disabled or specified as part of an unsupported transformation ordering [-Wpass-failed=transform-warning]
  for (int offset = WARP_SIZE / 2; offset >= sliceheight; offset /= 2) { t += __shfl_down(t, offset); }

show more ...

Mat: fix -Wmissing-field-initializers

This requires some changes to user FORTRAN code

Pass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an array
Pass PETSC_NULL_ENUM when argument returns an enum instead of

This requires some changes to user FORTRAN code

Pass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an array
Pass PETSC_NULL_ENUM when argument returns an enum instead of PETSC_NULL_INTEGER
Pass arrays (and not scalar values) when the argument is expecting an array; this means replace, for example, the argument v with [v]
Use PetscObjectIsNull(obj) to check if the object is NULL, instead of obj == PETSC_NULL_XXX

The compiler will now automatically prevent you from using the wrong argument type for the first three bullets above
This will also require an update sowing with the new sowing branch this MR is using.

show more ...

Merge remote-tracking branch 'origin/release'

Remove now redundant increase in mat nonzero state

Fix serious bugs in MatSetValuesBlocked for SeqBAIJ and MPIBAIJ when a reallocation is needed.

Reported-by: Adrian Croucher <a.croucher@auckland.ac.nz>

Merge remote-tracking branch 'origin/release'

Fix gcc-14 -Warray-bounds warnings for hypothetical negative sizes

These warnings arise because we use (signed int32) PetscInt for sizes
that must be nonnegative, then cast to size_t. This leads to

Fix gcc-14 -Warray-bounds warnings for hypothetical negative sizes

These warnings arise because we use (signed int32) PetscInt for sizes
that must be nonnegative, then cast to size_t. This leads to warnings
when the compiler doesn't know that the integers can't be negative.

In function ‘PetscMemzero’,
inlined from ‘TSARKIMEXRegister’ at /home/jed/petsc/src/ts/impls/arkimex/arkimex.c:1182:10:
/home/jed/petsc/include/petscstring.h:758:3: warning: ‘memset’ pointer overflow between offset 0 and size [-17179869184, -8] [-Warray-bounds=]
758 | memset(a, 0, n);
| ^~~~~~~~~~~~~~~

Compare commit 095c51fa7c16ea848964bdaab3c2c2b53b8a3072 from 2023:
Fix gcc-13 -Warray-bounds warnings involving hypothetical negative sizes

show more ...

Update source code removing all unneeded /*@C and associated manual stubs and interfaces

Add SELLHIP

- The HIP kernels are converted directly from their CUDA version
- AMD GPUs and NVIDIA GPUs use different warp sizes. We set the warp size to 64 by default for AMD GPUs to faciliate comp

Add SELLHIP

- The HIP kernels are converted directly from their CUDA version
- AMD GPUs and NVIDIA GPUs use different warp sizes. We set the warp size to 64 by default for AMD GPUs to faciliate compile-time code optimization

show more ...

Remove carriage return in Petsc(Assert|Check)()

git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'

Suggested-by: Stefan

Remove carriage return in Petsc(Assert|Check)()

git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'

Suggested-by: Stefano Zampini

show more ...

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g'
git grep -l -E "Petsc(.)*\(\(\*[a-zA-Z0-9_]*\)," | xargs sed -r -i'' 's#Petsc([a-zA-Z0-9_]*)\(\(\*([a-zA-Z0-9_]*)\), #Petsc\1(*\2, #g'
git grep -l -E "([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)" | xargs sed -r -i'' 's#([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)#\1\2#g'

show more ...