g++11: fix -Werror=misleading-indentation

Merge branch 'barry/2021-05-16/fix-double-lines' into 'main'

Fix typos in source

See merge request petsc/petsc!3984

Remove all double blank lines from source

Commit-type: petsc-style
/2h

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge remote-tracking branch 'origin/dalcinl/fix-null'

TS/SNES/Tao: Fix 0 ->NULL for pointers

See merge request petsc/petsc!2783

SNES: Replace 0 -> NULL for pointers

Merge remote-tracking branch 'origin/maint'

Merge branch 'jed/sneslinesearch-type/maint' into 'maint'

Jed/sneslinesearch type/maint

See merge request petsc/petsc!2692

SNES: only change linesearch type when not already set

This is necessary to allow users to SNESLineSearchSetType before SNESSetFromOptions.

Merge branch 'stefanozampini/fix-snescomposite-update' into 'master'

Fix update vector in SNESCOMPOSITE

See merge request petsc/petsc!2582

SNESNGMRES: minor

Merge remote-tracking branch 'origin/barry/add-petscarrayxxx-ops' [PR #1771]

Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new forms

Replace a couple multi-mallocs with a single malloc
Replace backwards loops in MatSetValues_*()

Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new forms

Replace a couple multi-mallocs with a single malloc
Replace backwards loops in MatSetValues_*() with PetscArraymove()

Commit-type: style-fix, feature

show more ...

Merged in psanan/man-pages-remove-keywords (pull request #1717)

Man pages: Remove .keywords fields

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be unif

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be uniformly used or maintained.

Thus, remove all .keywords: fields, and a following blank line, if present.

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find src/ -type f -exec gsed -i '/keywords:/d' {} +
find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find include/ -type f -exec gsed -i '/keywords:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merged in barry/fix-linesearch-usage (pull request #1563)

SNESLineSearch should only be created and used if the SNES type requires the line search

SNESLineSearch should only be created and used if the SNES type requires the line search

Previously the line search was created for all solver and and SNESLineSearchSetFromOptions()
and SNESLineSear

SNESLineSearch should only be created and used if the SNES type requires the line search

Previously the line search was created for all solver and and SNESLineSearchSetFromOptions()
and SNESLineSearchView() called for all solvers, even those that never used it,
leading to confusion for users

Commit-type: feature, documentation
Reported-by: Robert Nourgaliev <nourgaliev1@llnl.gov>

show more ...

Merge commit 'd47bf9aaf1e5266cc3f0ff499f934c85788965a9' into jed/fix-matcreatempibaij/maint

Obtain changed (v3.5) handling of MatMPIBAIJSetPreallocationCSR to match
documentation.

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page information about convergence testing when using KSPRICHARDSON
SNES ex5: Restore old output since this breaks an example I have
Noted that some Cray XC systems will use 'aprun' instead of 'srun'. Thanks to Herr Doktor Hong Zhang for this suggestion.
Added example configure script for Cray XC40 with KNL processors (e.g., NERSC Cori).
Fix possible sprintf -Wformat-overflow
PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7
SNES ex5: make boundary condition handling consistent for symmetry
SNES ex5: use L2 norm and *_monitor_short for output
SNES ex5: the L^2 norm scales with the l^2 norm over sqrt(N)
SNES ex5: refactor MMS capability to avoid extreme code duplication
Documentation fix: typo in PetscLogStageRegister manual page.
nodes -> vertices
rename DMNetworkGetComponentTypeOffset -> DMNetworkGetComponentKeyOffset
rename DMNetworkGetConnectedNodes() -> DMNetworkGetConnectedVertices()
Jacobians for adjoints for explicit methods and constant Jacobians never got initialized
fix complex build error
fix build failure with fortran interface
fix compile error with cdc753b64c658d532d7813e942002e67025667a6
...

Conflicts:
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/ex69.c

show more ...

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output l

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output log for snes_tutorials-ex62_fetidp_3d_tet that got corrupted in 188e10d6f1cffa866ec0197053a0e55fa4e7da41
fix opensolaris build error with --with-log=0 Undefined first referenced symbol in file PetscLogEventGetPerfInfo arch-opensolaris-misc/tests/src/dm/impls/plex/examples/tests/ex9.o
fix warnings on windows C:\cygwin64\home\petsc\PETSC~1.CLO\src\tao\examples\TUTORI~1\ex1.c(217): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)'
disable example with absoft (due to fixed/free form limit)
c89 fixes
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
Plex ex19: Remove unneeded code
Plex: Fix projection when we have a dmAux which is a domain boundary - If we are projecting on a lower dimension thing (effectiveHeight > 0), then we need to get the space and dual space on this subcell - The tabulation needs to be in the right dimension for both dm and dmAux
PetscFE: Added height subspaces to PetscFE - Added PetscFEGetHeightSubspace() - Added array in struct
PetscDualSpace: Small cleanup of parameter name
PetscSpace: Added height subspaces for PetscSpace - Added PetscSapceGetHeightSubspace() and member function - Added subspaces array
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix some minor style issues
Extend AMS/ADS to support high-order element.
...

show more ...

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Merge branch 'master' into knepley/feature-dm-bc-components

* master: (320 commits)
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ m

Merge branch 'master' into knepley/feature-dm-bc-components

* master: (320 commits)
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
output has changed with e6d0a238963c2a97dd04845ea512b529992c7cdb so update the output file
...

show more ...

Merge remote-tracking branch 'origin/barry/consistent-formating-ascii-solver-viewers'

Make ASCII PC/KSP/SNES/TSView() code and output in a standard style

The code that prints the ASCII view for solvers was occasionally inconsistent:
1) TSView printed the type specific information aft

Make ASCII PC/KSP/SNES/TSView() code and output in a standard style

The code that prints the ASCII view for solvers was occasionally inconsistent:
1) TSView printed the type specific information after the general info while
all other solvers printed it before (right after the name of the type is printed)
2) KSPView consistently printed the name of the subtype on EACH line of the subtypes
output as did a few of the PC and SNES viewers. Since they are all printed indented
directly below the subtype name there is no reason to print this information on each line
3) TSView printed output about number of linear solvers and SNES even for explicit
methods, which is goofy.
4) a few other minor formatting and consistency issues where fix.

Commit-type: style-fix, feature
Time: 16 hours

show more ...