Turn on checkbadSource test to generate an error when found; fix all source code that causes errorsCommit-type: portability-fix, testing-fix, style-fix, feature, maintainability/spend 1.5h
SNES: Replace 0 -> NULL for pointers
SNES: only change linesearch type when not already setThis is necessary to allow users to SNESLineSearchSetType before SNESSetFromOptions.
SNESNGMRES: minor
ESSL: reorganize code that handles PETSC_MISSING_LAPACK by using PetscMissingLapack()And sync the missing function list with missing functions in current ESSLIf we find more LAPACK symbols missin
ESSL: reorganize code that handles PETSC_MISSING_LAPACK by using PetscMissingLapack()And sync the missing function list with missing functions in current ESSLIf we find more LAPACK symbols missing in commonly used LAPACK impls,we can add them back in the new format.src/ksp/pc/impls/bddc/bddcprivate.c has alternate code forPETSC_MISSING_LAPACK_GESVD. This code is retained for now [in case weneed to add this flag back in]
show more ...
SNES: minor
Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new formsReplace a couple multi-mallocs with a single mallocReplace backwards loops in MatSetValues_*()
Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new formsReplace a couple multi-mallocs with a single mallocReplace backwards loops in MatSetValues_*() with PetscArraymove()Commit-type: style-fix, feature
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be unif
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be uniformly used or maintained.Thus, remove all .keywords: fields, and a following blank line, if present.This is accomplished with GNU sed (gsed on OS X), with the following commands.*Warning* that this type of command can corrupt a .git directory,so be cautious in reusing or modifying these commands. They first lookfor and delete matching lines with a following line consisting of only whitespace,and then delete any remaining matching lines. find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find src/ -type f -exec gsed -i '/keywords:/d' {} + find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find include/ -type f -exec gsed -i '/keywords:/d' {} +Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed
SNESLineSearch should only be created and used if the SNES type requires the line searchPreviously the line search was created for all solver and and SNESLineSearchSetFromOptions()and SNESLineSear
SNESLineSearch should only be created and used if the SNES type requires the line searchPreviously the line search was created for all solver and and SNESLineSearchSetFromOptions()and SNESLineSearchView() called for all solvers, even those that never used it,leading to confusion for usersCommit-type: feature, documentationReported-by: Robert Nourgaliev <nourgaliev1@llnl.gov>
Add two APIs: SNESGetUpdateNorm and SNESGetSolutionNormRetrieve update and solution normsWe may/might want to print update and solution norms in a user-provided convergence checker if the SNES co
Add two APIs: SNESGetUpdateNorm and SNESGetSolutionNormRetrieve update and solution normsWe may/might want to print update and solution norms in a user-provided convergence checker if the SNES converged due to a small update length.
SNES: Fix 'extern' declarations
Make ASCII PC/KSP/SNES/TSView() code and output in a standard styleThe code that prints the ASCII view for solvers was occasionally inconsistent:1) TSView printed the type specific information aft
Make ASCII PC/KSP/SNES/TSView() code and output in a standard styleThe code that prints the ASCII view for solvers was occasionally inconsistent:1) TSView printed the type specific information after the general info while all other solvers printed it before (right after the name of the type is printed)2) KSPView consistently printed the name of the subtype on EACH line of the subtypes output as did a few of the PC and SNES viewers. Since they are all printed indented directly below the subtype name there is no reason to print this information on each line3) TSView printed output about number of linear solvers and SNES even for explicit methods, which is goofy.4) a few other minor formatting and consistency issues where fix.Commit-type: style-fix, featureTime: 16 hours
fix -Wundef -Wold-style-definition warningsReported-by: Till Martens <till.martens@dlr.de>
fix duplicate definitions warned by -Wredundant-declsAlso a bugfix? BLASdotu_ -> dotuReported-by: Till Martens <till.martens@dlr.de>
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-t
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-to: Andreas Mang <andreas@ices.utexas.edu>
Fixed manual page for -snes_anderson_betaFix code formatting error and missing ierr =Time: .1 hoursReported-by: Jonas Mairhofer <mhofer@itt.uni-stuttgart.de>
SNES: Add flag indicating if final residual is always computedAlthough SNESSolve_XXX always updates the solution variable, it may notbe the case that the residual in vec_func is the residual at th
SNES: Add flag indicating if final residual is always computedAlthough SNESSolve_XXX always updates the solution variable, it may notbe the case that the residual in vec_func is the residual at the newsolution. Track this behaviour explicitly for all concreteimplementations. We will use this in SNESSolve_FAS to determine if theresidual must be computed before transferring it between levels.
use of unitialized and badly named variable in SNESSetFromOptions_Anderson()Reported-by: nightly test
TSIRM had no test case, had memory leaks, bugs including monitor printing everything twiceReported-by: gcov
Added static to a variety of KSP and SNES methodsFound agmres directory not listed in the makefile so added it and fixed some codes to get it to compile
a couple of fixes suggested by clang analyzeradd missing error checkingminor formatting fixes
fixed up formatting of references in manualpages to consistent styleReferences:+ 1. - ref1. 2. - ref2- 3. - ref3previously the formatting was varied and ugly
broken nonlinear solver table links fixedReported-by: Andrew McRae <A.T.T.McRae@bath.ac.uk>Also made References: formatting consistent by always listing authors first
Begin renaming the PetscOptions objects for the future where PetscOptions will not be a singleton
fix violations of PETSc style guide: Usage of SETERRQ and NULL
12345678910