Merge branch 'tmunson/tao-bqpip-fix-code-and-documentation'

Reset the broyden approximation before starting lmvm. May want an
option to reused the approximation in the future.

Update test case output for tron.

Add test case to test blmvm as a subsolver.

T

Reset the broyden approximation before starting lmvm. May want an
option to reused the approximation in the future.

Update test case output for tron.

Add test case to test blmvm as a subsolver.

Time: Way too long.

show more ...

Updates to pounders code for subproblem solvers and consistency
between tao defaults and solver defaults.

Time: way too much

Conform to PETSc standard style

Time: 0.5 hour

Remove dead code and parameters from BQPIP.
Dead code was some feature that was partially implemented a long time ago.
No idea what that feature was supposed to be.

Time estimate include trying to f

Remove dead code and parameters from BQPIP.
Dead code was some feature that was partially implemented a long time ago.
No idea what that feature was supposed to be.

Time estimate include trying to figure out what the new feature
was supposed to do.

Time: 2 hours

show more ...

Modifications to actually compute the bounds before tightening them.
Calculate quadratic, linear, and constant terms in a stable manner.
Check user quadratic, linear, and constant terms for Inf or Na

Modifications to actually compute the bounds before tightening them.
Calculate quadratic, linear, and constant terms in a stable manner.
Check user quadratic, linear, and constant terms for Inf or NaN.

Time: 1 hour

show more ...

Super minor changes to fix grammer and coding style.

Time: 5 minutes

Finishing elimination of static functions from header files and
organizing the source code.

Time: 0.25 hours

Static functions should not be declared in the header files.

Time: 0.1 hour

Conform to PETSc standard style

Time: 0.5 hour

Update bound constrained solvers for updated calling sequence

Time: 10 minutes

removed a bunch of unneeded inclusions of xxximpl.h which exposed private data where it did not have to be exposed

also made more systematic the inclusion of the base xxximpl.h in the derived yyyimp

removed a bunch of unneeded inclusions of xxximpl.h which exposed private data where it did not have to be exposed

also made more systematic the inclusion of the base xxximpl.h in the derived yyyimpl.h
so the inclusion is done in the include file rather than in each source code that includes it

show more ...

Updated script for detecting visible symbols

Removed unneeded visibility of some symbols
Fixed some namespacing
Removed the use of unneeded implementation includes in the TAO code