Revert the function name where it is referenced

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

show more ...

Regularization changed to x-x_old, user hook added into optimization loops, eliminated explicit MatTransposeMatMult option in Hessian computation

Changed VecScatterCreate() to take a communicator and return scatter as other first class PETSc objects do.
Changed old VecScatterCreate() to VecScatterCreateWithData()

Completed basic refactorizati

Changed VecScatterCreate() to take a communicator and return scatter as other first class PETSc objects do.
Changed old VecScatterCreate() to VecScatterCreateWithData()

Completed basic refactorization of VecScatter code, ready for new implementations to be added.

(There is still some code duplication between the VecScatter MPI1 and MPI3 code but it can be fixed at anytime without requiring changes to the VecScatter API.

Part 5 of a refactorization of VecScatter to be treated as a first class PETSc object

Commit-type: style-fix

show more ...

initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.

Commit-type: testing-fix
Reported-by: clang static analyzer