Revert the function name where it is referenced

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

show more ...

Do some housekeeping and add missing CHKERRQ calls

Regularization changed to x-x_old, user hook added into optimization loops, eliminated explicit MatTransposeMatMult option in Hessian computation

Changed VecScatterCreate() to take a communicator and return scatter as other first class PETSc objects do.
Changed old VecScatterCreate() to VecScatterCreateWithData()

Completed basic refactorizati

Changed VecScatterCreate() to take a communicator and return scatter as other first class PETSc objects do.
Changed old VecScatterCreate() to VecScatterCreateWithData()

Completed basic refactorization of VecScatter code, ready for new implementations to be added.

(There is still some code duplication between the VecScatter MPI1 and MPI3 code but it can be fixed at anytime without requiring changes to the VecScatter API.

Part 5 of a refactorization of VecScatter to be treated as a first class PETSc object

Commit-type: style-fix

show more ...

logical order bug in diagbrdn update fixed, tests updated again

test files updated to account for minor roundoff differences

Fixed a few more things. Added back in recycling. Added the ability for the user to set their own preconditioner with TaoBNCGSetH0.

Removed the experimental Steffenson acceleration feature from this

Fixed a few more things. Added back in recycling. Added the ability for the user to set their own preconditioner with TaoBNCGSetH0.

Removed the experimental Steffenson acceleration feature from this branch.

Fixed everything in Todd's code walkthrough except turning the VecDots into VecDotBegin, VecDotEnd combinations

Forgot to also remove xi from DiagBrdn. That is gone now too.

Updated the TAO manual so far.

Replaced VecDot with VecDotBegin and VecDotEnd in DiagBrdn.

Addressing an uninitialized variable problem after merging with another branch.

Changed the PetscMaxes back into zero checks; they were degrading the solvers.

Whatever was broken is now fixed. Need to test all methods officially again. diagbrdn.c was reset to before Alp and Todd's comments were fixed.

Fixed m=1 in diagbrdn.c

Tried changing the PetscMax bounds to 1.e-10 from 1.e-8

Bring it back to 1.e-8 since it did a little worse. Worth tinkering with.

Changed the last couple too-specific error checks on scaling terms in DiagBrdn.

Changed data structure in bncg.h to put IS data type right after Vec.

Removed alpha==-1.0 from DiagBrdn. Updated TAO manual to reflect name changes and added a parameter to it not added before.

Added a KSPInitialize in BNCG_Create

Had to fix some logic with recycling.

Minor bugfix.

Fixed the recycle off-by-one bug from last commit.

Fixed issues regarding complex numbers.

Fix call to PetscIsInfOrNan.

Managed to complete many of Todd's code walkthrough pt. 2 comments.

Fixed things from Todd's code walkthrough. Primarily allowed more user options and added some comments on functionality.

Changed default behavior of KouDai.

Changed CG_Types to not have an underscore.

show more ...

Missing CHKERRQ(); Mostly in Tao code

Commit-type: testing-fix,style-fix
Reported-by: clang static analyzer

reverting back to using shared MatSolve interface