TaoSetType: Do not destroy gradient and stepdirection vectors

Defer KSPDestroy to those methods that actually creates a KSP
Leave linesearch destroy, since it may be solver dependent

Merge branch 'stefanozampini/tao-ew' into 'main'

TAO: add Support for Eisenstat and Walker

See merge request petsc/petsc!5311

TaoComputeBounds: generate vectors only if needed

Merge branch 'jacobf/2022-04-05/petscattrformat-all-the-rest' into 'main'

Enable PETSC_ATTRIBUTE_FORMAT()

See merge request petsc/petsc!5085

Enable PETSC_ATTRIBUTE_FORMAT()

Merge branch 'barry/2022-04-01/fix-petsc-options-begin-end/release' into 'main'

Remove bogus error returns from Begin/End() macros

See merge request petsc/petsc!5069

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

chkerr and friends wrapped

Merge branch 'stefanozampini/checkstack' into 'main'

Check Push/Pop

See merge request petsc/petsc!4077

checkBadSource: fix ierr=

Merge branch 'stefanozampini/update-checkbadsource' into 'main'

Update badsource rules

See merge request petsc/petsc!4064

Update badsource rules

- Zero or more spaces are not allowed for more returning types
- zero spaces not allowed for for|if|while

Merge branch 'barry/2021-05-16/fix-double-lines' into 'main'

Fix typos in source

See merge request petsc/petsc!3984

Remove all double blank lines from source

Commit-type: petsc-style
/2h

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merged in barry/fix-naming-cg-methods (pull request #1650)

Fixed inconsistent naming with CG methods for TR

Approved-by: Matthew Knepley <knepley@gmail.com>

Fixed inconsistent naming with CG methods for TR

Some of the KSPXXX macros for xxx had an inconsisten KSPCGXXX that was not in the string xxx name
The KSPCGXXX was used for KSPCreate_CGXXX() but the

Fixed inconsistent naming with CG methods for TR

Some of the KSPXXX macros for xxx had an inconsisten KSPCGXXX that was not in the string xxx name
The KSPCGXXX was used for KSPCreate_CGXXX() but the other method functions were missing the CG, for example, KSPSolve_XXX()
(these meant using tags to find functions was cumbersome due to the special cases)
Missing Fortran macro

Removed the extraneous CG from the macros and the function usage; now all macros and functions have consistent PETSc style usage
that match the string names
Added deprecation messages for out-dated use
Added new configure check for PETSC_DEPRECATED_MACRO

I decided to remove the CG from the KSPCGXXX instead of adding a cg to the string name because 1) it was not possible to deprecate
the string names at compile time, we would have to have runtime warnings. 2) the string names are shorter, 3) the stcg already
had a cg (at the end and not the beginning) and that would have to be removed or we'd have the absurd cgstcg. If starting from
sratch today not worrying about legacy I would have all the string names begin with cg consistently (and naturally the KSPXXX would
have them as well), but for legacy reasons we have the current naming which is not ideal because it does not clearly
indicate which methods are CG methods. (We have this problem with other subclasses in PETSc also).

Commit-type: style-fix

show more ...

Merge branch 'master' of bitbucket.org:petsc/petsc

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, t

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype.
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

- Tao: PETSc does not print warnings

- MatAssembled: there's no point in checking the type
a matrix with type not set cannot be assembled

- TaoBNKEstimateActiveSet: Call MatHasOperation() only if the matrix has been assembled
the previous logic for MatGetDiagonal still holds. With this fix, the code will not error in case the hessian has not been assembled at this time

show more ...

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

show more ...

Merge branch 'master' into jpusztay/feature-swarm-symplectic-example

Merge branch 'master' into jpustay/feature-swarm-example