Style: replace "!rank" with "rank == 0"

In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds les

Style: replace "!rank" with "rank == 0"

In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds less
tightly, so the result of the computation would otherwise change.

show more ...

Merge branch 'stefanozampini/update-checkbadsource' into 'main'

Update badsource rules

See merge request petsc/petsc!4064

Update badsource rules

- Zero or more spaces are not allowed for more returning types
- zero spaces not allowed for for|if|while

Merge branch 'barry/2021-05-16/rm-star-comments' into 'main'

Remove use of * at beginning of comment line and /** and **/

See merge request petsc/petsc!3985

Remove use of * at beginning of comment line and /** and **/

Merge branch 'barry/2021-05-16/fix-double-lines' into 'main'

Fix typos in source

See merge request petsc/petsc!3984

Remove all double blank lines from source

Commit-type: petsc-style
/2h

Merge branch 'balay/switch-master-to-main' into 'master'

Balay/switch master to main

See merge request petsc/petsc!3619

git: switch default branch from 'master' to 'main'

Merge branch 'barry/2020-10-08/fix-mpi-error-codes' into 'master'

Convert MPI error type to PETSc error with string message for all MPI calls

See merge request petsc/petsc!3326

Convert MPI error type to PETSc error with string message for all MPI calls

Now PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-pro

Convert MPI error type to PETSc error with string message for all MPI calls

Now PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-process their
errors better.

The test harness will now automatically retry tests that fail with MPI, this may help with Intel MPI that produces
seemingly random failures.

Commit-type: error-checking
/spend 30m

show more ...

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge remote-tracking branch 'origin/barry/add-petscarrayxxx-ops' [PR #1771]

Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new forms

Replace a couple multi-mallocs with a single malloc
Replace backwards loops in MatSetValues_*()

Add PetscArraycmp(), PetscArraycpy(), PetscArrayzero(), PetscArraymove(), update code to use new forms

Replace a couple multi-mallocs with a single malloc
Replace backwards loops in MatSetValues_*() with PetscArraymove()

Commit-type: style-fix, feature

show more ...

Merge branch 'master' of bitbucket.org:petsc/petsc

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, t

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype.
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

- Tao: PETSc does not print warnings

- MatAssembled: there's no point in checking the type
a matrix with type not set cannot be assembled

- TaoBNKEstimateActiveSet: Call MatHasOperation() only if the matrix has been assembled
the previous logic for MatGetDiagonal still holds. With this fix, the code will not error in case the hessian has not been assembled at this time

show more ...

Tao: PETSc does not print warnings

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

show more ...

Merge branch 'master' into jpusztay/feature-swarm-symplectic-example

Merge branch 'master' into jpustay/feature-swarm-example

Merged petsc/petsc into master

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (393 commits)
Bib: Update reference
Mat: Doc fix
Bib: Updated ref
PetscDS: Doc fixes
PC+LU: Do not try to refactor an

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (393 commits)
Bib: Update reference
Mat: Doc fix
Bib: Updated ref
PetscDS: Doc fixes
PC+LU: Do not try to refactor an already factored matrix
Mat: Small fix for checking and docs
Mat: Added MatSetFactorType() - Needed it when making a shell matrix look factored
PetscDS: Added PetscDSUpdateBoundary() - Lets the user change the boundary condition
single precision produces different convergence history
p4est: has a dependency on zlib - so handle it correctly
Add -mat_mffd_complex to use the Lyness complex number trick to compute J_u * v instead of differencing.
Replace VecWAXPY by VecAXPY if needed
Revert "Replace VecWAXPY by VecAXPY if needed"
Replace VecWAXPY by VecAXPY if needed
MatHermitianTransposeGetMat and MatCreateVecs
ex19: Updated test filter to avoid false positives.
DM: Improved Global-To-Natural docs Suggested-by: Josh L <ysjosh.lo@gmail.com>
Do not build shared openblas when doing static build
Upgrade OpenBLAS to 0.3.3
test: add alt output file for changes in OSX-10.14 and Xcode-10.0 [perhaps related to ML]
...

Conflicts:
src/vec/is/utils/vsectionis.c

show more ...

Merged petsc/petsc into master

Merge branch 'denera/tao-gauss-newton-wrapper' [PR #1151]

* denera/tao-gauss-newton-wrapper:
Regularized Gauss-Newton algorithm/wrapper
New BRGN algorithm added for regularized Gauss-Newton formulat

Merge branch 'denera/tao-gauss-newton-wrapper' [PR #1151]

* denera/tao-gauss-newton-wrapper:
Regularized Gauss-Newton algorithm/wrapper
New BRGN algorithm added for regularized Gauss-Newton formulation.
This algorithm is a thin wrapper that relies on TaoSetResidualRoutine() and TaoSetResidualJacobianRoutine() interfaces to accept the residual and Jacobian associated with a least-squares problem,
and then construct the internal objective, gradient and Hessian evaluation functions for the regularized problem formulation.
Currently only Tikhonov regularization is available, but other smooth regularizers are planned in the future.
The resulting regularized problem is passed onto an existing bound-constrained algorithm (e.g.: BQNLS or BNTL), controlled by the -tao_brgn_subsolver flag.

show more ...