Replace use of 1 with appropriate error code; use PetscObjecComm() instead of PETSC_COMM_SELF for errors when appropriate

Commit-type: error-checking, testing-fix, style-fix, examples

Merge branch 'master' of bitbucket.org:petsc/petsc

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, t

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype.
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

- Tao: PETSc does not print warnings

- MatAssembled: there's no point in checking the type
a matrix with type not set cannot be assembled

- TaoBNKEstimateActiveSet: Call MatHasOperation() only if the matrix has been assembled
the previous logic for MatGetDiagonal still holds. With this fix, the code will not error in case the hessian has not been assembled at this time

show more ...

Tao: PETSc does not print warnings

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx

TAOSetUpdate: change the Update callback

In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

show more ...

Merge branch 'master' into jpusztay/feature-swarm-symplectic-example

Merge branch 'master' into jpustay/feature-swarm-example

Merged petsc/petsc into master

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (393 commits)
Bib: Update reference
Mat: Doc fix
Bib: Updated ref
PetscDS: Doc fixes
PC+LU: Do not try to refactor an

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (393 commits)
Bib: Update reference
Mat: Doc fix
Bib: Updated ref
PetscDS: Doc fixes
PC+LU: Do not try to refactor an already factored matrix
Mat: Small fix for checking and docs
Mat: Added MatSetFactorType() - Needed it when making a shell matrix look factored
PetscDS: Added PetscDSUpdateBoundary() - Lets the user change the boundary condition
single precision produces different convergence history
p4est: has a dependency on zlib - so handle it correctly
Add -mat_mffd_complex to use the Lyness complex number trick to compute J_u * v instead of differencing.
Replace VecWAXPY by VecAXPY if needed
Revert "Replace VecWAXPY by VecAXPY if needed"
Replace VecWAXPY by VecAXPY if needed
MatHermitianTransposeGetMat and MatCreateVecs
ex19: Updated test filter to avoid false positives.
DM: Improved Global-To-Natural docs Suggested-by: Josh L <ysjosh.lo@gmail.com>
Do not build shared openblas when doing static build
Upgrade OpenBLAS to 0.3.3
test: add alt output file for changes in OSX-10.14 and Xcode-10.0 [perhaps related to ML]
...

Conflicts:
src/vec/is/utils/vsectionis.c

show more ...

Merged petsc/petsc into master

Merge branch 'denera/tao-gauss-newton-wrapper' [PR #1151]

* denera/tao-gauss-newton-wrapper:
Regularized Gauss-Newton algorithm/wrapper
New BRGN algorithm added for regularized Gauss-Newton formulat

Merge branch 'denera/tao-gauss-newton-wrapper' [PR #1151]

* denera/tao-gauss-newton-wrapper:
Regularized Gauss-Newton algorithm/wrapper
New BRGN algorithm added for regularized Gauss-Newton formulation.
This algorithm is a thin wrapper that relies on TaoSetResidualRoutine() and TaoSetResidualJacobianRoutine() interfaces to accept the residual and Jacobian associated with a least-squares problem,
and then construct the internal objective, gradient and Hessian evaluation functions for the regularized problem formulation.
Currently only Tikhonov regularization is available, but other smooth regularizers are planned in the future.
The resulting regularized problem is passed onto an existing bound-constrained algorithm (e.g.: BQNLS or BNTL), controlled by the -tao_brgn_subsolver flag.

show more ...

Regularization changed to x-x_old, user hook added into optimization loops, eliminated explicit MatTransposeMatMult option in Hessian computation

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead code.
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
...

Conflicts:
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (33 commits)
cleanup very ugly PCGAMG manual page
minor clarifications for VecScatterCreate() manual page
gcov: PETSC_ARCH is requ

Merge branch 'master' into knepley/feature-pc-patch

* master: (33 commits)
cleanup very ugly PCGAMG manual page
minor clarifications for VecScatterCreate() manual page
gcov: PETSC_ARCH is required onlyfor -run_gcov - and not for -merge_gcov [where it doesn't exist]
make clearer in help statements what --with-external-packages-dir is for.
Website: Added news entry for PETSc User Meeting 2018 on main page.
KSPGUESSPOD: exclude negative of zero eigenvalues from the energy computation
KSPGUESSFISCHER: use PetscInfo for KSP class
CUDA: Further test output fixes for mat_tests-ex2
Turn off elemental test for parmetis running since this does not work on batch systems.
3.8 Changes: KSPCHEBYSHEV
CUDA: Fixed most test errors due to MatMultTranspose*
KSPFGMRES: add KSP_NORM_NONE / PC_RIGHT as supported
KSPSetSupportedNorm man page: remove old note about default support for KSP_NORM_NONE
Dev manual: copyedit
DMPlexDistributeLabels: Propagate the output flag
cuda/cusp: update minimum supported versions of cuda to 7.5 and cusp to 0.5.0
cuda: remove configure option -with-cuda-arch. [use CUDAFLAGS instead]
projected gradient code fixed to obey recent convergence test changed
Merge conflicts resolved after rebase
norm update bug fixed in GPGC, test output reverted
...

show more ...

Merge remote-tracking branch 'origin/knepley/fix-snes-ex69' into tisaac/feature-dmfield

* origin/knepley/fix-snes-ex69: (311 commits)
PetscFECreateDefault: fix custom Fortran interface to use MPI_

Merge remote-tracking branch 'origin/knepley/fix-snes-ex69' into tisaac/feature-dmfield

* origin/knepley/fix-snes-ex69: (311 commits)
PetscFECreateDefault: fix custom Fortran interface to use MPI_Comm
SNES ex69: Updated test output
SNES ex69: Removed all mantle stuff and change fields to constants - Also use dsymutil for executables
SNES ex69: Removed special partition
SNES ex69: Fixed null space creation - Null space locks its vectors
PetscFE: PetscFECreateDefault() now takes MPI_Comm instead of DM
cleanup very ugly PCGAMG manual page
minor clarifications for VecScatterCreate() manual page
gcov: PETSC_ARCH is required onlyfor -run_gcov - and not for -merge_gcov [where it doesn't exist]
make clearer in help statements what --with-external-packages-dir is for.
Website: Added news entry for PETSc User Meeting 2018 on main page.
CUDA: Further test output fixes for mat_tests-ex2
Turn off elemental test for parmetis running since this does not work on batch systems.
3.8 Changes: KSPCHEBYSHEV
CUDA: Fixed most test errors due to MatMultTranspose*
website: update urls
website: fix Jason's name to match pic. Also add Todd's pic
Dev manual: copyedit
DMPlexDistributeLabels: Propagate the output flag
cuda/cusp: update minimum supported versions of cuda to 7.5 and cusp to 0.5.0
...

show more ...

Merge branch 'denera/tao-convergence-check-fix' [PR #886]

* denera/tao-convergence-check-fix:
TaoMonitor no longer has double-duty for both monitoring and updating the converged reason.
The converge

Merge branch 'denera/tao-convergence-check-fix' [PR #886]

* denera/tao-convergence-check-fix:
TaoMonitor no longer has double-duty for both monitoring and updating the converged reason.
The convergence function is now called explicitly in the algorithms following the monitor call, mimicking the current implementation of SNES.

show more ...

Convergence check separated from TaoMonitor. Changed propagated to unconstrained algorithms. Untested.

Merge branch 'denera/fix-tablevels-for-views' [PR #869]

* denera/fix-tablevels-for-views:
Instead of manual push-pop tab operations, views now inherit tablevels automatically.
This makes views consi

Merge branch 'denera/fix-tablevels-for-views' [PR #869]

* denera/fix-tablevels-for-views:
Instead of manual push-pop tab operations, views now inherit tablevels automatically.
This makes views consistent with default convergence monitors.

show more ...

Wrapping up for a pull request

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
superlu: libray is installed in PREFIX/lib64 - fix this to use PREFIX/lib
backport fixes cc105cc3 2b35c90a - required for 3bf428d - that was backported from master - 80c96bb
'echo -n' fails on opensolaris/osx - so avoid using it.
fix diffs in nightlybuilds due to options in ~/.petscrc
add Kelley03 to src/docs/tex/petsc.bib
build: determine moudles, mpi.h used during buildtime and print in 'info'
fix analyzer warnings
fix build failure on opensolaris - where -lm from flibs is removed due to -lm in cxxlibs. But then - only flib gets used for some configure tests [blaslapack, parms]
config: prefer __restrict over C99 restrict keyword
...

show more ...

Merge branch 'barry/remove-funct'

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-t

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-to: Andreas Mang <andreas@ices.utexas.edu>

show more ...

Merge branch 'master' into stefano_zampini/feature-pcbddc-saddlepoint

Conflicts:
src/ksp/pc/impls/bddc/bddc.c
src/ksp/pc/impls/bddc/bddcgraph.c
src/ksp/pc/impls/bddc/bddcprivate.c