| c8ecec41 | 19-May-2009 |
Kai Germaschewski <kai@germaschewski.name> |
TS: Cleanup unused/broken TS methods.
- the methods TS::reform(), TS::reallocate() were neither set nor called
ever.
- TS::update() and TS::postupdate() could be set, however update() would
neve
TS: Cleanup unused/broken TS methods.
- the methods TS::reform(), TS::reallocate() were neither set nor called
ever.
- TS::update() and TS::postupdate() could be set, however update() would
never be called, and postupdate() only in one place, for sundials.
This functionality will be taken over by prestep() / poststep()
eventually.
Hg-commit: ea766e6ef723ee210fe47af74bd4077c854d1282
show more ...
|
| e3caeda6 | 14-May-2009 |
Barry Smith <bsmith@mcs.anl.gov> |
From: kai.germaschewski@unh.edu
Subject: TS_RK enhancements
The attached patch fixes two issues (IMO) with TS_RK:
- the step numbering is slightly messed up: Before the timeloop starts, TSMonitor
From: kai.germaschewski@unh.edu
Subject: TS_RK enhancements
The attached patch fixes two issues (IMO) with TS_RK:
- the step numbering is slightly messed up: Before the timeloop starts, TSMonitor is called with steps=0, then after the first step, it is called again with steps=0, since steps is only incremented later. (Arguably, the step numbering is more messed up than this because failed steps are counted, but TSMonitor is not called. I would actually prefer to use ts->steps to count the number of successful steps, and leave the number of failed steps as an internal diagnostics only (shown in TSView()).
- TS_RK doesn't honor ts->max_steps. Whereas one could argue that setting a number of steps doesn't make too much sense for a timestepper with variable step size, it's actually useful for someone like me, see below.
- As a side effect, this patch also takes care of the warning "Very small steps: 0.0000" that normally happened just as the final time is reached. (In the next-to-last step, the step size would be set to be the difference between final time and current, time, the last step would then update the final time to current time and set the step size to 0, triggering the warning).
Hg-commit: 8f7ce1ea20b09de7ae059611c3dcd618194dc6f3
show more ...
|