when F90Array1dCreate() is passed a null pointer for a zero size array it still returns a valid F90 pointer but the F90Array1dAccess() does not return a null pointer hence ISRestoreIndicesF90() and V

when F90Array1dCreate() is passed a null pointer for a zero size array it still returns a valid F90 pointer but the F90Array1dAccess() does not return a null pointer hence ISRestoreIndicesF90() and VecRestoreArrayF90() should not call the restore if the length was zero

Hi,

There seems to be a bug in ISRestoreIndicesF90 when the locally owned portion of the index set is empty. I am attaching a small example illustrating the issue.

mpiexec -n 2 ./ISBugf90 -start_in_debugger
[0]PETSC ERROR: PETSC: Attaching gdb to ./ISBugf90 of pid 34744 on display /tmp/launch-kaUROB/org.x:0 on machine galerkin.math.lsu.edu
[1]PETSC ERROR: PETSC: Attaching gdb to ./ISBugf90 of pid 34745 on display /tmp/launch-kaUROB/org.x:0 on machine galerkin.math.lsu.edu
[0] Index set is permutation
[0] Number of indices in (stride) set 0
[1] Index set is permutation
[1] Number of indices in (stride) set 2
[1] 0 0
[1] 1 1
1 0 1
0
[0]PETSC ERROR: PetscTrFreeDefault() called from ISRestoreIndices_Stride() line 174 in /opt/HPC/petsc-dev/src/vec/is/impls/stride/stride.c
[0]PETSC ERROR: Block at address 0x105647200 is corrupted; cannot free;
may be block not allocated with PetscMalloc()
[0]PETSC ERROR: PetscTrFreeDefault() line 287 in /opt/HPC/petsc-dev/src/sys/memory/mtr.c Bad location or corrupted memory

The stack trace is
(gdb) where
#0 0x00007fff8e8c282a in __kill ()
#1 0x00007fff8ecf0a9c in abort ()
#2 0x00000001039bd19c in PetscAbortErrorHandler (comm=1140850689, line=287, fun=0x105491428 "PetscTrFreeDefault", file=0x105490a20 "/opt/HPC/petsc-dev/src/sys/memory/mtr.c", dir=0x104ff6808 "", n=78, p=PETSC_ERROR_INITIAL, mess=0x7fff6345e500 "Bad location or corrupted memory", ctx=0x0) at /opt/HPC/petsc-dev/src/sys/error/errabort.c:62
#3 0x00000001039b4c72 in PetscError (comm=1140850689, line=287, func=0x105491428 "PetscTrFreeDefault", file=0x105490a20 "/opt/HPC/petsc-dev/src/sys/memory/mtr.c", dir=0x104ff6808 "", n=78, p=PETSC_ERROR_INITIAL, mess=0x105490d2c "Bad location or corrupted memory") at /opt/HPC/petsc-dev/src/sys/error/err.c:356
#4 0x000000010394c29b in PetscTrFreeDefault (aa=0x105647950, line=174, function=0x1054ad654 "ISRestoreIndices_Stride", file=0x1054ad0a0 "/opt/HPC/petsc-dev/src/vec/is/impls/stride/stride.c", dir=0x104ff6808 "") at /opt/HPC/petsc-dev/src/sys/memory/mtr.c:287
#5 0x0000000103ab8c24 in ISRestoreIndices_Stride (in=0x7ff65901df70, idx=0x7fff6345f2a0) at /opt/HPC/petsc-dev/src/vec/is/impls/stride/stride.c:174
#6 0x0000000103ad3d89 in ISRestoreIndices (is=0x7ff65901df70, ptr=0x7fff6345f2a0) at /opt/HPC/petsc-dev/src/vec/is/interface/index.c:417
#7 0x0000000103c425c6 in isrestoreindicesf90_ (x=0x103863110, ptr=0x103863118, __ierr=0x7fff6345f360) at /opt/HPC/petsc-dev/src/vec/is/interface/f90-custom/zindexf90.c:29
#8 0x0000000103862d83 in isbug () at ISBugf90.F90:18
#9 0x0000000103862a3c in main ()

Hg-commit: eabb6a7fd6babf4aa63ab03139083cd735a52006

show more ...

Ensure that obj->ops->destroy is zeroed in XXSetType() after the old implementation has been destroyed.

There are circumstances where VecSetType() is called more than once to
change the type without

Ensure that obj->ops->destroy is zeroed in XXSetType() after the old implementation has been destroyed.

There are circumstances where VecSetType() is called more than once to
change the type without an intervening XXCreate_YY(). An example is
changing to VECSEQCUSP via VECCUSP.

Hg-commit: 1262149b3e206062ad0b002925300684fd3420e8

show more ...

Check for negative size to ISCreateStride()

Hg-commit: 2e8b02156917693dd4b70ab6d0d832412b676bd7

added P to report number for ANL reports

Hg-commit: b235f9ce30533f49d7b19e2c7612ef8dbefd53ce

Mass revert file modes that were made executable in f6e61ee9c329

Hg-commit: 116d90d0b66125cee0db3e7351047057e756baf5