en Copyright 2025 Java http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#d0e6bf2ad94dcc89b258ce16c7987200a4714786 Merge branch 'jolivet/clang-format-19' into 'main'clang-format-19See merge request petsc/petsc!7644 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Wed, 25 Sep 2024 06:44:18 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#57508ece14a6b1339c0bbf016ecd72f673a062b0 Remove unneeded parentheses List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Tue, 17 Sep 2024 23:49:15 +0000 Pierre Jolivet <pierre@joliv.et> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#970231d20df44f79b27787157e39d441e79f434b Merge branch 'jolivet/clang-format-18' into 'main'clang-format version 18See merge request petsc/petsc!6902 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Thu, 07 Mar 2024 12:36:17 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#4d86920da9ee67c835173a5dfffa1b3a52fd24ca checkbadSource: rules for PetscFunctionBegin and derivatives List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Sat, 10 Feb 2024 08:07:08 +0000 Pierre Jolivet <pierre@joliv.et> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#bff66efa9044f546ae447ed195723e21295eb6dd Merge branch 'ilya-fursov/ts-fixevent2' into 'main'TSEvent: refactor and fix bugs, add TSSetPostEventStep()See merge request petsc/petsc!6752 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Fri, 15 Dec 2023 16:29:03 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#ca4445c7a2f5ca546b532f08b853c371604af17c TSEvent: refactor and fix bugs, add TSSetPostEventStep() Refactor the core algorithm for resolution of events: TSEventHandler() and the helper functions, fixing the existing bugs. Change event indicator functions from PetscScalar to PetscReal. Change the API of TSSetEventHandler(): in the user `indicator()` callback, the 'fvalue' argument type changed from PetscScalar[] to PetscReal[]. Add TSSetPostEventStep(), deprecate TSSetPostEventIntervalStep(). Deprecate option -ts_event_post_eventinterval_step. Fix bugs in interaction of TSEvent with tspan. Add six new test examples. Below are the examples of bugs fixed by this patch. The source codes (ex3.c, ex3span.c, ex4.c, ex5.c) can be found in src/ts/event/tests. To run them with the older Petsc versions, one would need to comment out "#define NEW_VERSION". Behaviour for three library versions is reported below: * ORIG: current Petsc version, before the proposed patch. * 6688: independently of the proposed patch, Merge Request 6688 was developed, which fixed some bugs with zero-crossing directions. * NEW : the proposed patch. ./ex3 -ts_monitor -ts_event_monitor -ts_view -ts_type beuler \ -ts_adapt_type basic -flg -V 1e9 -ts_adapt_dt_min 1e-6 -change5 1 -dir 1 * ORIG: fails to resolve 5 out of 6 events, and resolves 23 incorrect events. * 6688: fails to exit the TSEvent iteration via the step size (bracket size) criterion. * NEW : ok, resolves all 6 events. ./ex4 -ts_adapt_type basic -ts_type rk -ts_dt 0.25 -ts_event_tol 1e-8 \ -dir 0 -ts_adapt_dt_min 1e-10 -ts_view -ts_monitor -ts_event_monitor * ORIG: only reaches t = 0.0300236 after 10000 TS steps. * 6688: only reaches t = 0.0300236 after 10000 TS steps. * NEW : ok, reaches the final time t = 4.0 after 96 TS steps, resolving all 16 events. ./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \ -ts_view -ts_dt 0.25 -flg -dir 0 * ORIG: only reaches t = 4.0 after 10000 TS steps, erroneously reports event at t = 4.0 around 5000 times. * 6688: only reaches t = 4.0 after 10000 TS steps. * NEW : ok, reaches the final time t = 10.0 after 99 TS steps, resolving all 34 events. ./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \ -ts_view -ts_dt 0.25 -flg -dir 1 * ORIG: fails, starts taking negative time steps, no events are correctly resolved. * 6688: ok, but slower: 90 TS steps to resolve all 17 events. * NEW : ok, and faster: 48 TS steps to resolve all 17 events. ./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \ -ts_view -ts_dt 0.25 -flg -dir -1 * ORIG: fails, starts taking 'nan' time steps. * 6688: mostly fails, only reaches t = 4.99993 after 10000 TS steps. * NEW : ok, reaches the final time t = 10.0 after 74 TS steps, resolving all 17 events. The same run in parallel: mpirun -n 2 ./ex5 -ts_monitor -ts_event_monitor -ts_type rk \ -ts_adapt_type basic -ts_view -ts_dt 0.25 -flg -dir -1 * ORIG: fails, starts taking negative time steps, exits with runtime error. * 6688: mostly fails, only reaches t = 3, besides, the parallel run is not consistent with the serial run (see above). * NEW : ok, reaches the final time t = 10.0 after 74 TS steps, resolving all 17 events. ./ex3span -ts_monitor -ts_event_monitor * ORIG: (confused by events) misses tspan points: 4.02, 4.21, 4.98, 5.01, 5.21, 5.98, 6, 6.01, 6.02, 6.21, 6.99, 7.21, 8.01, 8.21, 9.01. * 6688: (confused by events) misses tspan points: 4.02, 4.21, 4.98, 5.01, 5.21, 5.98, 6, 6.01, 6.02, 6.21, 6.99, 7.21, 8.01, 8.21, 9.01. * NEW : ok. ./ex3span -ts_monitor -ts_event_monitor -ts_event_post_event_step 0.5 * ORIG: misses the majority of tspan points (except 0.01 and 0.21), and also resolves the last event location at wrong time t = 9.21. * 6688: misses the majority of tspan points (except 0.01 and 0.21), and also resolves the last event location at wrong time t = 9.21. * NEW : ok. List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Thu, 20 Jul 2023 19:18:16 +0000 Ilya Fursov <ilya.foursov.7bd@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#4979242ec9aebc8f6bc1fe6d36da3613a7f5e93b Merge branch 'jacobf/2023-08-08/lint-apply-dm' into 'main'Manual DM Linter FixesSee merge request petsc/petsc!6792 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Wed, 09 Aug 2023 18:25:39 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#a4e35b1925eceef64945ea472b84f2bf06a67b5e Manual linter fixes: dm List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Tue, 08 Aug 2023 19:25:05 +0000 Jacob Faibussowitsch <jacob.fai@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#3c9c10a1c22da6a057e8319af956ca3e11de35d7 Merge branch 'jolivet/fix-typo' into 'main'Fix typosSee merge request petsc/petsc!6771 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Tue, 01 Aug 2023 17:11:08 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#145b44c9dda6e724c25668e48c0440cb162ee093 Fix typos List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Mon, 31 Jul 2023 20:07:03 +0000 Pierre Jolivet <pierre@joliv.et> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#cfd92c66bdae16b66d27a6336fb90fa54c459cc4 Merge branch 'tisaac/feature-type-generic-petsc-valid-pointer' into 'main'Implement a type generic PetscValidPointerSee merge request petsc/petsc!6693 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Sat, 22 Jul 2023 23:49:13 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#4f572ea9526f19623f23a8c158f3503516190bbc Rename PetscValidPointer -> PetscAssertPointer List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Tue, 18 Jul 2023 17:25:19 +0000 Toby Isaac <toby.isaac@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#02477ebbb21fa13a3b107e40dce1c3d726eb3600 Merge branch 'jacobf/2023-06-30/enable-doc-lint' into 'main'Enable docs lintingSee merge request petsc/petsc!6667 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Sat, 15 Jul 2023 03:37:44 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#60225df5d8469840be2bf9c1f64795a92b19f3c2 Lint apply: dm List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Wed, 12 Jul 2023 16:30:48 +0000 Jacob Faibussowitsch <jacob.fai@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#e9f3684022cfe37b1a5f96dd9de9d0142c1ba8b1 Merge branch 'barry/2023-03-08/fix-man-pages-detected-by-lint' into 'main'Fix many manual pagesSee merge request petsc/petsc!6162 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Sat, 18 Mar 2023 03:53:19 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#20f4b53cbb5e9bd9ef12b76a8697d60d197cda17 Fix manual pages based on reports from Jacob's lint toolCommit-type: documentation List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Thu, 09 Mar 2023 01:51:37 +0000 Barry Smith <bsmith@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#5a7a9864f3e2c56c91df35f54563f00658726b85 Merge branch 'jeremy/less-strcpy-strcat' into 'main'Use Petsc[Strncpy,Strlcat,Memcpy] over Petsc[Strcpy,Strcat]Closes #1332See merge request petsc/petsc!6115 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Tue, 14 Mar 2023 14:34:00 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#c6a7a37075f8bf8d34d92c4910d42445b7a3482d Clean up PETSc str ops to use more secure implementations where possible. These include:- Use PetscStrncpy()/PetscStrlcat()/PetscMemcpy() over PetscStrcpy()/PetscStrcat()- Use PetscArraycpy() over PetscMemcpy() as appropriate for string buffer copying- Use built in string from name over hardcoding- Use sizeof over hardcoded length- Replace some Strlcat with Strncpy when offset is known List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Fri, 24 Feb 2023 16:48:31 +0000 Jeremy L Thompson <jeremy@jeremylt.org> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#31d78bcd2b98084dc1368b20eb1129c8b9fb39fe Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'Feature: Non-discardable PetscErrorCodeSee merge request petsc/petsc!5923 List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Thu, 02 Feb 2023 20:39:47 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/dmmbmg.cxx#3ba1676111f5c958fe6c2729b46ca4d523958bb3 Make PetscErrorCode a non-discardable enum List of files: /petsc/src/dm/impls/moab/dmmbmg.cxx Sat, 10 Dec 2022 18:29:11 +0000 Jacob Faibussowitsch <jacob.fai@gmail.com>