en Copyright 2025 Java http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#d0e6bf2ad94dcc89b258ce16c7987200a4714786 Merge branch 'jolivet/clang-format-19' into 'main'clang-format-19See merge request petsc/petsc!7644 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Wed, 25 Sep 2024 06:44:18 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#57508ece14a6b1339c0bbf016ecd72f673a062b0 Remove unneeded parentheses List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Tue, 17 Sep 2024 23:49:15 +0000 Pierre Jolivet <pierre@joliv.et> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#bff66efa9044f546ae447ed195723e21295eb6dd Merge branch 'ilya-fursov/ts-fixevent2' into 'main'TSEvent: refactor and fix bugs, add TSSetPostEventStep()See merge request petsc/petsc!6752 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Fri, 15 Dec 2023 16:29:03 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#ca4445c7a2f5ca546b532f08b853c371604af17c TSEvent: refactor and fix bugs, add TSSetPostEventStep() Refactor the core algorithm for resolution of events: TSEventHandler() and the helper functions, fixing the existing bugs. Change event indicator functions from PetscScalar to PetscReal. Change the API of TSSetEventHandler(): in the user `indicator()` callback, the 'fvalue' argument type changed from PetscScalar[] to PetscReal[]. Add TSSetPostEventStep(), deprecate TSSetPostEventIntervalStep(). Deprecate option -ts_event_post_eventinterval_step. Fix bugs in interaction of TSEvent with tspan. Add six new test examples. Below are the examples of bugs fixed by this patch. The source codes (ex3.c, ex3span.c, ex4.c, ex5.c) can be found in src/ts/event/tests. To run them with the older Petsc versions, one would need to comment out "#define NEW_VERSION". Behaviour for three library versions is reported below: * ORIG: current Petsc version, before the proposed patch. * 6688: independently of the proposed patch, Merge Request 6688 was developed, which fixed some bugs with zero-crossing directions. * NEW : the proposed patch. ./ex3 -ts_monitor -ts_event_monitor -ts_view -ts_type beuler \ -ts_adapt_type basic -flg -V 1e9 -ts_adapt_dt_min 1e-6 -change5 1 -dir 1 * ORIG: fails to resolve 5 out of 6 events, and resolves 23 incorrect events. * 6688: fails to exit the TSEvent iteration via the step size (bracket size) criterion. * NEW : ok, resolves all 6 events. ./ex4 -ts_adapt_type basic -ts_type rk -ts_dt 0.25 -ts_event_tol 1e-8 \ -dir 0 -ts_adapt_dt_min 1e-10 -ts_view -ts_monitor -ts_event_monitor * ORIG: only reaches t = 0.0300236 after 10000 TS steps. * 6688: only reaches t = 0.0300236 after 10000 TS steps. * NEW : ok, reaches the final time t = 4.0 after 96 TS steps, resolving all 16 events. ./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \ -ts_view -ts_dt 0.25 -flg -dir 0 * ORIG: only reaches t = 4.0 after 10000 TS steps, erroneously reports event at t = 4.0 around 5000 times. * 6688: only reaches t = 4.0 after 10000 TS steps. * NEW : ok, reaches the final time t = 10.0 after 99 TS steps, resolving all 34 events. ./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \ -ts_view -ts_dt 0.25 -flg -dir 1 * ORIG: fails, starts taking negative time steps, no events are correctly resolved. * 6688: ok, but slower: 90 TS steps to resolve all 17 events. * NEW : ok, and faster: 48 TS steps to resolve all 17 events. ./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \ -ts_view -ts_dt 0.25 -flg -dir -1 * ORIG: fails, starts taking 'nan' time steps. * 6688: mostly fails, only reaches t = 4.99993 after 10000 TS steps. * NEW : ok, reaches the final time t = 10.0 after 74 TS steps, resolving all 17 events. The same run in parallel: mpirun -n 2 ./ex5 -ts_monitor -ts_event_monitor -ts_type rk \ -ts_adapt_type basic -ts_view -ts_dt 0.25 -flg -dir -1 * ORIG: fails, starts taking negative time steps, exits with runtime error. * 6688: mostly fails, only reaches t = 3, besides, the parallel run is not consistent with the serial run (see above). * NEW : ok, reaches the final time t = 10.0 after 74 TS steps, resolving all 17 events. ./ex3span -ts_monitor -ts_event_monitor * ORIG: (confused by events) misses tspan points: 4.02, 4.21, 4.98, 5.01, 5.21, 5.98, 6, 6.01, 6.02, 6.21, 6.99, 7.21, 8.01, 8.21, 9.01. * 6688: (confused by events) misses tspan points: 4.02, 4.21, 4.98, 5.01, 5.21, 5.98, 6, 6.01, 6.02, 6.21, 6.99, 7.21, 8.01, 8.21, 9.01. * NEW : ok. ./ex3span -ts_monitor -ts_event_monitor -ts_event_post_event_step 0.5 * ORIG: misses the majority of tspan points (except 0.01 and 0.21), and also resolves the last event location at wrong time t = 9.21. * 6688: misses the majority of tspan points (except 0.01 and 0.21), and also resolves the last event location at wrong time t = 9.21. * NEW : ok. List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Thu, 20 Jul 2023 19:18:16 +0000 Ilya Fursov <ilya.foursov.7bd@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#5a7a9864f3e2c56c91df35f54563f00658726b85 Merge branch 'jeremy/less-strcpy-strcat' into 'main'Use Petsc[Strncpy,Strlcat,Memcpy] over Petsc[Strcpy,Strcat]Closes #1332See merge request petsc/petsc!6115 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Tue, 14 Mar 2023 14:34:00 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#c6a7a37075f8bf8d34d92c4910d42445b7a3482d Clean up PETSc str ops to use more secure implementations where possible. These include:- Use PetscStrncpy()/PetscStrlcat()/PetscMemcpy() over PetscStrcpy()/PetscStrcat()- Use PetscArraycpy() over PetscMemcpy() as appropriate for string buffer copying- Use built in string from name over hardcoding- Use sizeof over hardcoded length- Replace some Strlcat with Strncpy when offset is known List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Fri, 24 Feb 2023 16:48:31 +0000 Jeremy L Thompson <jeremy@jeremylt.org> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#31d78bcd2b98084dc1368b20eb1129c8b9fb39fe Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'Feature: Non-discardable PetscErrorCodeSee merge request petsc/petsc!5923 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Thu, 02 Feb 2023 20:39:47 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#3ba1676111f5c958fe6c2729b46ca4d523958bb3 Make PetscErrorCode a non-discardable enum List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Sat, 10 Dec 2022 18:29:11 +0000 Jacob Faibussowitsch <jacob.fai@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#061e922f3926be00487707c73b78dd3d40309129 Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'Feature: Bicycle Storage Facility 2See merge request petsc/petsc!5661 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Thu, 22 Sep 2022 02:09:24 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#d71ae5a4db6382e7f06317b8d368875286fe9008 source code format changes due to .clang-format changes List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Wed, 21 Sep 2022 21:15:28 +0000 Jacob Faibussowitsch <jacob.fai@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#58d68138c660dfb4e9f5b03334792cd4f2ffd7cc Merge branch 'barry/2022-08-21/clang-format-source' into 'main'format repository with clang-formatSee merge request petsc/petsc!5541 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Tue, 23 Aug 2022 05:26:23 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#9371c9d470a9602b6d10a8bf50c9b2280a79e45a clang-format: convert PETSc sources to comply with clang-format List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Mon, 22 Aug 2022 15:20:12 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#5cab5458055e6544d97095d04e76587ba3d30732 Merge branch 'barry/2022-07-23/add-petscbeginuser' into 'main'Add PetscFunctionBeginUser to all PETSc C/C++ examplesSee merge request petsc/petsc!5470 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Tue, 26 Jul 2022 19:33:37 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#327415f76d85372a4417cf1aaa14db707d4d6c04 Add PetscFunctionBeginUser to all PETSc C/C++ examplesNow the stack frames will contain the main program and the correct line numbers in themgit ls-files | egrep "(tutorials|tests)" | xargs sed -i "s?\(PetscCall(PetscInitialize(&argc\)?PetscFunctionBeginUser;\n \1?g"Commit-type: error-checking, testing-fix/spend 15m List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Sat, 23 Jul 2022 12:34:06 +0000 Barry Smith <bsmith@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#1335eab4ef08e2f8ec60986b967bf17f907e9a7c Merge branch 'jacobf/2022-04-05/petscattrformat-all-the-rest' into 'main'Enable PETSC_ATTRIBUTE_FORMAT()See merge request petsc/petsc!5085 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Fri, 15 Apr 2022 02:16:00 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#63a3b9bc7a1f24f247904ccba9383635fe6abade Enable PETSC_ATTRIBUTE_FORMAT() List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Wed, 06 Apr 2022 01:30:47 +0000 Jacob Faibussowitsch <jacob.fai@gmail.com> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#527ad95778d6f233da38ea01739216ed7072f4ae Merge branch 'barry/2022-04-01/fix-petsc-options-begin-end/release' into 'main'Remove bogus error returns from Begin/End() macrosSee merge request petsc/petsc!5069 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Mon, 11 Apr 2022 00:43:55 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#d0609ced746bc51b019815ca91d747429db24893 Cleanup of introduction of PetscCall()* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()* fix many lingering ierr = XXX that arose from multiline function calls* sync slepc/hpddm - to use snapshots with the same changesCommit-type: error-checking, style-fix/spend 8h List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Sat, 02 Apr 2022 13:49:51 +0000 Barry Smith <bsmith@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#f882803cc229b3a4b5704278364815583f823089 Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'Variadic CHKERRQ()See merge request petsc/petsc!4889 List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Sat, 26 Mar 2022 01:48:19 +0000 Satish Balay <balay@mcs.anl.gov> http://opengrok.kc2vjw.com:8080/history/petsc/src/dm/impls/moab/tests/ex2.cxx#9566063d113dddea24716c546802770db7481bc0 The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX() -> PetscCallThrow()- CHKERRCXX() -> PetscCallCXX()- CHKERRCUDA() -> PetscCallCUDA()- CHKERRCUBLAS() -> PetscCallCUBLAS()- CHKERRCUSPARSE() -> PetscCallCUSPARSE()- CHKERRCUSOLVER() -> PetscCallCUSOLVER()- CHKERRCUFFT() -> PetscCallCUFFT()- CHKERRCURAND() -> PetscCallCURAND()- CHKERRHIP() -> PetscCallHIP()- CHKERRHIPBLAS() -> PetscCallHIPBLAS()- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()- CHKERRQ_CEED() -> PetscCallCEED()- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()- CHKERRMKL() -> PetscCallMKL()- CHKERRMMG() -> PetscCallMMG()- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()- CHKERRCGNS() -> PetscCallCGNS()- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()- CHKERRSTR() -> PetscCallSTR()- CHKERRTC() -> PetscCallTC() List of files: /petsc/src/dm/impls/moab/tests/ex2.cxx Fri, 25 Mar 2022 01:50:18 +0000 Jacob Faibussowitsch <jacob.fai@gmail.com>