Searched hist:f490541ab37a4342bf3d5955e59cd802d1fbbf64 (Results 1 – 1 of 1) sorted by relevance
| /petsc/src/dm/interface/ |
| H A D | dm.c | f490541ab37a4342bf3d5955e59cd802d1fbbf64 Fri Feb 14 19:17:28 UTC 2014 Peter Brune <brune@mcs.anl.gov> DM: Fix for recursive DMDestroy() causing valgrind issues
runex26_2 in src/ts/examples/tutorials caused the following valgrind output:
> ==21447== Invalid read of size 8
> ==21447== at 0x599093E: DMDestroy (dm.c:401)
> ==21447== by 0x4F3F83F: PetscObjectDereference (inherit.c:612)
> ==21447== by 0x4F30C6A: PetscObjectListDestroy (olist.c:160)
> ==21447== by 0x4F3AA1F: PetscHeaderDestroy_Private (inherit.c:117)
> ==21447== by 0x5184D16: VecDestroy (vector.c:499)
> ==21447== by 0x5990EA5: DMDestroy (dm.c:425)
> ==21447== by 0x5B2833D: PCDestroy (precon.c:122)
> ==21447== by 0x5C0D6EF: KSPDestroy (itfunc.c:772)
> ==21447== by 0x5C93387: SNESDestroy (snes.c:2790)
> ==21447== by 0x5D35130: SNESReset_NASM (nasm.c:46)
> ==21447== by 0x5C92705: SNESReset (snes.c:2732)
> ==21447== by 0x5C92689: SNESReset (snes.c:2728)
> ==21447== by 0x5DA00E8: TSReset (ts.c:1872)
> ==21447== by 0x5DA09EB: TSDestroy (ts.c:1912)
> ==21447== by 0x402671: main (ex26.c:172)
> ==21447== Address 0x9b39778 is 24 bytes inside a block of size 32 free'd
> ==21447== at 0x4C2A82E: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==21447== by 0x4F85AEB: PetscFreeAlign (mal.c:70)
> ==21447== by 0x5990F29: DMDestroy (dm.c:426)
> ==21447== by 0x5B2833D: PCDestroy (precon.c:122)
> ==21447== by 0x5C0D6EF: KSPDestroy (itfunc.c:772)
> ==21447== by 0x5C93387: SNESDestroy (snes.c:2790)
> ==21447== by 0x5D35130: SNESReset_NASM (nasm.c:46)
> ==21447== by 0x5C92705: SNESReset (snes.c:2732)
> ==21447== by 0x5C92689: SNESReset (snes.c:2728)
> ==21447== by 0x5DA00E8: TSReset (ts.c:1872)
> ==21447== by 0x5DA09EB: TSDestroy (ts.c:1912)
> ==21447== by 0x402671: main (ex26.c:172)
This was caused by recursive calls to DMDestroy(). When freeing the named local vector list, the linked list is freed
before being set to NULL. The recursive call of DMDestroy() by VecDestroy() then tries to access the value in the
structure. The fix to this is to zero out the DM member before the recursive call instead of after it.
Reported-by: Barry Smith <bsmith@mcs.anl.gov>
|