Add PETSC_PRAGMA_DIAGNOSTIC_IGNORED_BEGIN, and PETSC_PRAGMA_DIAGNOSTIC_IGNORED_END to silence clang or GCC warnings selectively

Merge branch 'jolivet/clang-format-fix-petscpragmasimd' into 'main'

clang-format fix indentation of PetscPragmaSIMD

See merge request petsc/petsc!6146

clang-format fix indentation of PetscPragmaSIMD

Merge branch 'jacobf/2023-03-01/clang-format-fix-petscpragmaomp' into 'main'

clang-format fix indentation of PetscPragmaOMP

See merge request petsc/petsc!6127

clang-format fix indentation of PetscPragmaOMP

Merge remote-tracking branch 'origin/release'

Merge branch 'jacobf/2022-10-03/clang-format-update-stmnt-macros/release' into 'release'

Update .clang-format StatementMacros

See merge request petsc/petsc!5705

make clang-format treat the decltype auto macros as statements so they are indented correctly

Merge branch 'jacobf/2022-10-01/fixup-aijhipsparse-deprecated-warnings/release' into 'release'

Fixup PetscLogObjectParent() in MATMPIAIJHIPSPARSE

See merge request petsc/petsc!5700

clang-format fixups

Merge branch 'jacobf/2022-09-29/clang-format-khash_t-typenamemacro' into 'main'

Tell clang-format to treat khash_t as a typename

See merge request petsc/petsc!5697

Tell clang-format to treat khash_t as a typename

Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

.clang-format changes:

- Indent preprocessor directives
- Don't sort using declarations
- Don't allow short case labels
- Make (function) braces break again
- Don't align assignments across comments

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

.clang-format: use AfterExternBlock: false

Merge branch 'barry/2022-07-20/add-clang-format' into 'main'

Use clang-format to format PETSc source code

See merge request petsc/petsc!5455

No longer put new line before { in function, class, namespace

This is to have consistency with struct, enum, and reduce unneeded lines

One of my very first decisions in PETSc 2.0 was to have the {

No longer put new line before { in function, class, namespace

This is to have consistency with struct, enum, and reduce unneeded lines

One of my very first decisions in PETSc 2.0 was to have the { on a different line from the function name.
I thought the extra line made it quicker for me to see the code declarations
I think it is fine to change that decision

Commit-type: formatting

show more ...

Adjust clang-formatting to align operands

f[j][i].omega = xdot[j][i].omega + uxx + uyy //
+ (vxp * (u - x[j][i - 1].omega) + vxm * (x[j][i + 1].

Adjust clang-formatting to align operands

f[j][i].omega = xdot[j][i].omega + uxx + uyy //
+ (vxp * (u - x[j][i - 1].omega) + vxm * (x[j][i + 1].omega - u)) * hy //
+ (vyp * (u - x[j - 1][i].omega) + vym * (x[j + 1][i].omega - u)) * hx //
- .5 * grashof * (x[j][i + 1].temp - x[j][i - 1].temp) * hy;

instead of

f[j][i].omega = xdot[j][i].omega + uxx + uyy //
+ (vxp * (u - x[j][i - 1].omega) + vxm * (x[j][i + 1].omega - u)) * hy //
+ (vyp * (u - x[j - 1][i].omega) + vym * (x[j + 1][i].omega - u)) * hx //
- .5 * grashof * (x[j][i + 1].temp - x[j][i - 1].temp) * hy;

Commit-type: style
Reported-by: Jed Brown

show more ...

Put { on same line as struct

Causes

struct XXXX {

instead of

struct XXX
{

Commit-type: formatting
Thanks-to: Jed Brown

Additional changes to .clang_format to more closely match PETSc style

Switch AlignTrailingComments to true so that comments, for example, for each record in a struct are aligned

Requested by Matt Knepley

I think it would be nicer if could align ones across missing co

Switch AlignTrailingComments to true so that comments, for example, for each record in a struct are aligned

Requested by Matt Knepley

I think it would be nicer if could align ones across missing comments like

typedef struct
{
int index; /* Type of section */
unsigned int zoneID;
unsigned int first;
unsigned int last;
int type;
int nd; /* Either ND or element-type */
void *data;
} FluentSection;

but as Jed says we cannot be too picky

Commit-type: style-fix
/spend 2m
Reported-by: Mathew Knepley
Thanks-to: Jose E. Roman

show more ...

Update to Jacob's latest clang-format file that more closely matches PETSc style

Commit-type: housekeeping
/spend 1m
Thanks-to: Jacob Faibussowitsch

Merge branch 'jacobf/2022-03-26/variadic-chkerrq-stragglers' into 'main'

Clean Up Variadic-CHKERRQ Stragglers

See merge request petsc/petsc!5033

fixup some remaining stragglers from !4889