Merge remote-tracking branch 'origin/stefano_zampini/cherrypick-commits-for-maint-from-continuousadjoint' into maint

PetscFunctionListGet: revert const change

Fixes for use of PetscMallocN() with const type input

Microsoft compilers warn about incompatiblity between pointers passed to new PetscMallocA() function

Commit-type: portability-fix, testing-fix

Fixes for use of PetscMallocN() with const type input

Microsoft compilers warn about incompatiblity between pointers passed to new PetscMallocA() function

Commit-type: portability-fix, testing-fix
Reported-by: nightly tests

show more ...

PetscSys: added PetscSortRealWithArrayInt and PetscFindReal routines
testing code is also provided

PetscContainer: add Default destroy routine for contexts obtained with PetscMalloc

F90Array routines now take a MPI_Datatype argument instead of PetscDataType

This is part of the refactorization to limit and maybe eventually eliminate PetscDataType since
it duplicates MPI_Datatype

F90Array routines now take a MPI_Datatype argument instead of PetscDataType

This is part of the refactorization to limit and maybe eventually eliminate PetscDataType since
it duplicates MPI_Datatype functionality (poorly).

Commit-type: style-fix
Thanks-to: Jed Brown <jed@jedbrown.org>

show more ...

Remove use of PetscDataType from VTK code and other trivial location.

Reason: PetscDataType is duplicative to MPI_Datatype therefor we hope to limit its
use and perhaps eventually completely remove

Remove use of PetscDataType from VTK code and other trivial location.

Reason: PetscDataType is duplicative to MPI_Datatype therefor we hope to limit its
use and perhaps eventually completely remove it.

Commit-type: style-fix
Thanks-to: Jed Brown <jed@jedbrown.org>
Development Tools: Vim, Emacs, Eclipse

show more ...

PetscMallocA: update macro expansions to cast numbers to (size_t)

Rationale:

1. Silence -Wconversion warnings.
2. Your code may be broken because of integer promotion rules.

As an example of (

PetscMallocA: update macro expansions to cast numbers to (size_t)

Rationale:

1. Silence -Wconversion warnings.
2. Your code may be broken because of integer promotion rules.

As an example of (2), imagine that you are running on a 32bit arch with
size_t 32 bits and long long 64 bits. Then

unsigned long long m1 = 10;
unsigned long long m2 = 10;
double *p,*q;
PetscMalloc1(m1,&p,m2,&q)

Then the macro will compute the product m2*sizeof(double), the result is
then unsigned long long, but PetscMallocA is expecting size_t (because
of va_arg(Argp,size_t)).

Thanks-to: Lisandro Dalcin <dalcinl@gmail.com>

show more ...

Merged in dalcinl/fix-issortremovedups (pull request #747)

Fixes for `ISSortRemoveDups()`

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

Fixes for `ISSortRemoveDups()`

* Add `PetscSortedRemoveDupsInt()` to remove duplicates of a sorted array.
* Calling `ISSort()` and next `ISSortRemoveDups()` now filters duplicates.
* Fix `ISGENERAL`

Fixes for `ISSortRemoveDups()`

* Add `PetscSortedRemoveDupsInt()` to remove duplicates of a sorted array.
* Calling `ISSort()` and next `ISSortRemoveDups()` now filters duplicates.
* Fix `ISGENERAL` to setup the `PetscLayout` after filtering duplicates.

show more ...

Merge remote-tracking branch 'origin/tisaac/random123'

PetscMallocA: implement the Malloc[1-7] suite using variadic function

The macros had become increasingly complicated and were opaque to debug.
It also prevented run-time choice of coalesced malloc,

PetscMallocA: implement the Malloc[1-7] suite using variadic function

The macros had become increasingly complicated and were opaque to debug.
It also prevented run-time choice of coalesced malloc, which is now
available via -malloc_coalesce which is useful to debug memory leaks due
to mismatched PetscMalloc3/PetscFree2 and the like. This implementation
dispatches to a single variadic function that handles allocation for
both PetscMalloc[1-7] and PetscCalloc[1-7], as well as a matching
case for freeing memory.

show more ...

PetscRandom: added wrapper for Random123

Merge branch 'jed/sf-shared-uni' [PR #736]

* jed/sf-shared-uni:
MPIUNI Fortran: fix predefined constants
MPIUNI: define MPI_OP_NULL so that example can compile
DMPlex tests: update output for

Merge branch 'jed/sf-shared-uni' [PR #736]

* jed/sf-shared-uni:
MPIUNI Fortran: fix predefined constants
MPIUNI: define MPI_OP_NULL so that example can compile
DMPlex tests: update output for SF type being set up before viewing
Remove !mpiuni from tests
SFBasic: circumvent send-to-self by marking self as a distinguished group
PetscSFView: dynamically sort by ranks for ASCII_INFO_DETAIL output
SF: add ability for implementations to identify a distinguished group of ranks
PetscSF: add distribution/transposition test
SFBasic: pack into non-contiguous (by rank) root/leaf buffers instead of contiguous buffer
SF: PetscSFGetRanks requires a setup SF, PetscSFView calls setup
MPIUNI: change datatype packing scheme; implement MPI_Type_get_contents
MPIUNI: fix use of MPIUni_Abort, which returns
Add PetscFindMPIInt for searching within sorted array of PetscMPIInt
SF: delay construction of rank mapping until SF type is set
PetscSFReset: call impl reset before corrupting interface data
SFSetGraph: remove support for nroots=PETSC_DETERMINE

show more ...

Add PetscFindMPIInt for searching within sorted array of PetscMPIInt

Merge remote-tracking branch 'origin/stefano_zampini/feature-glvis-viewer-fixdmdependency2'

Merge remote-tracking branch 'origin/barry/feature-aij-subtypes'

Add subtype concept to SeqAIJ matrices

Introduced -mat_seqaij_type <seqaijperm, ...> MatSeqAIJSetType() to allow running code written for AIJ to work
with any subtype. See MatSeqAIJRegister() and Ma

Add subtype concept to SeqAIJ matrices

Introduced -mat_seqaij_type <seqaijperm, ...> MatSeqAIJSetType() to allow running code written for AIJ to work
with any subtype. See MatSeqAIJRegister() and MatSeqAIJRegisterAll() for registering new subtypes

Use

export PETSC_OPTIONS="-mat_seqaij_type seqaijperm -malloc_test"
make alltests

to run the entire test suite using an alternative subclass, in this case seqaijperm. This will produce output regarding the different name for
the matrix class but otherwise should produce no errors.

This was implemented to 1) allow easy testing of an MKL subtype and 2) to allow users to easily use the MKL subtype
without changing their code.

Also fixes several bugs in seqaijperm, if it isn't tested its broken.

Commit-type: testing-fix,style-fix, feature
Funded-by: ECP
Project: MKL
Time: 32 hours
Reported-by: Irina Sokolova <irina.sokolova@intel.com>

show more ...

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page information about convergence testing when using KSPRICHARDSON
SNES ex5: Restore old output since this breaks an example I have
Noted that some Cray XC systems will use 'aprun' instead of 'srun'. Thanks to Herr Doktor Hong Zhang for this suggestion.
Added example configure script for Cray XC40 with KNL processors (e.g., NERSC Cori).
Fix possible sprintf -Wformat-overflow
PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7
SNES ex5: make boundary condition handling consistent for symmetry
SNES ex5: use L2 norm and *_monitor_short for output
SNES ex5: the L^2 norm scales with the l^2 norm over sqrt(N)
SNES ex5: refactor MMS capability to avoid extreme code duplication
Documentation fix: typo in PetscLogStageRegister manual page.
nodes -> vertices
rename DMNetworkGetComponentTypeOffset -> DMNetworkGetComponentKeyOffset
rename DMNetworkGetConnectedNodes() -> DMNetworkGetConnectedVertices()
Jacobians for adjoints for explicit methods and constant Jacobians never got initialized
fix complex build error
fix build failure with fortran interface
fix compile error with cdc753b64c658d532d7813e942002e67025667a6
...

Conflicts:
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/ex69.c

show more ...

Merge branch 'jed/Wint-in-bool-context'

* jed/Wint-in-bool-context:
Fix possible sprintf -Wformat-overflow
PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7

Merge branch 'jed/mpi-semver'

* jed/mpi-semver:
Allow compilation with compatible versions of OpenMPI and MPICH

PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7

GCC 7 complains about macro constructs that produce things like

!(m*n)

which it would prefer be written as

m && n

But the * is inside a ma

PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7

GCC 7 complains about macro constructs that produce things like

!(m*n)

which it would prefer be written as

m && n

But the * is inside a macro to compute the size of the allocated array
so instead we use

0==(m*n).

show more ...

PETSCSYS: protect PetscOpenSocket by ifdefs to avoid missing symbols when linking

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output l

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output log for snes_tutorials-ex62_fetidp_3d_tet that got corrupted in 188e10d6f1cffa866ec0197053a0e55fa4e7da41
fix opensolaris build error with --with-log=0 Undefined first referenced symbol in file PetscLogEventGetPerfInfo arch-opensolaris-misc/tests/src/dm/impls/plex/examples/tests/ex9.o
fix warnings on windows C:\cygwin64\home\petsc\PETSC~1.CLO\src\tao\examples\TUTORI~1\ex1.c(217): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)'
disable example with absoft (due to fixed/free form limit)
c89 fixes
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
Plex ex19: Remove unneeded code
Plex: Fix projection when we have a dmAux which is a domain boundary - If we are projecting on a lower dimension thing (effectiveHeight > 0), then we need to get the space and dual space on this subcell - The tabulation needs to be in the right dimension for both dm and dmAux
PetscFE: Added height subspaces to PetscFE - Added PetscFEGetHeightSubspace() - Added array in struct
PetscDualSpace: Small cleanup of parameter name
PetscSpace: Added height subspaces for PetscSpace - Added PetscSapceGetHeightSubspace() and member function - Added subspaces array
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix some minor style issues
Extend AMS/ADS to support high-order element.
...

show more ...

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...