Fix missing ierr =, removed incorrect CHKERRQ()

Commit-type: error-checking, style-fix
\spend 45m

Merge branch 'tisaac/feature-pminus-eval' into 'main'

Add PetscDTPTrimmedEvalJet(): evaluates trimmed polynomials

See merge request petsc/petsc!4437

Add PetscDTPTrimmedEvalJet(): evaluates P trimmed polynomials

This follows the construction in Arnold, Falk and Winther section 4.4

I do not know yet if this basis is stable for evaluation

Start t

Add PetscDTPTrimmedEvalJet(): evaluates P trimmed polynomials

This follows the construction in Arnold, Falk and Winther section 4.4

I do not know yet if this basis is stable for evaluation

Start test of PetscDTPTrimmedEvalJet()

Document and cite the implementation of P trimmed evaluation

Limit P trimmed test output to condition numbers

Add negative form degrees to PetscDTPTrimmedEvalJet()

Add alternate implementation of trimmed polynomials

Remove the reference implementation in favor of a simpler, better conditioned alternative

show more ...

Merge remote-tracking branch 'origin/jose/fix-manpages'

Fix manpages to avoid errors reported by doctext

See merge request petsc/petsc!4309

Fix manpages: Argument --> Parameter (required to enable sowing checks)

Fix manpages: Input/Output Parameter --> Parameters

Merge branch 'stefanozampini/update-checkbadsource' into 'main'

Update badsource rules

See merge request petsc/petsc!4064

Update badsource rules

- Zero or more spaces are not allowed for more returning types
- zero spaces not allowed for for|if|while

Merge branch 'barry/2021-05-16/fix-double-lines' into 'main'

Fix typos in source

See merge request petsc/petsc!3984

Remove all double blank lines from source

Commit-type: petsc-style
/2h

Merge branch 'jacobf/2021-03-26/clang-static-linter' into 'main'

Feature: libClang PETSc Macro Static Analyzer

See merge request petsc/petsc!3773

Linter using libClang that checks PetscValidHeaderSpecifcType, PetscValidHeaderSpecific, PetscValidHeader, PetscValid[XXX]Pointer, PetscValidType, PetscCheckSameComm, PetscValidLogicalCollectiveXXX f

Linter using libClang that checks PetscValidHeaderSpecifcType, PetscValidHeaderSpecific, PetscValidHeader, PetscValid[XXX]Pointer, PetscValidType, PetscCheckSameComm, PetscValidLogicalCollectiveXXX for validity. Automatically generates diff files for problems with a known solution.

show more ...

Merge branch 'dalcinl/fix-null' into 'master'

Fix 0 -> NULL for pointers

See merge request petsc/petsc!3086

DM: Replace 0 -> NULL for pointers

Merge branch 'tisaac/fix-pkd-valgrind' into 'master'

Fix bad access in PetscDTPKDEvalJet()

See merge request petsc/petsc!2774

Fix bad access in PetscDTPKDEvalJet()

It has been passing tests because as long as the misaccessed bits are a PetscReal,
the added terms were zero. This slipped through the CI tests because VALGRIN

Fix bad access in PetscDTPKDEvalJet()

It has been passing tests because as long as the misaccessed bits are a PetscReal,
the added terms were zero. This slipped through the CI tests because VALGRIND=1
isn't running valgrind on all tests in a test set

show more ...

Merge remote-tracking branch 'origin/maint'

Merge branch 'balay/gfortran-10-fixes/maint' into 'maint'

Balay/gfortran 10 fixes/maint

See merge request petsc/petsc!2760

gcc/gfortran-10: fix errors/warnings

The primary issue now is - gfortran defaults to flagging argument mismatch as error.
We can work-around this with '-fallow-argument-mismatch' option - however th

gcc/gfortran-10: fix errors/warnings

The primary issue now is - gfortran defaults to flagging argument mismatch as error.
We can work-around this with '-fallow-argument-mismatch' option - however this switches from errors to warnings.

And the only way to disable this warning is '-w' i.e disable all warnings.

Fixes involve adding interface definitions for all prototypes that get used. [and work-around mpich by using a(1) for scalars]

show more ...

Merge branch 'jed/defined-nocpp' into 'master'

PetscDefined: test whether a configuration macro is defined without #ifdef

See merge request petsc/petsc!157

PetscDefined: remove many uses of #ifdef PETSC_USE_DEBUG

Merge branch 'tisaac/feature-dubiner-basis' into 'master'

PetscDT: PKD (Dubiner) basis

See merge request petsc/petsc!2691

Cite Rob Kirby for the PKD implementation

Add PetscDTPDKEvalJet(), PetscDTJacobiEvalJet(), PetscDTIndexToGradedOrder(), and PetscDTGradedOrderToIndex()

The Proriol-Koordwinder-Dubiner basis (PKD) is orthonormal on the
reference simplex, so

Add PetscDTPDKEvalJet(), PetscDTJacobiEvalJet(), PetscDTIndexToGradedOrder(), and PetscDTGradedOrderToIndex()

The Proriol-Koordwinder-Dubiner basis (PKD) is orthonormal on the
reference simplex, so we should make it available as a stable basis of
evaluation.

The recursive definition allows for a straightforward and stable
calculation of all derivatives, not just first and second.

`src/dm/dt/tests/ex9.c` tests that the basis is orthonormal
and compares the derivatives against the derivatives computed by
tensor-product Legendre polynomials.

I thought about how to make an interface that would handle that,
and I decided returning the jet in the same kind of graded
representation that makes sense for multivariate polynomial spaces was a
good choice.

To facilitate this, I also added indexing functions for figuring out
where a tuple (either of exponents in a monomial or orders in a partial
derivatives) is in this ordering.

Along the way I made PetscDTStroudConicalQuadrature() handle arbitrary
dimensions instead of just 1--3.

We have a variety of dimensional orderings in PetscDT, related to how we
order points of evaluation, components of the jet, and basis functions.

I thought that:
- downstream users concerned with performance might prefer points of
evaluation as the fastest varying index to facilitate vectorization
of numerical integration, and
- having basis functions as one of the outer dimensions (first or last)
would simplify computing the matrix-matrix product of
a [basis function x evaluation point] matrix with a Vandermonde
inverse matrix

So I ordered the output dimensions of PetscDTPKDEvalJet() as
[basis function, jet component (derivative), evaluation point]. I am
seeking comment as to whether this is good, and whether it might be a
good convention to adopt elsewhere in PetscDT.

undo extern

Fix complex type issue in dm/dt/tests/ex9.c

squashme: fix scaling in PetscDTStroudConicalQuadrature()

squashme: loosen tolerance for single precision

squashme: cast to double before printing

squashme: remove unused static functions

show more ...

Merge branch 'tisaac/feature-dual-space-rework' into 'master'

Rework PetscDualSpace

See merge request petsc/petsc!2399