Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge branch 'dalcinl/fix-null' into 'master'

Fix 0 -> NULL for pointers

See merge request petsc/petsc!3086

DM: Replace 0 -> NULL for pointers

Merge branch 'hzhang/dmnetwork-vltogordering' [PR #1882]

* hzhang/dmnetwork-vltogordering:
add Set/GetVertexLocalToGlobalOrdering(), used by constrained optimization application
bugfix for IPMUpdate

Merge branch 'hzhang/dmnetwork-vltogordering' [PR #1882]

* hzhang/dmnetwork-vltogordering:
add Set/GetVertexLocalToGlobalOrdering(), used by constrained optimization application
bugfix for IPMUpdateAi() in Tao. Create Ai using local column size
bugfix for DMInitialize_Network(). contibuted by Shri

show more ...

fix complex build error

bugfix for DMInitialize_Network().
contibuted by Shri

Merged in dalcinl/dm-api (pull request #1850)

DM interface

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

DM: Deprecate DMCreateAggregates()

* This interface is untested and may be redundant
* DMDA is the only provider, keep it as DMDACreateAggregates()

DM: Simplify implementation of DMHasCreateInjection()

* Add log event for DMCreateInjection()
* Get rid of DMHasCreateInjection_Default()
* Rename dm->ops->getinjection to dm->ops->createinjection
*

DM: Simplify implementation of DMHasCreateInjection()

* Add log event for DMCreateInjection()
* Get rid of DMHasCreateInjection_Default()
* Rename dm->ops->getinjection to dm->ops->createinjection
* Improve error checking here and there

show more ...

Merged in barry/update-collective-on (pull request #1744)

Update the use of Collective on in the manual pages to reflect the new style

Update the use of Collective on in the manual pages to reflect the new style

Commit-type: style-fix, documentation
Thanks-to: Patrick Sanan <patrick.sanan@gmail.com>

Merged in psanan/man-pages-remove-keywords (pull request #1717)

Man pages: Remove .keywords fields

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be unif

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be uniformly used or maintained.

Thus, remove all .keywords: fields, and a following blank line, if present.

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find src/ -type f -exec gsed -i '/keywords:/d' {} +
find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find include/ -type f -exec gsed -i '/keywords:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merge branch 'hzhang/pdmnetwork-setup' [PR #1561]

* hzhang/pdmnetwork-setup:
Add parallel creation of DMNetwork

add parallel creation of DMNetwork in DMNetworkLayoutSetUp()
change API for DMNetworkSetSizes()
add DMNetworkGetSubnetworkCoupleInfo()
implement DMView_Network()
update DMNetworkGetGlobalXXXIndex()
u

add parallel creation of DMNetwork in DMNetworkLayoutSetUp()
change API for DMNetworkSetSizes()
add DMNetworkGetSubnetworkCoupleInfo()
implement DMView_Network()
update DMNetworkGetGlobalXXXIndex()
update/rewrite pipes1.c

show more ...

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to ne

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to new ANL style
Hash: Quick documentation fix
PetscBinaryViewerRead -> PetscViewerBinaryRead
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for DrMemory which may serve as an alternative to valgrind on Windows
Finish Gail's copyedits for developers manual.
openmpi: fix namespace conflict [with static build on ppc64le]
two pages of Gail's edits to developers guide
Another chapter of Gail's copyedits for the developers guide
Gail's copyedits on two more chapters of the developers guide
Fix more %d to %D in GAMG code. Fix code style in GAMG code
DMPlexVTK: vertices is int! need to use %d instead of %D
TS ex18: update outputs (reported by nightly tests)
Use %D in error messages for GAMG hash; fix style issues with GAMG hash
config: Update petsc4py git commit
Fix bad plain extern declaration.
Add Gail's copyedits for the initial portion of the developers guide
Add missing common block to subroutine
fix mpiuni tests with xl compilers
...

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing CHKERRQ()
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Add a test for ex21
Fix error in ex21
Add missing fortran interface that handles null objects
DMComposite: add missing guards
MatPreallocate: fix overpreallocation of local rows
style fixes
MatView_MPI_DA: do not print twice the class prefix
MatSetOperation: stash the original MatView_XXX in the viewnative function pointer
DMCreateInterpolation_DA gracefully error instead of catching FPE signals
MatIncreaseOverlap: preserve communicator of index sets
MatMPIAIJ: fix indentation and missing CHKERRQ
ISBuildTwoSided: remove tabs and fix style
Fix documentation
PetscViewerDraw: fix unininitialized warning from valgrind
MatConvert_SeqAIJ_SeqBAIJ: remove error for non square matrices and add MAT_REUSE_MATRIX case
Mat: MAT_INPLACE_MATRIX can be used for transposition with rectangular matrices
...

Conflicts:
src/dm/dt/interface/dtfe.c
src/dm/impls/plex/plex.c
src/dm/impls/plex/plexfem.c
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/makefile
src/snes/examples/tutorials/output/ex62_18.out
src/snes/examples/tutorials/output/ex62_19.out
src/snes/examples/tutorials/output/ex62_20.out
src/snes/examples/tutorials/output/ex62_20_parmetis.out
src/snes/examples/tutorials/output/ex62_21.out
src/snes/examples/tutorials/output/ex62_22.out
src/snes/examples/tutorials/output/ex62_23.out
src/snes/examples/tutorials/output/ex62_24.out
src/snes/examples/tutorials/output/ex62_25.out
src/snes/examples/tutorials/output/ex62_26.out
src/snes/examples/tutorials/output/ex62_27.out
src/snes/examples/tutorials/output/ex62_28.out
src/snes/examples/tutorials/output/ex62_29.out
src/snes/examples/tutorials/output/ex62_2d_p3_1.out
src/snes/examples/tutorials/output/ex62_30.out
src/snes/examples/tutorials/output/ex62_31.out
src/snes/examples/tutorials/output/ex62_32.out
src/snes/examples/tutorials/output/ex62_33.out
src/snes/examples/tutorials/output/ex62_34.out
src/snes/examples/tutorials/output/ex62_35.out
src/snes/examples/tutorials/output/ex62_36.out
src/snes/examples/tutorials/output/ex62_pc_simple.out
src/snes/examples/tutorials/output/ex62_pc_simplec.out
src/snes/examples/tutorials/output/ex62_quad_q2p1_full.out
src/snes/examples/tutorials/output/ex62_quad_q2q1_full.out
src/snes/utils/dmplexsnes.c

show more ...

Merge branch 'knepley/feature-error-logging' of bitbucket.org:petsc/petsc into knepley/feature-error-logging

Merge branch 'master' into knepley/feature-error-logging

* master: (324 commits)
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Revert "tgamma: icc on wi

Merge branch 'master' into knepley/feature-error-logging

* master: (324 commits)
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Revert "tgamma: icc on windows requires mathimf.h for tgamma."
setup routine no longer calls PetscCalloc5 if the arrays have already been allocated in a previous setup call
clarify SNESGetFunction()
Move MOAB docs to submansec so as not to clutter DM mansec
doc: remove matlab from doc generation dependency - i.e remove 'alldoc3' and use 'html' to generate corresponding '*.m.html' files.
Remove matlab pounders related cruft that is not required. Document the matlab code better and include an appropriate message in the help text.
Fixed typo.
Remove the inclusion of matlab in testing.
Finalizing comments and the work for the test problems.
Finished the testing and generation of plots. Some simple bug fixes addressed.
Set -Wl,-rpath for Mac OS Matlab mkl directory; don't pass -nojvm to matlab since it causes crashes on Barry's machine and is not needed
Added list of known problems with the code.
Added a comment on ignoring the return from Tao.
Finish with initial implementation of matlab interface to test TAO pounders.
Working through the matlab interface for pounders testing.
Fix typo in manual Reported-by: Jaroslaw Piwonski (CAU) <jpi@informatik.uni-kiel.de>
Fixed mkl_sparse_sypr() calls that were using an unsupported value in the matrix descriptor.
test harness: simplify code that checks for sequential-only tests
Fix the doc for call-backs drdyf drdpf
...

show more ...

Merge remote-tracking branch 'origin/barry/rm-unneeded-dmda-includes'

DMPlex and DMNetwork should not need to know about DMDA

Commit-type: style-fix

Development Tools: Vim, Emacs, Eclipse