Remove some PetscCheckFalse()

Merge branch 'barry/2022-03-30/strip-petscall-petsctrymethod' into 'main'

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

See merge request petsc/petsc!5051

Merge branch 'barry/2022-03-30/fix-mpiu_allreduce' into 'main'

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

See merge request petsc/petsc!5052

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

Both for debug and optimized builds

Also removes shadow declaration errors from use of mpiu_allreduce

Commit-type: error-

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

Both for debug and optimized builds

Also removes shadow declaration errors from use of mpiu_allreduce

Commit-type: error-checking
Reported-by: Lisandro Dalcin <dalcinl@gmail.com>

show more ...

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be addit

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be additions needed for running with a static error checker

Commit-type: error-checking
/spend 15m
Reported-by:
Lisandro Dalcin <dalcinl@gmail.com>

show more ...

Merge branch 'haplav/section-improve-maxdof' into 'main'

PetscSection: Lazy maxDof calculation.

See merge request petsc/petsc!5025

DM_Plex: Remove maxConeSize and maxSupportSize.

They are only proxies for max dof of respective sections.

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

fixes from recent linter change

pluck ~1000 low hanging PetscCheckFalse() -> PetscCheck() fruit

chkerr and friends wrapped

Merge branch 'haplav/sf-control-multileaves' into 'main'

SF: check for multileaves

See merge request petsc/petsc!4888

PetscSFSetGraph: sort ilocal, check for duplicates

Merge branch 'knepley/feature-plex-distribute-default' into 'main'

Plex: Change default to automatic distribution

See merge request petsc/petsc!4843

Plex: Change default to automatic distribution - Add DMPlexDistributeGet/SetDefault() to change this - Add DMPlexCopy_Internal() to keep state in Plex object consistent

Merge branch 'jacobf/2022-01-05/c99' into 'main'

Feature: C99 and C++11

See merge request petsc/petsc!4700

rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()

add PetscAssert() and PetscAssertFalse()

SETERRQ[1-9]+ begone

Merge remote-tracking branch 'origin/jose/fix-manpages'

Fix manpages to avoid errors reported by doctext

See merge request petsc/petsc!4309

Merge branch 'stefanozampini/nec' into 'main'

Initial support for NEC-SX Aurora Tsubasa

See merge request petsc/petsc!3987

Fix manpages: mismatching number of parameters

NECBUG: DMPlexIsDistributed: Fix for NEC compiler

Fix manpages: Input/Output Parameter --> Parameters