Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge branch 'dalcinl/binary-io' into 'master'

Binary IO Enhancements

See merge request petsc/petsc!2594

PetscBinaryWrite: Remove `istemp` boolean flag

Merged in barry/update-collective-on (pull request #1744)

Update the use of Collective on in the manual pages to reflect the new style

Update the use of Collective on in the manual pages to reflect the new style

Commit-type: style-fix, documentation
Thanks-to: Patrick Sanan <patrick.sanan@gmail.com>

Merged in barry/check-bad-urls (pull request #1685)

Barry/check bad urls

Approved-by: Patrick Sanan <patrick.sanan@gmail.com>
Approved-by: Junchao Zhang <junchao.zhang@gmail.com>

Fixed out-dated URLS using make checkbadURLS REPLACE=1

One manual fix of https://en.wikipedia.org/wiki/Buckingham_π_theorem since the automatic tool dropped the first _ for some reason
Manual fix of

Fixed out-dated URLS using make checkbadURLS REPLACE=1

One manual fix of https://en.wikipedia.org/wiki/Buckingham_π_theorem since the automatic tool dropped the first _ for some reason
Manual fix of //faq.html since the automatic tool incorrectly replaced /faq.html to //faq.html in some locations

These are largely updates of http to https but have a variety of other website location changes

Once this branch is in master individual developers can run make checkbadURLS and fix URLs related to their projects manually

Commit-type: bug-fix, documentation

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing CHKERRQ()
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Add a test for ex21
Fix error in ex21
Add missing fortran interface that handles null objects
DMComposite: add missing guards
MatPreallocate: fix overpreallocation of local rows
style fixes
MatView_MPI_DA: do not print twice the class prefix
MatSetOperation: stash the original MatView_XXX in the viewnative function pointer
DMCreateInterpolation_DA gracefully error instead of catching FPE signals
MatIncreaseOverlap: preserve communicator of index sets
MatMPIAIJ: fix indentation and missing CHKERRQ
ISBuildTwoSided: remove tabs and fix style
Fix documentation
PetscViewerDraw: fix unininitialized warning from valgrind
MatConvert_SeqAIJ_SeqBAIJ: remove error for non square matrices and add MAT_REUSE_MATRIX case
Mat: MAT_INPLACE_MATRIX can be used for transposition with rectangular matrices
...

Conflicts:
src/dm/dt/interface/dtfe.c
src/dm/impls/plex/plex.c
src/dm/impls/plex/plexfem.c
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/makefile
src/snes/examples/tutorials/output/ex62_18.out
src/snes/examples/tutorials/output/ex62_19.out
src/snes/examples/tutorials/output/ex62_20.out
src/snes/examples/tutorials/output/ex62_20_parmetis.out
src/snes/examples/tutorials/output/ex62_21.out
src/snes/examples/tutorials/output/ex62_22.out
src/snes/examples/tutorials/output/ex62_23.out
src/snes/examples/tutorials/output/ex62_24.out
src/snes/examples/tutorials/output/ex62_25.out
src/snes/examples/tutorials/output/ex62_26.out
src/snes/examples/tutorials/output/ex62_27.out
src/snes/examples/tutorials/output/ex62_28.out
src/snes/examples/tutorials/output/ex62_29.out
src/snes/examples/tutorials/output/ex62_2d_p3_1.out
src/snes/examples/tutorials/output/ex62_30.out
src/snes/examples/tutorials/output/ex62_31.out
src/snes/examples/tutorials/output/ex62_32.out
src/snes/examples/tutorials/output/ex62_33.out
src/snes/examples/tutorials/output/ex62_34.out
src/snes/examples/tutorials/output/ex62_35.out
src/snes/examples/tutorials/output/ex62_36.out
src/snes/examples/tutorials/output/ex62_pc_simple.out
src/snes/examples/tutorials/output/ex62_pc_simplec.out
src/snes/examples/tutorials/output/ex62_quad_q2p1_full.out
src/snes/examples/tutorials/output/ex62_quad_q2q1_full.out
src/snes/utils/dmplexsnes.c

show more ...

Merge branch 'master' into knepley/feature-error-logging

* master: (221 commits)
dashboard: count and list example compile failures like:
fix fix-pr879-jczhang-optimize-vecscatter-multi-copy
a

Merge branch 'master' into knepley/feature-error-logging

* master: (221 commits)
dashboard: count and list example compile failures like:
fix fix-pr879-jczhang-optimize-vecscatter-multi-copy
add manual page cross links for SNESLineSearchSetPostCheck() and related routines
fix help manual of MatCreateSubmatrices() Reported-by: Tim Steinhoff <kandanovian@gmail.com>
Add manual pages for PetscRealPart() and PetscImaginaryPart()
fix compile error with missing MPI_C_DOBULE_COMPLEX
fix typo Reported-by: Febrian Setianto <febrian.setianto@gmail.com>
plex tutorial ex5: updated test requirements
DMPlexLoad_HDF5_Xdmf_Internal: fix for complex PetscScalar.
DMPlexLoad_HDF5_Xdmf_Internal: fix for 64-bit PetscInt.
DMPlexBuildFromCellList_Internal: use DMPlexInvertCell_Internal (with PetscInt* arg)
petscviewer.h: removed notice which is no longer relevant
DMPlexCreateFromFile: document option
check only if PETSC_USE_DEBUG
DMPlexBuildFromCellList_Internal optionally inverts cells.
ex5: new test 4 with -compare without repartitioning
ex5: new test 3 using -compare
ex5: HDF5 write+read moved to separate function
ex5: option -format processed in ProcessOptions()
ex5: added missing hdf5 requirement
...

Conflicts:
include/petsclog.h

show more ...

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead code.
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
...

Conflicts:
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'master' into knepley/fix-plex-residual-loop
Warning: This merge includes real changes

* master: (188 commits)
Add JuMP citation
Copyedits and updates to developers manual
Add mor

Merge branch 'master' into knepley/fix-plex-residual-loop
Warning: This merge includes real changes

* master: (188 commits)
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
SNES ex62: Set name of solution vector - Update test output
revert sources to dev - reset PETSC_VERSION_RELEASE - reset changes/dev.html
release: set v3.9 strings
move output file to the correct location. i.e fix 305862f9cd0dc399542ae11dd744508e4b6ad2e3
...

Conflicts:
src/snes/utils/dmplexsnes.c
src/ts/utils/dmplexts.c

show more ...

Merge branch 'maint'

includes should always be included relative to include directory

Apple changed the location for DocSets

Commit-type: bug-fix, documentation

Merge branch 'master' into knepley/feature-pc-patch

* master: (440 commits)
revert sources to dev - reset PETSC_VERSION_RELEASE - reset changes/dev.html
release: set v3.9 strings
fix grep us

Merge branch 'master' into knepley/feature-pc-patch

* master: (440 commits)
revert sources to dev - reset PETSC_VERSION_RELEASE - reset changes/dev.html
release: set v3.9 strings
fix grep usage on solaris [use egrep]
opensolaris: fix errors
Update timer reporting and minor reporting fix
Remove redundant if statement. Found by @jedbrown
Fixed problem with order of developer photos on website.
superlu_dist: use correct flag in example [PETSC_HAVE_SUPERLU -> PETSC_HAVE_SUPERLU_DIST]
Bib: PERMON ref
fix for osx
doc: more author fixes
doc: more author fixes
Italicized "orderings" in MPI process placement discussion.
Added Richard to the user manual author list.
Added Richard to the list of active developers on the website.
add string check for MS-MPI and IMPI timeout errors
opensolaris does not have multiple grep utils - but default one does not support -F. So use fgrep instead
Standardizing timeout checks
Report wall clock time of total tests
Use time instead of date %s
...

Conflicts:
include/petscpc.h
src/ksp/ksp/interface/itfunc.c

show more ...

Merge branch 'psanan/dmswarm-namespacing' [PR #904]

* psanan/dmswarm-namespacing:
This attempts to namespace many of the internally-used components of DMSwarm.

DMSwarm: namespacing and symbol hiding

DataBucket --> DMSwarmDataBucket
DataEx --> DMSwarmDataEx
DataField --> DMSwarmDataField
DEObjectState --> DMSwarmDEObjectState
DATA_BUCKET_XXX --> DMSWARM_DAT

DMSwarm: namespacing and symbol hiding

DataBucket --> DMSwarmDataBucket
DataEx --> DMSwarmDataEx
DataField --> DMSwarmDataField
DEObjectState --> DMSwarmDEObjectState
DATA_BUCKET_XXX --> DMSWARM_DATA_BUCKET_XXX
DATAFIELD_XXX --> DMSWARM_DATAFIELD_XXX
StringInList/StringFindInList --> DMSwarmDataFieldStringInList/DMSwarmDataFieldStringFindInList
__DATATFIELD_XXX --> DMSWARM_DATAFIELD_XXX

Mark DMSwarmDataBucket and DMSwarmDataEx functions PETSC_INTERN

Update test output with new names DMSwarmDataEx and DMSwarmDataBucket

Fix alignment as needed, and perform other minor formatting fixes.

show more ...

Merge branch 'barry/add-ftn-linfinity-conv-test' of bitbucket.org:petsc/petsc into barry/add-ftn-linfinity-conv-test

PetscSNPrintf() on windows adds special chars into the string? use PetscStrncpy() instead.

Fixes:

not ok diff-dm_tutorials-ex20_1
# > [0]PETSC ERROR: Unable to open file
# > [0]PETSC ER

PetscSNPrintf() on windows adds special chars into the string? use PetscStrncpy() instead.

Fixes:

not ok diff-dm_tutorials-ex20_1
# > [0]PETSC ERROR: Unable to open file
# > [0]PETSC ERROR: Cannot create file ex20.^A_swarm_fields.pbin for writing

show more ...

Merge branch 'master' into scott/ksp-ksp-tutorials

Merge branch 'barry/all-new-test-harness-branches'

Fix formating of more of SwarmPIC, fix swarm example use of RAND48 (not portable), other portability issues

Commit-type: portability-fix, testing-fix

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with updated 17.10 compilers
Fix for test dirs that are not tutorials/tests
fix use of double in PetscAbsReal() which produces compiler warnings with single precision build
elemental: remove info on conflict of -with-cxx-dialect=C++11 on osx - it works now.
Cleanup .bib files
Fix allfortranstubs rule to rm generated files from correct directory, not outdated location
ierr set but not checked
Remove initial refine so test runs faster and does not time out on some machines
Gail's copyedits for bibtex items
Docs: manual: add further description of 3 different current testing options
DM: check for ops->localtolocalbegin/end before calling
PetscSF: fix typo in tutorial ex1
Vec+HDF5: Fix output for complex - Need to check for empty group name
SNES: SNESDestroy() can be called with snes->dm == NULL
SNES: SNESDestroy() can be called with snes->dm == NULL
Vec+HDF5: Fix output for complex - Need to check for empty group name
Docs: Manual: Update tests section
gmakegentest: also exclude .#filenames created by emacs
DMPlex: Fix output of test ex1 after changes to Gmsh reader
...

show more ...

Merge remote-tracking branch 'origin/knepley/feature-plex-l2-projection'