Enable PETSC_ATTRIBUTE_FORMAT()

Merge branch 'barry/2022-04-01/fix-petsc-options-begin-end/release' into 'main'

Remove bogus error returns from Begin/End() macros

See merge request petsc/petsc!5069

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jolivet/feature-less-checkfalse' into 'main'

Dividing by four the number of PetscCheckFalse()

See merge request petsc/petsc!5072

Remove some PetscCheckFalse()

Merge branch 'adams/gamg-timers-benchmarks' into 'main'

Adams/gamg timers benchmarks

See merge request petsc/petsc!5032

refactor timers in gamg

Merge branch 'barry/2022-03-30/strip-petscall-petsctrymethod' into 'main'

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

See merge request petsc/petsc!5051

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be addit

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be additions needed for running with a static error checker

Commit-type: error-checking
/spend 15m
Reported-by:
Lisandro Dalcin <dalcinl@gmail.com>

show more ...

Merge branch 'barry/2022-03-21/rm-pc-petsccheckfalse' into 'main'

Change a bunch of PetscCheckFalse() to PetscCheck() in pc

See merge request petsc/petsc!5000

Change a bunch of PetscCheckFalse() to PetscCheck() in pc

Commit-type: housekeeping, error-checking
/spend 45m

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

chkerr and friends wrapped

Merge branch 'barry/2022-03-13/fix-some-manualpages/release' into 'main'

Improve generation of manual pages/fix a variety of manul pages basic formatting

See merge request petsc/petsc!4969

doc: Fix a variety of manual page formatting issues

/spend 1h

Merge branch 'adams/landau-dmplex-prefix' into 'main'

Adams/landau dmplex prefix

See merge request petsc/petsc!4974

added GAMG graph timer

Merge branch 'jed/amg-symmetry' into 'main'

PCGAMG: skip symmetric non-SPD use of KSPCR for eigenvalues

See merge request petsc/petsc!4910

added prefix to GAMG info prints

PCGAMG: update tests

* formatting of Chebyshev information
* use of GAMG SA eigenvalue estimates

PCGAMG/KSPChebyshev: simplify logic for using SA eigenvalue estimates

Provided eigenvalue estimates are only relevant for Jacobi, otherwise discarded.

PCGAMG/KSPChebyshev: clean up sticky logic

Chebyshev was re-estimating eigenvalues after the first solve even when
PCGAMG was providing SA eigenvalues. The output was also confusing. Now
we only sto

PCGAMG/KSPChebyshev: clean up sticky logic

Chebyshev was re-estimating eigenvalues after the first solve even when
PCGAMG was providing SA eigenvalues. The output was also confusing. Now
we only store what is specified directly by the user and report how we
got our estimates.

MG smoother output now explains the eigenvalue targets and transform,
e.g., for the typical case where it's provided by GAMG.

KSP Object: (mg_levels_1_) 1 MPI processes
type: chebyshev
eigenvalue targets used: min 0.197657, max 2.17423
eigenvalues provided (min 0.0234084, max 1.97657) with transform: [0. 0.1; 0. 1.1]
maximum iterations=2, nonzero initial guess
tolerances: relative=1e-05, absolute=1e-50, divergence=10000.
left preconditioning
using NONE norm type for convergence test

show more ...

PCGAMG: fix invalid access from redundent KSPSetFromOptions(smoother)

If the user writes -mg_levels_ksp_type richardson, for example, then the
following code would be referencing invalid cheb->membe

PCGAMG: fix invalid access from redundent KSPSetFromOptions(smoother)

If the user writes -mg_levels_ksp_type richardson, for example, then the
following code would be referencing invalid cheb->members after
KSPSetFromOptions(smoother) changed the smoother from Chebyshev to
Richardson. But we don't need this call because KSPSetFromOptions is
called later in PCSetUp_MG, thus it's harmless for us to handle
Chebyshev here and allow for it to be changed later.

show more ...

PCGAMG: use SA estimates by default for Jacobi smoothers