| #
47dad92f
|
| 13-Mar-2011 |
Sean Farley <sean@mcs.anl.gov> |
Merged
Hg-commit: d8c12016d3250a8d659fa779bc1698da4d6c5237
|
| #
7d0a6c19
|
| 12-Mar-2011 |
Barry Smith <bsmith@mcs.anl.gov> |
removed #define PETSCXXX_DLL from top of all source files
Hg-commit: b784aa18ddcf5337d4011d34f0fa008681695ac1
|
| #
c1235816
|
| 10-May-2010 |
Barry Smith <bsmith@mcs.anl.gov> |
removed unneeded { around SETERRQX() calls}
Hg-commit: d55148dbbe8a10f500a7e181b91ba166aec6f665
|
| #
e7e72b3d
|
| 08-May-2010 |
Barry Smith <bsmith@mcs.anl.gov> |
changed many calls to SETERRQ() to use correct (non-PETSC_COMM_SELF) communicator reformated many badly formatted SETERRQ(); there was nonsense like {} around them or they were wrongly on a seperate
changed many calls to SETERRQ() to use correct (non-PETSC_COMM_SELF) communicator reformated many badly formatted SETERRQ(); there was nonsense like {} around them or they were wrongly on a seperate line
Hg-commit: 7550f3779f18eaf7ce68bae52b964532aa97c1d5
show more ...
|
| #
e32f2f54
|
| 07-May-2010 |
Barry Smith <bsmith@mcs.anl.gov> |
added MPI_Comm as first argument to PetscError() and SETERRQX()
Hg-commit: fe5a2ff050abc00ca2c2979c0af22b117b62874e
|
| #
e2dee56b
|
| 07-Oct-2009 |
Barry Smith <bsmith@mcs.anl.gov> |
commit after merge of patch to 3.0.0 in tfs
Hg-commit: 3782a3cc1a1f038eb250ec0984baa32350fa3da4
|
| #
9182e22c
|
| 07-Oct-2009 |
Barry Smith <bsmith@mcs.anl.gov> |
From: s.kramer@imperial.ac.uk Subject: bug in tfs preconditioner
think I found a nasty bug in the tfs preconditioner/solver. The first symptons were MPI complaints about corrupted messages in MPI_W
From: s.kramer@imperial.ac.uk Subject: bug in tfs preconditioner
think I found a nasty bug in the tfs preconditioner/solver. The first symptons were MPI complaints about corrupted messages in MPI_WAIT on line 1552 of ksp/pc/impls/tfs/gs.c (the file is the same in petsc-dev and 3.0.0). Valgrind suggested a buffer overrun (in reading) in MPI_Isend of line 1533:
ierr = MPI_Isend(dptr3, *msg_size++, MPIU_SCALAR, *list++, MSGTAG1+my_id, gs->gs_comm, msg_ids_out++);CHKERRQ(ierr);
Stepping through with a debugger however it looked like everything going into the MPI_Isends and MPI_Irecvs was perfectly fine. Until I realised that they were both replaced by a macro from petsclog.h:
#define MPI_Isend(buf,count,datatype,dest,tag,comm,request) \ ((isend_ct++,0) || TypeSize(&isend_len,count,datatype) || MPI_Isend(buf,count,datatype,dest,tag,comm,request))
Because count is used twice in that expression, the argument *msg_size++ is evaluated twice, and only gives the right integer value in calling TypeSize, and will be wrong in the actual MPI_Isend call. The same thing is going on on line 1327 of gs.c btw. If someone has time to look into this, it would be much appreciated. Has the tfs solver been used/applied much, as far as people know?
Hg-commit: 434a17925af32ecc820090666284b512ae1455e8
show more ...
|
| #
2d200336
|
| 06-Nov-2008 |
Matthew Knepley <knepley@mcs.anl.gov> |
Merge
Hg-commit: af487d5b45dae01d0566132d57158d0286d6a750
|
| #
7c4f633d
|
| 03-Nov-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed -I$PETSC_DIR from make system and changed the corresponding #include "src/dsdsdsds" to "../src/sdsdsds" in the source code
Hg-commit: 6e3c4cc4b4bfcb366bae9b71afcb5009c1f0429d
|
| #
dbefa33d
|
| 28-Jan-2008 |
Matthew Knepley <knepley@mcs.anl.gov> |
Merge
Hg-commit: bf61e6626fd829977ea46dc50931d6e9b988a6f6
|
| #
0805154b
|
| 26-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
[PETSC #17255] nightly tests fixed but introduced into VecScatterToZero/All() Added error checking for overflow for cast from PetscInt to PetscBLASInt in all cases Added some error checking for overf
[PETSC #17255] nightly tests fixed but introduced into VecScatterToZero/All() Added error checking for overflow for cast from PetscInt to PetscBLASInt in all cases Added some error checking for overflow for cast from PetscInt to PetscMPIInt
Hg-commit: 7540d46ad0a2abd61067805cfc8cb914325338a4
show more ...
|
| #
1c0add76
|
| 22-Jan-2008 |
Matthew Knepley <knepley@mcs.anl.gov> |
Merge
Hg-commit: 50f87a7744bf92447897e71d01d55e453fda1a7f
|
| #
8bcdec41
|
| 22-Jan-2008 |
Matthew Knepley <knepley@mcs.anl.gov> |
Merge
Hg-commit: cf45133fecf2bc56c1533c7ce0104c19c36632d4
|
| #
0229d381
|
| 21-Jan-2008 |
Matthew Knepley <knepley@mcs.anl.gov> |
Merge
Hg-commit: 4b796613330e0d9282b827b1e897b9d121013872
|
| #
4a0de3f6
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
more fixes to PCTFS 64 bit indices including blas calls and printf formating strings
Hg-commit: 12d8cf3142e897597270195422355edffde0a31b
|
| #
40772624
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed many PCTFS unused gs_gop functions
Hg-commit: d179814eb85041de510e82098c25753734f44692
|
| #
6e4f4d19
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
started preparing PCTFS for 64 bit, removed many unneeded gs routines
Hg-commit: da364f82cd75ed15cf6a1f85174960df7664e6cc
|
| #
f1ed62a8
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
fixes for 64 indices in PCASA, walltoallv() and sprintf() usage
Hg-commit: 9614c103054b84d777596ab29bd0b0723c626a45
|
| #
d1528f56
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed PC tfs homebrew logging messages, replaced with use of PetscInfo
Hg-commit: 1c59e0e06fc719a6ee9bab590ad7e5122b24d2d2
|
| #
388eb383
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed homebrew error handling from PC tfs and replace with SETERR...
Hg-commit: 83a9eaf14f8f2c6c5bc728362c0f75dee3eab884
|
| #
52f87cda
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
changed all ints in PC tfs to PetscInt
Hg-commit: e3ce092f5fd00e04339f559d435f2b04e5a8bebc
|
| #
7b1ae94c
|
| 21-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed blank comments from PC tfs and minor code formatting
Hg-commit: f695871ee8486d2078ab2be1925fde462558a8d0
|
| #
97875e9b
|
| 19-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed all queue code from PC tfs it was not used
Hg-commit: e168fe53cad3da6b9e600bb2aea79dba5caf2802
|
| #
1d7d0905
|
| 19-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed many unused ivec_ and rvec_ functions from tfs
Hg-commit: 82d78dcb2d92a2c067b48e8fd0fe63bf5c9e3f3c
|
| #
e0c92978
|
| 19-Jan-2008 |
Barry Smith <bsmith@mcs.anl.gov> |
removed left over fortran interface stuff from tfs
Hg-commit: 4744a1f50de88994dcb39e06c432b55aaaa229eb
|