| 498e7f42 | 31-Dec-2025 |
Richard Tran Mills <rmills@rmills.org> |
Remove legacy '+1' allocations in XXXDiagonalScaleLocalSetUp() routines for AIJ and BAIJ parallel matrices
This commit removes '+1's in some memory allocations that are believed
to be leftover from
Remove legacy '+1' allocations in XXXDiagonalScaleLocalSetUp() routines for AIJ and BAIJ parallel matrices
This commit removes '+1's in some memory allocations that are believed
to be leftover from long ago to handle corner cases with malloc() calls
of size 0, which some implementations would not handle correctly. This
ceased to be an issue long ago.
Thanks-to: Pierre Jolivet <pierre@joliv.et>, Barry Smith <bsmith@petsc.dev>
show more ...
|
| b1f10902 | 23-Dec-2025 |
Richard Tran Mills <rmills@rmills.org> |
Fix long-standing bug in MatMPIAIJDiagonalScaleLocalSetUp()
This commit fixes a problem I discovered in October 2017 and then forgot about
after some unsuccessful initial attempts to find the proble
Fix long-standing bug in MatMPIAIJDiagonalScaleLocalSetUp()
This commit fixes a problem I discovered in October 2017 and then forgot about
after some unsuccessful initial attempts to find the problem. The MPIAIJ
implementation for MatDiagonalScaleLocalSetUp() was broken when the
local-to-global mappings in PETSc were refactored to always use
block indices; the MPIAIJ implementation of
MatDiagonalScaleLocalSetUp(), however, used element-wise, not block
indexing, and this was not refactored at the time, as it was overlooked
due to having no test case.
My commit finally fixes this; it also fixes several memory leaks in the
AIJ and BAIJ implementations of MatDiagonalScaleLocal() which were
overlooked, again, due to having no test cases.
show more ...
|