Merge branch 'jolivet/clang-format-18' into 'main'

clang-format version 18

See merge request petsc/petsc!6902

Remove extra "" after format specifier ending a string

git grep -l -E "_FMT \"\"," | xargs sed -r -i'' 's#_FMT \"\",#_FMT,#g'

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g'
git grep -l -E "Petsc(.)*\(\(\*[a-zA-Z0-9_]*\)," | xargs sed -r -i'' 's#Petsc([a-zA-Z0-9_]*)\(\(\*([a-zA-Z0-9_]*)\), #Petsc\1(*\2, #g'
git grep -l -E "([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)" | xargs sed -r -i'' 's#([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)#\1\2#g'

show more ...

checkbadSource: rules for PetscFunctionBegin and derivatives

Merge branch 'jeremy/mpi-A-blk-size' into 'main'

Set MPIAIJ local mat block sizes when setting COO preallocation

See merge request petsc/petsc!7337

Merge branch 'barry/2024-03-03/docs-mat-manpages' into 'main'

Clarify which MatCreate and friends copies the user provided values

See merge request petsc/petsc!7336

Clarify which MatCreate and friends copies the user provided values

Reported-by: Fabian Wermelinger <fab4100@posteo.ch>

mat - set block sizes when setting COO preallocation

Merge branch 'barry/2024-02-23/doc-trivial-mat' into 'main'

Bug fix, calling MatXXXSetPreallocation on MPI matrices after MatSetOption() loses the option value

See merge request petsc/petsc!7319

Bug fix, calling MatXXXSetPreallocation on MPI matrices after MatSetOption() loses the option value

Reported-by: Francois Fraysse

Merge branch 'barry/2024-02-09/fix-matzerorowscolumns' into 'main'

Fix bugs in MatZeroRowsColumns() both in docs and handling of no-nonzero on diagonal

See merge request petsc/petsc!7279

Fix bugs in MatZeroRowsColumns() both in docs and handling of no-nonzero on diagonal

Bug 1 - documentation
The documentation statement "Unlike `MatZeroRows()` this does not change the nonzero struct

Fix bugs in MatZeroRowsColumns() both in docs and handling of no-nonzero on diagonal

Bug 1 - documentation
The documentation statement "Unlike `MatZeroRows()` this does not change the nonzero structure of the matrix, it merely zeros those entries in the matrix." appears to be incorrect for matrices missing diagonal entries since new nonzeros are added (to fill in the diagonal). The documentation should really say

"Unlike `MatZeroRows()` this routine cannot remove the zeroed entries from the nonzero structure of the matrix; in other words setting the option `MAT_KEEP_NONZERO_PATTERN to PETSC_FALSE has no effect on this routine.

Bug 2 -
The short circuit if (!((Mat_SeqAIJ *)(l->A->data))->keepnonzeropattern) is wrong because that flag is meaningless for this operation. The check should be changed (I think) to nonew instead of keepnonzeropattern.

Reported-by: Jeremy Theler <jeremy.theler-ext@ansys.com>

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'adams/feature-jacobi-l1' into 'main'

Mat: GetAbsSum (l1) row norms; PCJacobi: add scaled L1 diagonal approximation

See merge request petsc/petsc!7260

Mat: GetAbsSum (l1) row norms; PCJacobi: add scaled L1 diagonal approximation

Merge branch 'jczhang/2024-02-08/fix-manual-MatCreateMPIAIJWithArrays' into 'release'

Update manual since MatUpdateMPIAIJWithArrays is deprecated

See merge request petsc/petsc!7273

Update manual since MatUpdateMPIAIJWithArrays is deprecated

Merge branch 'adams/gamg-feature-injection' into 'main'

GAMG: add injection for C1 elements

See merge request petsc/petsc!7236

matcoarsen bug fix

Merge remote-tracking branch 'origin/release'

Merge branch 'barry/2024-01-08/docs-matmpiaijsetpreallocationcsr/release' into 'release'

clarify man pages for MatCreateMPIAIJWithArrays() etc regarding sorted column indices

See merge request pets

Merge branch 'barry/2024-01-08/docs-matmpiaijsetpreallocationcsr/release' into 'release'

clarify man pages for MatCreateMPIAIJWithArrays() etc regarding sorted column indices

See merge request petsc/petsc!7170

show more ...

clarify man pages for MatCreateMPIAIJWithArrays() etc regarding sorted column indices

Reported-by: Mathieu Deuse

MatUpdateMPIAIJWithArrays: add out-of-range error check

Merge branch 'jolivet/fix-ubsan' into 'main'

Pacify UBSan

See merge request petsc/petsc!7158

Sys: add PetscSafePointerPlusOffset() to pacify UBSan