Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jolivet/feature-less-checkfalse' into 'main'

Dividing by four the number of PetscCheckFalse()

See merge request petsc/petsc!5072

Remove some PetscCheckFalse()

Merge branch 'jczhang/fix-mpiaijcusparse-handle-stream' into 'main'

Mat_MPIAIJCUSPARSE does not need to have its own stream or cuSparse handle

See merge request petsc/petsc!5020

Mat: Mat_MPIAIJCUSPARSE does not need to have its own cuSparse handle or cuda stream

As Mat_SeqAIJCUSPARSE already has them. Otherwise, if we create a cuSparse handle in Mat_MPIAIJCUSPARSE,
and set

Mat: Mat_MPIAIJCUSPARSE does not need to have its own cuSparse handle or cuda stream

As Mat_SeqAIJCUSPARSE already has them. Otherwise, if we create a cuSparse handle in Mat_MPIAIJCUSPARSE,
and set it as diagonal A and offdiagonal B's handle, then in MatDestroy_SeqAIJCUSPARSE(), we may destroy
the same handle twice: one for for A, the other for B.

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

pluck ~1000 low hanging PetscCheckFalse() -> PetscCheck() fruit

chkerr and friends wrapped

Merge branch 'stefanozampini/matis-negative-indices' into 'main'

matis negative indices

See merge request petsc/petsc!4923

MatSetPreallocationCOO: avoid MatHeaderMerge

Merge branch 'jed/fix-mat-coo-aijcusparse' into 'main'

Mat AIJCUSPARSE: fix MatSetValuesCOO non-basic GPU assembly

See merge request petsc/petsc!4899

Mat AIJCUSPARSE: fix MatSetValuesCOO non-basic GPU assembly

Otherwise we get error traces like:

(gdb) p cusp->mat
$6 = (Mat_SeqAIJCUSPARSEMultStruct *) 0x0
(gdb) bt

Merge branch 'jczhang/feature-improve-mataij-coo' into 'main'

Do COO preallocation on MATAIJ and share the plan with other device matrix types

See merge request petsc/petsc!4831

Mat: remove the convinience that NULL coo_v[] means a zero array

Mat: support extended COO with mataijcusparse

Merge branch 'jacobf/2022-01-05/c99' into 'main'

Feature: C99 and C++11

See merge request petsc/petsc!4700

rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()

add PetscAssert() and PetscAssertFalse()

SETERRQ[1-9]+ begone

Merge branch 'jed/mat-coo-size_t' into 'main'

MatSetPreallocationCOO: use PetscCount for length argument

See merge request petsc/petsc!4789

Mat CUSPARSE: tidy error-prone PETSC_INTERN redeclaration

MatSetPreallocationCOO: use PetscCount for length argument

This is necessary to support assembly even when the vector size and
number of nonzeros is well below 2B. For example, with a scalar problem

MatSetPreallocationCOO: use PetscCount for length argument

This is necessary to support assembly even when the vector size and
number of nonzeros is well below 2B. For example, with a scalar problem
on Q_1 hexes, you have 8*8=64 entries per element and thus hit 2B around
33M elements. This change allows such problems to be solved without
promoting to 64-bit indices everywhere (a storage and bandwidth cost).

PetscCount is a new signed type equivalent to ptrdiff_t, meant for array
indices and sizes that may overflow int32_t even when solving a problem
whose dimension fits in int32_t.

show more ...

Merge branch 'jacobf/2021-12-09/attribute-format-mat' into 'main'

Feature: Attribute Format - Mat

See merge request petsc/petsc!4634

applied attribute format fixes to mat headers