Merge branch 'barry/2022-07-20/fix-using-seterrq' into 'main'

Remove outdated use of if() SETERRQ

See merge request petsc/petsc!5457

Remove outdated use of if() SETERRQ

Commit-type: style
/spend 20m
Reported-by: clang-format

Merge branch 'jolivet/fix-mumps-ci' into 'main'

MUMPS: fix -mat_mumps_use_omp_threads option

See merge request petsc/petsc!5392

MUMPS: fix -mat_mumps_use_omp_threads option

Merge branch 'barry/2022-06-11/improve-mat-setable-values' into 'main'

Refactor handling of settable properties of matrix via MatSetOptions

See merge request petsc/petsc!5338

Refactor handling of setable properties of matrices via MatSetOptions()

Introduce PetscBool3 with enum values true, false, and unknown

Use PetscBool3 to store matrices properties in a matrix and cl

Refactor handling of setable properties of matrices via MatSetOptions()

Introduce PetscBool3 with enum values true, false, and unknown

Use PetscBool3 to store matrices properties in a matrix and cleanup interface to check these values

Add full support for symmetric, Hermitian, structurally symmetric, and SPD.

Commit-type: feature
/spend 6h

show more ...

Merge branch 'wence/petsc-check-do-while' into 'main'

Wrap PetscCheck and PetscAssert in do { } while (0)

Closes #1199

See merge request petsc/petsc!5291

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these macros being "if (...)
statement_without_semicolon". Fixes #1199.

show more ...

Merge branch 'barry/2022-06-13/make-one-line-if-call' into 'main'

Change if () { PetscCall() } three liner to one liner

See merge request petsc/petsc!5344

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$[ ]*}\$?\1if (\2) PetscCall(\3$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

for i in `git ls-files | grep "\.[hc]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ }else]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$\([ ]*\)} \([- ._+=a-z0-9A-Z>*,()]*);\)\$?\1if (\2) PetscCall(\3$\4\5$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

Yes, really ugly but Barry still cannot master awk

Commit-type: housekeeping

show more ...

Merge branch 'hzhang/external-matfactor-options' into 'main'

Get options in symbolic factorization instead of MatGetFactor() using KSP/PC prefix when inside KSP

See merge request petsc/petsc!5230

Change matrix factor database options that occur in KSP/PC to always use KSP/PC options prefix

Add MatSetOptionsPrefixFactor() and MatAppendOptionsPrefixFactor() to allow controlling the options pre

Change matrix factor database options that occur in KSP/PC to always use KSP/PC options prefix

Add MatSetOptionsPrefixFactor() and MatAppendOptionsPrefixFactor() to allow controlling the options prefix
used by factors created from this matrix

Change MatSetOptionsPrefix() to no longer affect the options prefix used by factors created from this matrix

As part of the above work the handling of the factor matrix options is now done in code in the factor matrix
not in the code that originates the factor matrix

Update examples output to the new approach where the factored matrix prefix is set from the KSP/PC

Much of this work was performed by Hong Zhang

Commit-type: usability
/spend 5h

show more ...

Merge branch 'psanan/docs-sphinx-man-pages' into 'main'

Integrate Man Pages into Sphinx Docs

Closes #1132 and #1015

See merge request petsc/petsc!4989

Merge branch 'barry/2022-04-28/rm-petsccheckfalse-mat' into 'main'

Remove the rest of the PetscCheckFalse() from the mat directory

See merge request petsc/petsc!5184

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (wor

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (word.rstrip(","), comma)

def _process_stripped_line(line):
return " ".join(map(_process_word, line.split()))

start_pattern = re.compile(r"^( *\.seealso:? )(.*$)")

def process_file(filename_full):
with fileinput.FileInput(filename_full, inplace=True) as f:
in_block = False
for line in f:
line_stripped = line.strip()
# end ".seealso blocks" on a blank line or C-style comment close
line_modified = None
if not line_stripped:
in_block = False
elif line_stripped.endswith("*/"):
in_block = False
else:
match = re.match(start_pattern,
line) # not stripped line
if match:
indent = " " * len(match.group(1))
in_block = True
line_modified = match.group(
1) + _process_stripped_line(
match.group(2).strip())
elif in_block:
line_modified = indent + _process_stripped_line(
line_stripped)
if line_modified:
print(line_modified) # prints to the file
else:
print(line, end="") # prints to the file

BASE_DIRS = ["src", "include"]
EXT = [".c", ".cxx", ".cpp", ".cu", ".h", ".hpp", ".hxx"]
EXCLUDE_DIRS = ["tests", "tutorials", "ftn-auto", "ftn-custom", "benchmarks"]

def main():
""" Process everything """
for base in BASE_DIRS:
for root, dirs, files in os.walk(base):
for filename in files:
if os.path.splitext(filename)[1] in EXT:
filename_full = os.path.join(root, filename)
print("FILE ---", filename_full)
process_file(filename_full)
for exclude_dir in EXCLUDE_DIRS:
if exclude_dir in dirs:
dirs.remove(exclude_dir)

if __name__ == "__main__":
main()
```

show more ...

Remove the rest of the PetscCheckFalse() from the mat directory

Commit-type: housekeeping
/spend 45m

Merge branch 'jolivet/feature-mumps-5.5.0' into 'main'

configure: MUMPS 5.5.0

See merge request petsc/petsc!5124

configure: MUMPS 5.5.0

Merge branch 'barry/2022-04-01/fix-petsc-options-begin-end/release' into 'main'

Remove bogus error returns from Begin/End() macros

See merge request petsc/petsc!5069

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jolivet/feature-less-checkfalse' into 'main'

Dividing by four the number of PetscCheckFalse()

See merge request petsc/petsc!5072

Remove some PetscCheckFalse()

Merge branch 'barry/2022-03-30/strip-petscall-petsctrymethod' into 'main'

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

See merge request petsc/petsc!5051

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be addit

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be additions needed for running with a static error checker

Commit-type: error-checking
/spend 15m
Reported-by:
Lisandro Dalcin <dalcinl@gmail.com>

show more ...

Merge branch 'jolivet/fix-warnings' into 'main'

-Wtype-limits

See merge request petsc/petsc!5046