Merge branch 'barry/2022-03-30/fix-mpiu_allreduce' into 'main'

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

See merge request petsc/petsc!5052

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

Both for debug and optimized builds

Also removes shadow declaration errors from use of mpiu_allreduce

Commit-type: error-

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

Both for debug and optimized builds

Also removes shadow declaration errors from use of mpiu_allreduce

Commit-type: error-checking
Reported-by: Lisandro Dalcin <dalcinl@gmail.com>

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

chkerr and friends wrapped

Merge branch 'jacobf/2022-01-05/c99' into 'main'

Feature: C99 and C++11

See merge request petsc/petsc!4700

rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()

add PetscAssert() and PetscAssertFalse()

SETERRQ[1-9]+ begone

Merge branch 'jacobf/2021-12-09/attribute-format-mat' into 'main'

Feature: Attribute Format - Mat

See merge request petsc/petsc!4634

applied attribute format fixes to mat headers

Merge branch 'barry/2021-06-10/fix-chkerrq' into 'main'

Fix missing ierr =, removed incorrect CHKERRQ(), change CHKStringError

See merge request petsc/petsc!4078

Fix missing ierr =, removed incorrect CHKERRQ()

Commit-type: error-checking, style-fix
\spend 45m

Merge branch 'stefanozampini/update-checkbadsource' into 'main'

Update badsource rules

See merge request petsc/petsc!4064

Update badsource rules

- Zero or more spaces are not allowed for more returning types
- zero spaces not allowed for for|if|while

Merge branch 'barry/2021-05-02/fix-logging-no-symbolic-factorization' into 'main'

For factorization types/packages that do not perform a seperate symbolic phase...

See merge request petsc/petsc!3943

For factorization types/packages that do not perform a seperate symbolic phase do not log the event.

Also log the "numerical" factorization as an entire factorization

An alternative would be to pro

For factorization types/packages that do not perform a seperate symbolic phase do not log the event.

Also log the "numerical" factorization as an entire factorization

An alternative would be to provide MatXXXFactorSetUp_XXX that is called in lieu of the symbolic function
for such types/packages but requires more changes to the code.

Commit-type: bug fix for logging
/spend 45m
Reported-by: Xiaoye S. Li <xsli@lbl.gov>
Reported-by: Stephen Jardin <jardin@pppl.gov>
Reported-by: Jin Chen <jchen@pppl.gov>
Reported-by: Nan Ding <nanding@lbl.gov>
Reported-by: Yang Liu <liuyangzhuan@lbl.gov>

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'jolivet/fix-missing-citations' into 'release'

ScaLAPACK/Elemental: add citation

See merge request petsc/petsc!3938

ScaLAPACK/Elemental: add citation

Merge remote-tracking branch 'origin/barry/2021-03-28/fix-mpiu-allreduce-mpi-failure'

Fix capture of MPI error code in MPIU_Allreduce()

See merge request petsc/petsc!3777

All MPIU_ functions except MPIU_File return MPI error codes for checking

Update checkbadSource to find use of CHKERRQ with MPIU_ functions

Commit-type: i.e. error-checking, optimization, bug-fix, p

All MPIU_ functions except MPIU_File return MPI error codes for checking

Update checkbadSource to find use of CHKERRQ with MPIU_ functions

Commit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, example
Funded-by:
Project:
Time: hours
Reported-by:
Thanks-to:
Development Tools: Vim, Emacs, Eclipse

show more ...

Merge branch 'barry/2020-10-08/fix-mpi-error-codes' into 'master'

Convert MPI error type to PETSc error with string message for all MPI calls

See merge request petsc/petsc!3326

Convert MPI error type to PETSc error with string message for all MPI calls

Now PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-pro

Convert MPI error type to PETSc error with string message for all MPI calls

Now PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-process their
errors better.

The test harness will now automatically retry tests that fail with MPI, this may help with Intel MPI that produces
seemingly random failures.

Commit-type: error-checking
/spend 30m

show more ...

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...