Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be addit

Do not wrap PetscTryMethod() PetscUseMethod() in PetscCall

It produces shadow declarations and also serves no purpose since these macros do the appropriate error checking already

There may be additions needed for running with a static error checker

Commit-type: error-checking
/spend 15m
Reported-by:
Lisandro Dalcin <dalcinl@gmail.com>

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

fixes from recent linter change

pluck ~1000 low hanging PetscCheckFalse() -> PetscCheck() fruit

chkerr and friends wrapped

Merge branch 'jolivet/fix-warnings' into 'main'

Fix compilation warnings

See merge request petsc/petsc!4972

Fix compilation warnings

-Wmissing-field-initializers -Wunused-but-set-variable

Merge branch 'barry/2022-02-24/rm-petscassert-false' into 'main'

Remove PetscAssertFalse(), change some incorrect use of PetscAssert*() for...

See merge request petsc/petsc!4887

Remove PetscAssertFalse(), change some incorrect use of PetscAssert*() for OUTOFRANGE to PetscCheck()

Commit-type: error-checking, style-fix
/spend 1h

Merge branch 'jacobf/2022-02-21/checkbadsource-enforce-petsccheck' into 'main'

Enforce PetscCheck() and PetscAssert() usage via checkbadSource

See merge request petsc/petsc!4874

Enforce PetscCheck() and PetscAssert() usage via checkbadSource

Merge branch 'jacobf/2022-01-05/c99' into 'main'

Feature: C99 and C++11

See merge request petsc/petsc!4700

rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()

add PetscAssert() and PetscAssertFalse()

make PetscInfo() variadic

SETERRQ[1-9]+ begone

Merge remote-tracking branch 'origin/release'

Merge branch 'jolivet/fix-hypre-convert' into 'release'

MatConvert_HYPRE_AIJ: fix MAT_REUSE_MATRIX

See merge request petsc/petsc!4824

MatAXPY: check for pattern --with-debugging=yes

Only applies to MatSeq[SB]AIJ

Merge branch 'jacobf/2021-12-09/attribute-format-mat' into 'main'

Feature: Attribute Format - Mat

See merge request petsc/petsc!4634

applied attribute format fixes to mat headers

Merge branch 'stefanozampini/fix-matheadermerge' into 'main'

MatAXPY: use MatHeaderMerge

See merge request petsc/petsc!4580

MatAXPY: Use MatHeaderMerge instead of MatHeaderReplace

Merge branch 'jose/spelling-errors' into 'main'

Fix many spelling errors in manpages and comments

See merge request petsc/petsc!4283