SNES: SNESDestroy() can be called with snes->dm == NULL

SNES: SNESDestroy() can be called with snes->dm == NULL

Merge remote-tracking branch 'origin/barry/snes-view-display-fd'

Merge branch 'knepley/feature-adaptor-plex' into knepley/feature-plex-adjoint-prelim

* knepley/feature-adaptor-plex: (38 commits)
SNES ex12: Fixed AMR tests - Cleaned up use of r Vec - Updated out

Merge branch 'knepley/feature-adaptor-plex' into knepley/feature-plex-adjoint-prelim

* knepley/feature-adaptor-plex: (38 commits)
SNES ex12: Fixed AMR tests - Cleaned up use of r Vec - Updated output
DMAdaptor: Fixes handling of original Vec and DM - Fix handling of input vector x - Only LABEL needs a Plex conversion
fixed uninitialized var
SNES ex12: Added adaptation test for p4est
DMAdaptor: Error indicator working for p4est on SNES ex12 - Changed DMAdaptor to a DM class - Added DMAdaptorComputeErrorIndicator_Private() - Added DMAdaptorSimpleErrorIndicator_Private() - Name projected solution vector
PetscFE: Added PetscFEInterpolateFieldAndGradient_Internal()
DMPlexComputeGradientClementInterpolant: fix debug statement for complex
SMAdaptor: Fix for complex ev decamp
compile fixes
DMAdaptor: Correct warnings and complex problems
Plex: Added versions of the Det functions that take Scalar data
DMAdaptor: Declare DMAdaptorSet/GetSequenceLength()
SNES+ex12: Added support for ascii_info_detail in -snes_converged_reason - It prints the L_2 error using the DS information - SNES ex12 output updated
DMAdaptor: Added options - Added options for N_adapt, refinement factor, h_min and h_max
SNES ex12: I finally think test output is correct
DMAdaptor: Refine viewing
SNES ex12: Updated adaptation tests - Added sequential adaptation
SNES: Added -snes_adapt_sequence - Eventually remove snes_grid_sequence
DMAdaptor: - Added sequential adaptation - Added DMAdaptorGet/SetSequenceLength() - Use AdaptationCriterion now - Added untested unstructured interpolation
DMAdaptor: Now I have AdaptationStrategy and AdaptationCriterion - Fixed some docs
...

show more ...

Merge commit 'd47bf9aaf1e5266cc3f0ff499f934c85788965a9' into jed/fix-matcreatempibaij/maint

Obtain changed (v3.5) handling of MatMPIBAIJSetPreallocationCSR to match
documentation.

Have SNES display if -snes_fd or -snes_fd_color are used to compute the Jacobian

Commit-type: feature
Reported-by: Ed Bueler <elbueler@alaska.edu>

Remove SNESHasDM

This may confuse users because PETSC always attach DM to SNES even though
users do not call SNESSetDM

Merge branch 'maint'

Merge remote-tracking branch 'origin/jed/fix-dmcoarsenhookadd-identical' into maint

Merge branch 'maint'

Merge remote-tracking branch 'origin/stefano_zampini/cherrypick-commits-for-maint-from-continuousadjoint' into maint

KSPSetDM, SNESSetDM, and TSSetDM: documentation

A DM can only be used to solve one problem at a time because information
about the problem is stored on the DM.

Reported-by: Blaise A Bourdin <bourdi

KSPSetDM, SNESSetDM, and TSSetDM: documentation

A DM can only be used to solve one problem at a time because information
about the problem is stored on the DM.

Reported-by: Blaise A Bourdin <bourdin@lsu.edu>

show more ...

doc clarification

Commit-type: documentation
Reported-by: Mark Adams <mfadams@lbl.gov>

MATMFFD: added MatSetUp_MFFD

move layouts setup to MatSetUp_MFFD
Added missing checks for public API calls
SNES: added missing checks for collective logical booleans in SNESSetUseMatrixFree()

DMCoarsenHookRemove: new interface to clean up stale hooks

The hooks are not automatically cleaned out when a DM outlives the SNES
and is used for another solve, leading to a hook referencing a
none

DMCoarsenHookRemove: new interface to clean up stale hooks

The hooks are not automatically cleaned out when a DM outlives the SNES
and is used for another solve, leading to a hook referencing a
nonexistent SNES.

Reported-by: Lawrence Mitchell <wencel@gmail.com>

show more ...

SNES+ex12: Added support for ascii_info_detail in -snes_converged_reason
- It prints the L_2 error using the DS information
- SNES ex12 output updated

SNES: Added -snes_adapt_sequence
- Eventually remove snes_grid_sequence

SNES: Add DMAdaptor call to SNES

-snes_fd did not work for some cases with TS and -pc_type mg

This was due to SNESComputeJacobianDefault() getting its work vectors from SNES instead of
the DM (historical design).

Commit-type: bug-

-snes_fd did not work for some cases with TS and -pc_type mg

This was due to SNESComputeJacobianDefault() getting its work vectors from SNES instead of
the DM (historical design).

Commit-type: bug-fix
Funded-by: ECP
Time: 1.3 hours
Reported-by: Ed Bueler <elbueler@alaska.edu>

show more ...

Merge remote-tracking branch 'origin/barry/feature-snes-force-iteration'

Provide an API for forcing SNES to take at least one iteration

This may be useful to prevent implicit TS methods from finding false steady state solutions
Commit-type: feature
Funded-by: Fission
Pro

Provide an API for forcing SNES to take at least one iteration

This may be useful to prevent implicit TS methods from finding false steady state solutions
Commit-type: feature
Funded-by: Fission
Project: xolotl
Time: .2 hours
Reported-by: Sophie Blondel <sblondel@utk.edu>

show more ...

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page information about convergence testing when using KSPRICHARDSON
SNES ex5: Restore old output since this breaks an example I have
Noted that some Cray XC systems will use 'aprun' instead of 'srun'. Thanks to Herr Doktor Hong Zhang for this suggestion.
Added example configure script for Cray XC40 with KNL processors (e.g., NERSC Cori).
Fix possible sprintf -Wformat-overflow
PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7
SNES ex5: make boundary condition handling consistent for symmetry
SNES ex5: use L2 norm and *_monitor_short for output
SNES ex5: the L^2 norm scales with the l^2 norm over sqrt(N)
SNES ex5: refactor MMS capability to avoid extreme code duplication
Documentation fix: typo in PetscLogStageRegister manual page.
nodes -> vertices
rename DMNetworkGetComponentTypeOffset -> DMNetworkGetComponentKeyOffset
rename DMNetworkGetConnectedNodes() -> DMNetworkGetConnectedVertices()
Jacobians for adjoints for explicit methods and constant Jacobians never got initialized
fix complex build error
fix build failure with fortran interface
fix compile error with cdc753b64c658d532d7813e942002e67025667a6
...

Conflicts:
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/ex69.c

show more ...

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output l

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output log for snes_tutorials-ex62_fetidp_3d_tet that got corrupted in 188e10d6f1cffa866ec0197053a0e55fa4e7da41
fix opensolaris build error with --with-log=0 Undefined first referenced symbol in file PetscLogEventGetPerfInfo arch-opensolaris-misc/tests/src/dm/impls/plex/examples/tests/ex9.o
fix warnings on windows C:\cygwin64\home\petsc\PETSC~1.CLO\src\tao\examples\TUTORI~1\ex1.c(217): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)'
disable example with absoft (due to fixed/free form limit)
c89 fixes
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
Plex ex19: Remove unneeded code
Plex: Fix projection when we have a dmAux which is a domain boundary - If we are projecting on a lower dimension thing (effectiveHeight > 0), then we need to get the space and dual space on this subcell - The tabulation needs to be in the right dimension for both dm and dmAux
PetscFE: Added height subspaces to PetscFE - Added PetscFEGetHeightSubspace() - Added array in struct
PetscDualSpace: Small cleanup of parameter name
PetscSpace: Added height subspaces for PetscSpace - Added PetscSapceGetHeightSubspace() and member function - Added subspaces array
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix some minor style issues
Extend AMS/ADS to support high-order element.
...

show more ...

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Merge branch 'master' into knepley/feature-dm-bc-components

* master: (320 commits)
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ m

Merge branch 'master' into knepley/feature-dm-bc-components

* master: (320 commits)
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
output has changed with e6d0a238963c2a97dd04845ea512b529992c7cdb so update the output file
...

show more ...