Tell clang-format to treat khash_t as a typename

Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

source code format changes due to .clang-format changes

Merge branch 'barry/2022-08-23/fix-sys-man' into 'main'

Fix up all manual pages in src/sys directory

See merge request petsc/petsc!5559

Fix up all manual pages in src/sys directory

Commit-type: documentation
/spend 10h

Merge branch 'jolivet/fix-style-one-liners' into 'main'

Remove braces from one-liners w/o PetscCall()

See merge request petsc/petsc!5561

Remove braces from one-liners w/o PetscCall()

Merge branch 'jolivet/fix-style-one-liners' into 'main'

Remove braces from one-liners

See merge request petsc/petsc!5557

Remove braces from one-liners

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

clang-format: convert PETSc sources to comply with clang-format

Merge branch 'barry/2022-07-25/print-warning-unused-options-on-error' into 'main'

Print unused options when output error message

See merge request petsc/petsc!5473

Print unused options when output error message

Commit-type: error-checking, feature
/spend 15m
Reported-by: Victor Eijkhout <eijkhout@tacc.utexas.edu>

Merge branch 'barry/2022-06-24/linenumbers-petscstack' into 'main'

Fixes/improvements for PETSc stack handling

See merge request petsc/petsc!5368

Rename PetscStackCallExternalNoErrorCode to PetscStackCallExternalVoid

I tried to rebase this into the commit that introduced PetscStackCallExternalNoErrorCode but that produced a mass
of bad merges

Rename PetscStackCallExternalNoErrorCode to PetscStackCallExternalVoid

I tried to rebase this into the commit that introduced PetscStackCallExternalNoErrorCode but that produced a mass
of bad merges; I am not sure why, so this stands along. Annoying for code review but bisection will work which
is the important thing.

Commit-type: housekeeping
/spend 2m
Reported-by: Stefano Zampini

show more ...

Add PETSc CI mode to allow better handling of errors and system dependent output when running in test harness

-petsc_ci - automatically set for all runs in test harness

-petsc_ci_portable_error_out

Add PETSc CI mode to allow better handling of errors and system dependent output when running in test harness

-petsc_ci - automatically set for all runs in test harness

-petsc_ci_portable_error_output - ensures all error messages (when possible are system and compiler information),
should be only used in tests that are explicitly testing the error handling

This allows proper comparisons of runs on different machines and when errors are intentionally triggered to test error handling

Commit-type: error-checking, testing-fix
/spend 5h

show more ...

Merge branch 'wence/petsc-check-do-while' into 'main'

Wrap PetscCheck and PetscAssert in do { } while (0)

Closes #1199

See merge request petsc/petsc!5291

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these macros being "if (...)
statement_without_semicolon". Fixes #1199.

show more ...

Merge branch 'barry/2022-06-13/make-one-line-if-call' into 'main'

Change if () { PetscCall() } three liner to one liner

See merge request petsc/petsc!5344

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$[ ]*}\$?\1if (\2) PetscCall(\3$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

for i in `git ls-files | grep "\.[hc]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ }else]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$\([ ]*\)} \([- ._+=a-z0-9A-Z>*,()]*);\)\$?\1if (\2) PetscCall(\3$\4\5$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

Yes, really ugly but Barry still cannot master awk

Commit-type: housekeeping

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'barry/2022-05-22/fix-const-decl-malloc/release' into 'release'

Fixes for variables declared with const char **val and similar with PetscMalloc() and PetscFree()

See merge request pets

Merge branch 'barry/2022-05-22/fix-const-decl-malloc/release' into 'release'

Fixes for variables declared with const char **val and similar with PetscMalloc() and PetscFree()

See merge request petsc/petsc!5263

show more ...

Fixes for variables declared with const char **val and similar

E:\FGH\Git\Windows\petsc-3.17.1\src\sys\objects\options.c(716): warning C4090: 'function': different 'const' qualifiers
E:\FGH\Git\Wind

Fixes for variables declared with const char **val and similar

E:\FGH\Git\Windows\petsc-3.17.1\src\sys\objects\options.c(716): warning C4090: 'function': different 'const' qualifiers
E:\FGH\Git\Windows\petsc-3.17.1\src\sys\objects\options.c(757): warning C4090: 'function': different 'const' qualifiers

A PetscMalloc() that does not belong in index.c

Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30133 for x64

Commit-type: portability-fix
/spend 15m
Reported-by: Henrik Büsing <Henrik.Buesing@fgh-ma.de>

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'jose/codespell-fixes' into 'release'

A few codespell fixes

See merge request petsc/petsc!5259