Merged in barry/fix-naming-cg-methods (pull request #1650)

Fixed inconsistent naming with CG methods for TR

Approved-by: Matthew Knepley <knepley@gmail.com>

Fixed inconsistent naming with CG methods for TR

Some of the KSPXXX macros for xxx had an inconsisten KSPCGXXX that was not in the string xxx name
The KSPCGXXX was used for KSPCreate_CGXXX() but the

Fixed inconsistent naming with CG methods for TR

Some of the KSPXXX macros for xxx had an inconsisten KSPCGXXX that was not in the string xxx name
The KSPCGXXX was used for KSPCreate_CGXXX() but the other method functions were missing the CG, for example, KSPSolve_XXX()
(these meant using tags to find functions was cumbersome due to the special cases)
Missing Fortran macro

Removed the extraneous CG from the macros and the function usage; now all macros and functions have consistent PETSc style usage
that match the string names
Added deprecation messages for out-dated use
Added new configure check for PETSC_DEPRECATED_MACRO

I decided to remove the CG from the KSPCGXXX instead of adding a cg to the string name because 1) it was not possible to deprecate
the string names at compile time, we would have to have runtime warnings. 2) the string names are shorter, 3) the stcg already
had a cg (at the end and not the beginning) and that would have to be removed or we'd have the absurd cgstcg. If starting from
sratch today not worrying about legacy I would have all the string names begin with cg consistently (and naturally the KSPXXX would
have them as well), but for legacy reasons we have the current naming which is not ideal because it does not clearly
indicate which methods are CG methods. (We have this problem with other subclasses in PETSc also).

Commit-type: style-fix

show more ...

Merge branch 'master' of bitbucket.org:petsc/petsc

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, t

Merge branch 'stefano_zampini/fix-tao-update-ctx' [PR #1443]

* stefano_zampini/fix-tao-update-ctx:
Few small fixes to Tao before the release.

- TAOSetUpdate: change the Update callback
In SNES, the update function does not uses contexts, and thus it does not appear in the callback prototype.
With TAO, since we are explcitily passing the ctx via TAOSetUpdate, we have to give it back to the user when performing the call

- Tao: PETSc does not print warnings

- MatAssembled: there's no point in checking the type
a matrix with type not set cannot be assembled

- TaoBNKEstimateActiveSet: Call MatHasOperation() only if the matrix has been assembled
the previous logic for MatGetDiagonal still holds. With this fix, the code will not error in case the hessian has not been assembled at this time

show more ...

TaoBNKEstimateActiveSet: Call MatHasOperation() only if the matrix has been assembled

the previous logic for MatGetDiagonal still holds
With this fix, the code will not error in case the hessian has

TaoBNKEstimateActiveSet: Call MatHasOperation() only if the matrix has been assembled

the previous logic for MatGetDiagonal still holds
With this fix, the code will not error in case the hessian has not been assembled at this time

show more ...

Merge from master

Merged petsc/petsc into master

Merge branch 'master' into knepley/fix-superdm-is

* master: (455 commits)
bib: spell out some names for format consistency with related refs
bib: two 2018 pubs now appeared
cleaning up analyze

Merge branch 'master' into knepley/fix-superdm-is

* master: (455 commits)
bib: spell out some names for format consistency with related refs
bib: two 2018 pubs now appeared
cleaning up analyzer warnings
compile fixes (workarround PGI bug?):
undoing the branch's changes to leastsquares outputs
more fixes for complex builds
compile error fix for complex builds
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix Pardiso code to only compile pardiso_init64 when needed, otherwise can generate warnings/errors
jenkins: run 'cleantest' before 'allgtest-tap' - an attempt to fix errors of type:
cuda: protect cuda includes
fix cuda warnings.
fix complex compile error
Revert "Improved polymorphism of interfaces for MatSetValuesBlocked()"
Bib: Updated ref
Doc: More function documentation
petscvec: move PetscSFCreateFromZero from vscat to vec sources
Fixed an uninitialized variable and got rid of an unused one.
memleak fixed and output files updated
fixing build errors on some archs
Mat: obey options prefix of Mat in MatNullSpaceTest
...

Conflicts:
include/petsc/private/dmpleximpl.h
src/dm/interface/dmi.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (281 commits)
compile fixes (workarround PGI bug?):
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix

Merge branch 'master' into knepley/feature-pc-patch

* master: (281 commits)
compile fixes (workarround PGI bug?):
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix Pardiso code to only compile pardiso_init64 when needed, otherwise can generate warnings/errors
jenkins: run 'cleantest' before 'allgtest-tap' - an attempt to fix errors of type:
cuda: protect cuda includes
fix cuda warnings.
fix complex compile error
Revert "Improved polymorphism of interfaces for MatSetValuesBlocked()"
Bib: Updated ref
Doc: More function documentation
petscvec: move PetscSFCreateFromZero from vscat to vec sources
Mat: obey options prefix of Mat in MatNullSpaceTest
Plex+SNES: Must pass user context through
vscat: move ftn-custom to correct location remove custom vecscatterdestroy_()
vscat: move interface routines to correct location
vscat: delete dead code
fix compile error
FE: Correct coordinates in IntegrateBd
Bib: Added refs
SNES ex17: 3D tests must require a 3D grid generator
Plex+TS: We cannot run the check with the same vector that is the TS solution
...

Conflicts:
include/petsc/private/dmpleximpl.h
src/docs/website/documentation/changes/dev.html
src/snes/examples/tutorials/ex13.c
src/snes/utils/dmplexsnes.c

show more ...

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (249 commits)
Bib: Added refs
Netcdf should always build netcdf-4 (needed for example by exodusii.
trivial fixes of incor

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (249 commits)
Bib: Added refs
Netcdf should always build netcdf-4 (needed for example by exodusii.
trivial fixes of incorrect formatting in SNES linesearch routines
ISSetBlockSize_General: removed blockwise contiguity check.
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
config prefix: avoid ad-hoc path substitutions
config/install: no need to rename paths for installBinDir
rules: fix path in (evidently unimportant) uncrustify target
config pkgconfig: use ${prefix} in PETSc.pc and do not modify in install
fix gcov obj path
Improved polymorphism of interfaces for MatSetValuesBlocked()
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
...

show more ...

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merged petsc/petsc into master

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'denera/petsc-submat-virtual-shift' [PR #1062]

* denera/petsc-submat-virtual-shift:
MatShift support for MATSUBMAT.

Tao Newton-LS method does shifting on the Hessian matrix to guarante

Merge branch 'denera/petsc-submat-virtual-shift' [PR #1062]

* denera/petsc-submat-virtual-shift:
MatShift support for MATSUBMAT.

Tao Newton-LS method does shifting on the Hessian matrix to guarantee positive-definitiveness in degenerate cases.
This shifting breaks down when the user-provided Hessian is matrix-free (MATSHELL), because the active-set reduced Hessian comes out as MATSUBMAT type, which does not support the shift operation.

This PR clones the virtual shift from MATSHELL onto MATSUBMAT.
New ex99 test added under the Mat package (copied from ex97) to compare shifted MATSUBMAT operations against shifted MATAIJ.
Previously implemented safeguards in TAO BNK against MATSUBMAT shifts removed.

show more ...

Missing CHKERRQ(); Mostly in Tao code

Commit-type: testing-fix,style-fix
Reported-by: clang static analyzer

MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.

Merged petsc/petsc into master

Merge branch 'denera/lmvm-symbrdn-scale-fix' [PR #1040]

Merge branch 'master' into knepley/feature-pc-patch

* master: (226 commits)
fix bib
type in bibtex entry
copy edits to bibtex items
Hypre matrix: small fix
Hypre matrix: fixed compiler war

Merge branch 'master' into knepley/feature-pc-patch

* master: (226 commits)
fix bib
type in bibtex entry
copy edits to bibtex items
Hypre matrix: small fix
Hypre matrix: fixed compiler warnings
Plex: Fixed missing PetscRealPart() in partition balance.
Added MatZeroEntries_HYPRE
Removed outdated mention of cusp and thrust from installations instructions; remove cusp from example configurations
Remove another location where fshift was used with -1 to indicate handling of error condition which was never handled
Generate an immediate error, if requested, if CG detects indefinite PC or Mat
Remove hack of using special fshift value of -1 to indicate error handling, was broken for MatSOR_SeqAIJ and did nothing constructive in the other cases
Options: Fix sys_tests-ex6 to not print options
PetscOptionsDestroy: Add missing free() call
Configure: Pragmatic now requires Cxx11
Error check that the communicator in the IS matches that in the matrix otherwise ISAllGather() produces incorrect results.
Options: Code reorganization and faster option lookup
fix compile warning
Doc: Fixed manpage for PCFieldSplitSetSchurPre()
mpiuni: build somempifort.o after mpiuni.mod
Remove use of common block from MPIUNI code
...

Conflicts:
include/petscdm.h
include/petscpc.h
include/petscpctypes.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexdistribute.c
src/ksp/pc/impls/makefile
src/ksp/pc/interface/pcregis.c

show more ...

Test updates and bug fixes:
- Added new tests for previously untested LMVM scaling types.
- Slightly changed MATSHELL safeguard on the Hessian to avoid shifts for all virtual inactive submats.
- Typo

Test updates and bug fixes:
- Added new tests for previously untested LMVM scaling types.
- Slightly changed MATSHELL safeguard on the Hessian to avoid shifts for all virtual inactive submats.
- Typo fixed in test flags and associated outputs updated.

show more ...

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod
Remove use of common block from MPIUNI code
use was in wrong location
Fortran line extends past 72 char
Moved the rest of the PETSc common block variables over to petscsys module
tests: fix breakage due to cd93b0e13c6da70ee1e038f55989cf888bc1d1c5
Need to use petscsys to get PETSC_COMM_SELF defined in example
Mat ex23 and ex40: fix errors reported from nightly tests
Put declaration on too lines because otherwise it generates an error for truncated line
Move PETSC_COMM_WORLD and PETSC_COMM_SELF from common blocks to petscsys module
tests: fix requires - and create out files for seqaijmkl tests
KSP ex72: nested dissection is likely to be different between machines
cmake: downgrade to version 3.9 - as newer versions require cxx11 compiler [which is not universal]. However stick with version 3.11 on opensolaris
Mat ex23: fix memory leaks
Bib: Some new refs
KSP examples: add missing casts to double in printf
updated GAMG KSP tests
PetscRound() should be PetscRoundReal() in __fp16
...

Conflicts:
include/petsclog.h
src/sys/logging/plog.c
src/sys/logging/utils/eventlog.c

show more ...

added safeguard for MATSHELL Hessians

Merge remote-tracking branch 'origin/denera/lmvm-mat-and-pc'