| #
c7fbd2bd
|
| 02-Feb-2024 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'barry/2024-01-19/typedef-snes-functions' into 'main'
add typedef for functions passed to SNESSetFunction() etc to match approach in TS
See merge request petsc/petsc!7206
|
| #
9bcc50f1
|
| 20-Jan-2024 |
Barry Smith <bsmith@mcs.anl.gov> |
add typedef for functions passed to SNESSetFunction() etc to match approach in TS
I never liked Jed's use of typedef for function prototypes for a couple of reasons
1) you don't see immediately tha
add typedef for functions passed to SNESSetFunction() etc to match approach in TS
I never liked Jed's use of typedef for function prototypes for a couple of reasons
1) you don't see immediately that the argument to the function is a function pointer instead of standard variable when looking at source 2) you don't see at the exact location in the code the prototype of the function being passed in
but there is something to say for using these typedefs so
I've prototyped the change for SNES but slightly differently than what Jed did for TS
1) I append the typedef with _Ftn to mark that it is a function (helping to relieve the problem 1 above) 2) I made the typedef to be for a function, not a function pointer so it can also be used directly for things like
PETSC_EXTERN SNESJacobian_Ftn SNESComputeJacobianDefault;
I think the TS usage could be switched to this style without user code breakage, and deprecate the current TS typedef
Thoughts?
Just do SNES the same way as TS and live with less clarity?
show more ...
|
| #
9c5460f9
|
| 17-Aug-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jacobf/2023-08-09/linter-detect-static-function-candidates' into 'main'
Linter detect possible static functions
See merge request petsc/petsc!6796
|
| #
66976f2f
|
| 14-Aug-2023 |
Jacob Faibussowitsch <jacob.fai@gmail.com> |
Add static to internal functions
|
| #
49154744
|
| 22-Apr-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge remote-tracking branch 'origin/release'
|
| #
d7849d59
|
| 20-Apr-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jolivet/fix-petsccallmpi' into 'release'
Fix PetscCallMPI(MPI_Allreduce()) with PETSc types
See merge request petsc/petsc!6348
|
| #
712fec58
|
| 19-Apr-2023 |
Pierre Jolivet <pierre@joliv.et> |
Fix PetscCallMPI(MPI_Allreduce()) with PETSc types
|
| #
d01c6957
|
| 28-Mar-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'barry/2023-03-25/fix-more-manualpages' into 'main'
More manual page fixes
See merge request petsc/petsc!6233
|
| #
2fe279fd
|
| 28-Mar-2023 |
Barry Smith <bsmith@mcs.anl.gov> |
More manual page fixes
|
| #
e9f36840
|
| 18-Mar-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'barry/2023-03-08/fix-man-pages-detected-by-lint' into 'main'
Fix many manual pages
See merge request petsc/petsc!6162
|
| #
20f4b53c
|
| 09-Mar-2023 |
Barry Smith <bsmith@mcs.anl.gov> |
Fix manual pages based on reports from Jacob's lint tool
Commit-type: documentation
|
| #
31d78bcd
|
| 02-Feb-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'
Feature: Non-discardable PetscErrorCode
See merge request petsc/petsc!5923
|
| #
3ba16761
|
| 10-Dec-2022 |
Jacob Faibussowitsch <jacob.fai@gmail.com> |
Make PetscErrorCode a non-discardable enum
|
| #
1ea65430
|
| 04-Jan-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge remote-tracking branch 'origin/release'
|
| #
a41402af
|
| 04-Jan-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jolivet/fix-typo' into 'release'
Winter cleaning
See merge request petsc/petsc!5948
|
| #
35cb6cd3
|
| 30-Dec-2022 |
Pierre Jolivet <pierre@joliv.et> |
Fix some typos
|
| #
e3dbaa52
|
| 29-Nov-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge remote-tracking branch 'origin/release'
|
| #
3d996455
|
| 29-Nov-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'barry/2022-11-17/fix-collective-on-man-pages/release' into 'release'
Remove unneeded " on xxx" from most Collective comments in manual pages; move no Fortran support to Collective line
Merge branch 'barry/2022-11-17/fix-collective-on-man-pages/release' into 'release'
Remove unneeded " on xxx" from most Collective comments in manual pages; move no Fortran support to Collective line
See merge request petsc/petsc!5850
show more ...
|
| #
c3339dec
|
| 17-Nov-2022 |
Barry Smith <bsmith@mcs.anl.gov> |
Remove unneeded " on xxx" from most Collective comments in manual pages
The phrase was unneeded 99% of the time
I did not remove in the dm directory since another MR is still active that affects th
Remove unneeded " on xxx" from most Collective comments in manual pages
The phrase was unneeded 99% of the time
I did not remove in the dm directory since another MR is still active that affects that directory
Commit-type: documentation /spend 20m
show more ...
|
| #
061e922f
|
| 22-Sep-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'
Feature: Bicycle Storage Facility 2
See merge request petsc/petsc!5661
|
| #
d71ae5a4
|
| 21-Sep-2022 |
Jacob Faibussowitsch <jacob.fai@gmail.com> |
source code format changes due to .clang-format changes
|
| #
b7124133
|
| 20-Sep-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jacobf/2022-09-17/slimmer-petscobject' into 'main'
Feature: Slimmer PetscObject
See merge request petsc/petsc!5649
|
| #
4dfa11a4
|
| 17-Sep-2022 |
Jacob Faibussowitsch <jacob.fai@gmail.com> |
Remove parent, parentid, flops, time, mem, and memchildren. Deprecate PetscLogObjectParent(), PetscLogObjectMemory(), and PetscNewLog()
|
| #
f0af967e
|
| 29-Aug-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jolivet/fix-style-one-liners' into 'main'
Remove braces from one-liners w/o PetscCall()
See merge request petsc/petsc!5561
|
| #
ad540459
|
| 29-Aug-2022 |
Pierre Jolivet <pierre@joliv.et> |
Remove braces from one-liners w/o PetscCall()
|