Merge branch 'denera/tao-residual-setter-fix' [PR #1182]

* denera/tao-residual-setter-fix:
Tao Residual and Residual-Jacobian setter function bug fix
Order of INCREF and destroy operations fixed, an

Merge branch 'denera/tao-residual-setter-fix' [PR #1182]

* denera/tao-residual-setter-fix:
Tao Residual and Residual-Jacobian setter function bug fix
Order of INCREF and destroy operations fixed, and other Tao setter functions reviewed for correctness.
Function name changed from TaoSetResidualJacobianRoutine() to TaoSetJacobianResidualRoutine() to match the pattern of other Jacobian setters.

For more detail, see: https://bitbucket.org/petsc/petsc/commits/737f463ab30e8a11bf8f036b04a75b5d358c645b#comment-6707469

show more ...

Fixes applied per Lisandro's comments on commit 737f463:
- Order of INCREF and destroy operations fixed, and other Tao setter functions reviewed for correctness.
- Function name changed from `TaoSetR

Fixes applied per Lisandro's comments on commit 737f463:
- Order of INCREF and destroy operations fixed, and other Tao setter functions reviewed for correctness.
- Function name changed from `TaoSetResidualJacobianRoutine()` to `TaoSetJacobianResidualRoutine()` to match the pattern of other Jacobian setters.

show more ...

Merge branch 'denera/tao-gauss-newton-wrapper' [PR #1151]

* denera/tao-gauss-newton-wrapper:
Regularized Gauss-Newton algorithm/wrapper
New BRGN algorithm added for regularized Gauss-Newton formulat

Merge branch 'denera/tao-gauss-newton-wrapper' [PR #1151]

* denera/tao-gauss-newton-wrapper:
Regularized Gauss-Newton algorithm/wrapper
New BRGN algorithm added for regularized Gauss-Newton formulation.
This algorithm is a thin wrapper that relies on TaoSetResidualRoutine() and TaoSetResidualJacobianRoutine() interfaces to accept the residual and Jacobian associated with a least-squares problem,
and then construct the internal objective, gradient and Hessian evaluation functions for the regularized problem formulation.
Currently only Tikhonov regularization is available, but other smooth regularizers are planned in the future.
The resulting regularized problem is passed onto an existing bound-constrained algorithm (e.g.: BQNLS or BNTL), controlled by the -tao_brgn_subsolver flag.

show more ...

Regularization changed to x-x_old, user hook added into optimization loops, eliminated explicit MatTransposeMatMult option in Hessian computation

Added the gauss-newton algorithm wrapper

Merge from master

Merged petsc/petsc into master

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (345 commits)
Update dev notes for the coming release
Increase patchlevel to 3.9.4
doc fixes
Added some AIJSELL tests t

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (345 commits)
Update dev notes for the coming release
Increase patchlevel to 3.9.4
doc fixes
Added some AIJSELL tests that mirror the SELL tests.
Bib: More refs
Removed use of hardwired -1 to represent PETSC_NULL_XXX object, since the null value is now 0.
fix memleaks flagged by valgrind
ex62: disable long running test and workaround differences in iteration counts on various builds.
Add FAQ we can point to when users get error messages such as: "PETSc was configured with one OpenMPI mpi.h version but now appears to be compiling using a different OpenMPI mpi.h version"
swith test from mpich to openmpi as mpich ch3:sock is unuserable per PetscShmCommGet()
DM: Forgot to move include statement
fix nightlybuild issues - disable hypre [for openmp] and fix uninitialized variables
tests: enable openmp and hwloc with one of the mumps tests
Default BoomerAMG smoothers
Configure: Revert changes from debb90c, so that we are back to the original Libmesh
Configure: Reverted change for Libmesh from 83cd5d7
Split vecimpl.h into vecimpl.h and vecscatterimpl.h
SNES ex62: Turned off some tests for other precisions and shortened output of sensitive tests
Use mmap to allocate the shared pthread barrier if available
Add configure test for functional mmap
...

Conflicts:
include/petscconvest.h
src/snes/examples/tutorials/ex13.c
src/snes/interface/snes.c
src/snes/utils/convest.c

show more ...

Merge branch 'master' into knepley/fix-superdm-is

* master: (123 commits)
Fix a few more Fortran objects to have their NULL value match the C NULL value
remove dead code
Add variable point blo

Merge branch 'master' into knepley/fix-superdm-is

* master: (123 commits)
Fix a few more Fortran objects to have their NULL value match the C NULL value
remove dead code
Add variable point block Jacobi for MPIAIJ matrix.
should not pass user contexts through CHKFORTRANNULLOBJECT in Fortran stubs
fix mpiuni test
Remove CHKFORTRANNULLOBJECTDEREFERENCE since it is no longer needed with Fortran null equal to C null
PETSCFEOPENCL: declare PetscFEGetTabulation_Basic as external
PETSCFEOPENCL: declare PetscFESetUp_Basic as external
Change Fortran null pointer to match C null pointer
one more fix
jenkins: run 'cleantest' after examples are run - to recover diskspace
logical order bug in diagbrdn update fixed, tests updated again
replace new -petscspace_order instances with -petscspace_degree
PETSCSPACETENSOR: clear up naming confusion of subspaces
regression.py: remove configure code related to old test suite - now that SLEPc no longer needs it
PetscSpaceSetup_Poly(): make idempotent
Plex ex3: update tests
Lift changes to defunct dtfe.c from [PR #1074]
PetscSpace_Tensor: clarification of vector-valued
PetscSpace_Tensor: allow height subspaces, fixes tabulation initialization
...

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master:
Add variable point block Jacobi for MPIAIJ matrix.
should not pass user contexts through CHKFORTRANNULLOBJECT in Fortran stubs
Rem

Merge branch 'master' into knepley/feature-pc-patch

* master:
Add variable point block Jacobi for MPIAIJ matrix.
should not pass user contexts through CHKFORTRANNULLOBJECT in Fortran stubs
Remove CHKFORTRANNULLOBJECTDEREFERENCE since it is no longer needed with Fortran null equal to C null
Change Fortran null pointer to match C null pointer

Conflicts:
src/ksp/ksp/interface/itfunc.c

show more ...

Merge remote-tracking branch 'origin/barry/change-fortran-null'

should not pass user contexts through CHKFORTRANNULLOBJECT in Fortran stubs

Commit-type: bug-fix
Reported-by: jenkins

Merged petsc/petsc into master

Merge branch 'master' into knepley/fix-superdm-is

* master: (455 commits)
bib: spell out some names for format consistency with related refs
bib: two 2018 pubs now appeared
cleaning up analyze

Merge branch 'master' into knepley/fix-superdm-is

* master: (455 commits)
bib: spell out some names for format consistency with related refs
bib: two 2018 pubs now appeared
cleaning up analyzer warnings
compile fixes (workarround PGI bug?):
undoing the branch's changes to leastsquares outputs
more fixes for complex builds
compile error fix for complex builds
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix Pardiso code to only compile pardiso_init64 when needed, otherwise can generate warnings/errors
jenkins: run 'cleantest' before 'allgtest-tap' - an attempt to fix errors of type:
cuda: protect cuda includes
fix cuda warnings.
fix complex compile error
Revert "Improved polymorphism of interfaces for MatSetValuesBlocked()"
Bib: Updated ref
Doc: More function documentation
petscvec: move PetscSFCreateFromZero from vscat to vec sources
Fixed an uninitialized variable and got rid of an unused one.
memleak fixed and output files updated
fixing build errors on some archs
Mat: obey options prefix of Mat in MatNullSpaceTest
...

Conflicts:
include/petsc/private/dmpleximpl.h
src/dm/interface/dmi.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (281 commits)
compile fixes (workarround PGI bug?):
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix

Merge branch 'master' into knepley/feature-pc-patch

* master: (281 commits)
compile fixes (workarround PGI bug?):
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix Pardiso code to only compile pardiso_init64 when needed, otherwise can generate warnings/errors
jenkins: run 'cleantest' before 'allgtest-tap' - an attempt to fix errors of type:
cuda: protect cuda includes
fix cuda warnings.
fix complex compile error
Revert "Improved polymorphism of interfaces for MatSetValuesBlocked()"
Bib: Updated ref
Doc: More function documentation
petscvec: move PetscSFCreateFromZero from vscat to vec sources
Mat: obey options prefix of Mat in MatNullSpaceTest
Plex+SNES: Must pass user context through
vscat: move ftn-custom to correct location remove custom vecscatterdestroy_()
vscat: move interface routines to correct location
vscat: delete dead code
fix compile error
FE: Correct coordinates in IntegrateBd
Bib: Added refs
SNES ex17: 3D tests must require a 3D grid generator
Plex+TS: We cannot run the check with the same vector that is the TS solution
...

Conflicts:
include/petsc/private/dmpleximpl.h
src/docs/website/documentation/changes/dev.html
src/snes/examples/tutorials/ex13.c
src/snes/utils/dmplexsnes.c

show more ...

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (249 commits)
Bib: Added refs
Netcdf should always build netcdf-4 (needed for example by exodusii.
trivial fixes of incor

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (249 commits)
Bib: Added refs
Netcdf should always build netcdf-4 (needed for example by exodusii.
trivial fixes of incorrect formatting in SNES linesearch routines
ISSetBlockSize_General: removed blockwise contiguity check.
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
config prefix: avoid ad-hoc path substitutions
config/install: no need to rename paths for installBinDir
rules: fix path in (evidently unimportant) uncrustify target
config pkgconfig: use ${prefix} in PETSc.pc and do not modify in install
fix gcov obj path
Improved polymorphism of interfaces for MatSetValuesBlocked()
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
...

show more ...

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merged petsc/petsc into master

Merge branch 'denera/tao-custom-monitor-bugfix' [PR #1045]

* denera/tao-custom-monitor-bugfix:
Originally started to fix a segfault in user-defined monitor destroy function.
Work expanded to improve

Merge branch 'denera/tao-custom-monitor-bugfix' [PR #1045]

* denera/tao-custom-monitor-bugfix:
Originally started to fix a segfault in user-defined monitor destroy function.
Work expanded to improve all the custom Fortran interface functions to use PetscObjectSetFortranCallback() and PetscObjectGetFortranCallback() instead of handling function pointers manually.
Also found and fixed an incorrect handling of duplicate monitors in TaoSetMonitor().
New test added to make sure user-monitor functionality is tested in Fortran.

show more ...

Fixed segfault for user-defined monitor destroy function in Fortran.

Tao custom Fortran interfaces overhauled to use Petsc callback functions instead of handling function pointers manually.

Duplica

Fixed segfault for user-defined monitor destroy function in Fortran.

Tao custom Fortran interfaces overhauled to use Petsc callback functions instead of handling function pointers manually.

Duplicate monitor handling corrected in TaoSetMonitor() routine.

show more ...

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...