Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge branch 'barry/2019-10-16/use-error-codes' into 'master'

Replace use of 1 with appropriate error code; use PetscObjecComm() instead of...

See merge request petsc/petsc!2182

Replace use of 1 with appropriate error code; use PetscObjecComm() instead of PETSC_COMM_SELF for errors when appropriate

Commit-type: error-checking, testing-fix, style-fix, examples

Merged in barry/optimize-aij-da (pull request #1762)

Non-numeric optimizations focused on AIJ, MatFDColoring, and DMCreateMatrix_DA_*AIJ, looking to improve performance in GPU environments

Non-numeric optimizations focused on AIJ, MatFDColoring, and DMCreateMatrix_DA_*AIJ, looking to improve performance in GPU environments

1) PetscCalloc*() now uses system calloc()
2) Merged some Pets

Non-numeric optimizations focused on AIJ, MatFDColoring, and DMCreateMatrix_DA_*AIJ, looking to improve performance in GPU environments

1) PetscCalloc*() now uses system calloc()
2) Merged some PetscMalloc*()
3) Eliminated unneeded PetscCalloc*()
4) Removed some memory allocations and copies in MatFDColoringSetUp(), added local variables for better compiler optimization
5) Added MatSetValues_SeqAIJ_SortedFull(), added MatSetOption(MAT_SORTED_FULL)
6) Optimized DMCreateMatrix_DA_*AIJ for nonperiodic case to automatically have sorted columns (faster MatSetValues() times)
7) Eliminated call to PetscMemzero() in PetscFree()

Commit-type: style-fix, feature

show more ...

Merged petsc/petsc into master

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (226 commits)
fix bib
type in bibtex entry
copy edits to bibtex items
Hypre matrix: small fix
Hypre matrix: fixed compiler war

Merge branch 'master' into knepley/feature-pc-patch

* master: (226 commits)
fix bib
type in bibtex entry
copy edits to bibtex items
Hypre matrix: small fix
Hypre matrix: fixed compiler warnings
Plex: Fixed missing PetscRealPart() in partition balance.
Added MatZeroEntries_HYPRE
Removed outdated mention of cusp and thrust from installations instructions; remove cusp from example configurations
Remove another location where fshift was used with -1 to indicate handling of error condition which was never handled
Generate an immediate error, if requested, if CG detects indefinite PC or Mat
Remove hack of using special fshift value of -1 to indicate error handling, was broken for MatSOR_SeqAIJ and did nothing constructive in the other cases
Options: Fix sys_tests-ex6 to not print options
PetscOptionsDestroy: Add missing free() call
Configure: Pragmatic now requires Cxx11
Error check that the communicator in the IS matches that in the matrix otherwise ISAllGather() produces incorrect results.
Options: Code reorganization and faster option lookup
fix compile warning
Doc: Fixed manpage for PCFieldSplitSetSchurPre()
mpiuni: build somempifort.o after mpiuni.mod
Remove use of common block from MPIUNI code
...

Conflicts:
include/petscdm.h
include/petscpc.h
include/petscpctypes.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexdistribute.c
src/ksp/pc/impls/makefile
src/ksp/pc/interface/pcregis.c

show more ...

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod
Remove use of common block from MPIUNI code
use was in wrong location
Fortran line extends past 72 char
Moved the rest of the PETSc common block variables over to petscsys module
tests: fix breakage due to cd93b0e13c6da70ee1e038f55989cf888bc1d1c5
Need to use petscsys to get PETSC_COMM_SELF defined in example
Mat ex23 and ex40: fix errors reported from nightly tests
Put declaration on too lines because otherwise it generates an error for truncated line
Move PETSC_COMM_WORLD and PETSC_COMM_SELF from common blocks to petscsys module
tests: fix requires - and create out files for seqaijmkl tests
KSP ex72: nested dissection is likely to be different between machines
cmake: downgrade to version 3.9 - as newer versions require cxx11 compiler [which is not universal]. However stick with version 3.11 on opensolaris
Mat ex23: fix memory leaks
Bib: Some new refs
KSP examples: add missing casts to double in printf
updated GAMG KSP tests
PetscRound() should be PetscRoundReal() in __fp16
...

Conflicts:
include/petsclog.h
src/sys/logging/plog.c
src/sys/logging/utils/eventlog.c

show more ...

Merge branch 'master' into denera/lmvm-mat-and-pc

Merged in dalcinl/extern (pull request #995)

Fix extern declarations

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

TAO: Fix 'extern' declarations

- Rename events following naming conventions in other packages
- Fix extern -> PETSC_EXTERN

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead code.
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
...

Conflicts:
src/snes/examples/tutorials/ex13.c

show more ...

Merge remote-tracking branch 'origin/knepley/fix-snes-ex69' into tisaac/feature-dmfield

* origin/knepley/fix-snes-ex69: (311 commits)
PetscFECreateDefault: fix custom Fortran interface to use MPI_

Merge remote-tracking branch 'origin/knepley/fix-snes-ex69' into tisaac/feature-dmfield

* origin/knepley/fix-snes-ex69: (311 commits)
PetscFECreateDefault: fix custom Fortran interface to use MPI_Comm
SNES ex69: Updated test output
SNES ex69: Removed all mantle stuff and change fields to constants - Also use dsymutil for executables
SNES ex69: Removed special partition
SNES ex69: Fixed null space creation - Null space locks its vectors
PetscFE: PetscFECreateDefault() now takes MPI_Comm instead of DM
cleanup very ugly PCGAMG manual page
minor clarifications for VecScatterCreate() manual page
gcov: PETSC_ARCH is required onlyfor -run_gcov - and not for -merge_gcov [where it doesn't exist]
make clearer in help statements what --with-external-packages-dir is for.
Website: Added news entry for PETSc User Meeting 2018 on main page.
CUDA: Further test output fixes for mat_tests-ex2
Turn off elemental test for parmetis running since this does not work on batch systems.
3.8 Changes: KSPCHEBYSHEV
CUDA: Fixed most test errors due to MatMultTranspose*
website: update urls
website: fix Jason's name to match pic. Also add Todd's pic
Dev manual: copyedit
DMPlexDistributeLabels: Propagate the output flag
cuda/cusp: update minimum supported versions of cuda to 7.5 and cusp to 0.5.0
...

show more ...

Merge branch 'barry/refactor-matshell'

Begin refactorization of MatShell to make the code more straightforward and extensible

Introduce MatSetOperation() for changing operations on non-MATSHELLs
Introduce two modes for MATSHELL
1) MAT

Begin refactorization of MatShell to make the code more straightforward and extensible

Introduce MatSetOperation() for changing operations on non-MATSHELLs
Introduce two modes for MATSHELL
1) MATSHELL manages scalings and shifts automatically
2) Creator of MATSHELL can provide their own code for managing scaling and shifts
This is used by MatCreateADA() and MatCreateSubMatrixFree()

The extensibility is so that a MatShell can be easily used in as many places as possible as other matrices,
for example,

/* A = diag(u) G */
ierr = MatCopy(appctx->SEMop.grad,A,SAME_NONZERO_PATTERN);CHKERRQ(ierr);
ierr = MatDiagonalScale(A,globalin,NULL);CHKERRQ(ierr);
/* A = A + diag(Gu) */
ierr = VecDuplicate(globalin,&Gglobalin);CHKERRQ(ierr);
ierr = MatMult(appctx->SEMop.grad,globalin,Gglobalin);CHKERRQ(ierr);
ierr = MatDiagonalSet(A,Gglobalin,ADD_VALUES);CHKERRQ(ierr);
ierr = VecDestroy(&Gglobalin);CHKERRQ(ierr);
/* A = K - A */
ierr = MatScale(A,-1.0);CHKERRQ(ierr);
ierr = MatAXPY(A,1.0,appctx->SEMop.keptstiff,SAME_NONZERO_PATTERN);

Commit-type: feature

show more ...

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-torus

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stages

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-torus

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stages
update to latest hypre tag on github
fix 'inf' vs 'Inf' diff wrt vec_vec_utils_tagger_tutorials-ex1_8,9,18,19
MatSetOption(mat,MAT_IGNORE_ZERO_ENTRIES,PETSC_TRUE) no longer applies to zero values set or added to the matrix diagonal, they are now not ignored and are included in the matrix nonzero structure. This is useful for Jacobians passed to TS.
replace use/mention of depreciated -log_summary in many places
add extchem.py which was written years ago but never put in the distribution (hence it is broken).
petsc4py: update to snapshot with MatGetSubMatrices -> MatCreateSubMatrices etc API changes
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
PetscCMPLX: assume type punning is safe
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
...

Conflicts:
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/examples/tests/ex12.c

show more ...

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-tests-new

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stag

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-tests-new

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stages
update to latest hypre tag on github
fix 'inf' vs 'Inf' diff wrt vec_vec_utils_tagger_tutorials-ex1_8,9,18,19
MatSetOption(mat,MAT_IGNORE_ZERO_ENTRIES,PETSC_TRUE) no longer applies to zero values set or added to the matrix diagonal, they are now not ignored and are included in the matrix nonzero structure. This is useful for Jacobians passed to TS.
replace use/mention of depreciated -log_summary in many places
add extchem.py which was written years ago but never put in the distribution (hence it is broken).
petsc4py: update to snapshot with MatGetSubMatrices -> MatCreateSubMatrices etc API changes
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
PetscCMPLX: assume type punning is safe
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
...

Conflicts:
src/dm/impls/plex/examples/tests/ex12.c

show more ...

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
superlu: libray is installed in PREFIX/lib64 - fix this to use PREFIX/lib
backport fixes cc105cc3 2b35c90a - required for 3bf428d - that was backported from master - 80c96bb
'echo -n' fails on opensolaris/osx - so avoid using it.
fix diffs in nightlybuilds due to options in ~/.petscrc
add Kelley03 to src/docs/tex/petsc.bib
build: determine moudles, mpi.h used during buildtime and print in 'info'
fix analyzer warnings
fix build failure on opensolaris - where -lm from flibs is removed due to -lm in cxxlibs. But then - only flib gets used for some configure tests [blaslapack, parms]
config: prefer __restrict over C99 restrict keyword
...

show more ...

Merge branch 'master' of bitbucket.org:petsc/petsc

Merge remote-tracking branch 'origin/hzhang/rename_matgetsubmats'