Update badsource rules

- Zero or more spaces are not allowed for more returning types
- zero spaces not allowed for for|if|while

Merge branch 'stefanozampini/fix-tsadapt-nostore' into 'master'

TSAdapt: no need to keep a working vector in the struct

See merge request petsc/petsc!3169

TSAdapt: no need to keep a working vector in the struct

just use DM accessors.
Not sure if we can move the glee->Y stuff up to the TSGLEE method.

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merged in emil/ts-adapt-glee-min-clip (pull request #1593)

Add TSAdapt option to ignore solution components with values smaller than a specified one; add TSAdapt option for TSGLEE to use local error

Merged in emil/ts-adapt-glee-min-clip (pull request #1593)

Add TSAdapt option to ignore solution components with values smaller than a specified one; add TSAdapt option for TSGLEE to use local error estimates for local error control

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

show more ...

adding support for GLEE methods to use local error controler when using GLEE adaptor; add testing with ex31.c; adding max ignore in the error calculation

adding support for GLEE methods to use local

adding support for GLEE methods to use local error controler when using GLEE adaptor; add testing with ex31.c; adding max ignore in the error calculation

adding support for GLEE methods to use local error controler when using GLEE adaptor; add testing with ex31.c; adding max ignore in the error calculation

fixing some example output to match the new TSAdapt Viewer

correcting some hardwired values and adding a macro for repeated code

show more ...

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead code.
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
...

Conflicts:
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'barry/move-to-new-test-harness' into barry/all-new-test-harness-branches

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (251 commits)
yaml: add a backup download URL
Fix documentation of MatSetRandom function
Ignore -malloc-hbw option if m

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (251 commits)
yaml: add a backup download URL
Fix documentation of MatSetRandom function
Ignore -malloc-hbw option if malloc is already set
Plex: Fixed array initialization
pgi: compile fix
knl: update test to use memkind and remove option that worked arround a bug with intel 17
Check the return value for memkind_posix_memalign
Change the default behavour for -malloc_hbw
Bib: More refs
test: remove runex13f90 as its now converted to new test suite
fix win32 crash. This test was previously run with '-n 4' - so restoring it
Fix petscsfgetgraph_ to work for all Fortran compilers by directly using array of PetscSFNodes
bugfix for MatDuplicate_MPIAIJ_PtAP Reported-by: Samuel Lanthaler <s.lanthaler@gmail.com>
strip out dead sundials usage code; change sundials test to only run 5 timesteps to prevent different number of steps on different systems.
Remove extra lines of output file
Example uses C99 constructs so must mark with requires: c99
fix const missmatch for DMDAVecRestoreArrayRead()
remove conflict between function name in example and new PETSc TS function
builds: attempt to do maint/master/next test builds in separate clones
ex62: it turned out that CHACO partioning is not deterministic. Use a prescribed partition instead
...

Conflicts:
src/dm/interface/dm.c
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with updated 17.10 compilers
Fix for test dirs that are not tutorials/tests
fix use of double in PetscAbsReal() which produces compiler warnings with single precision build
elemental: remove info on conflict of -with-cxx-dialect=C++11 on osx - it works now.
Cleanup .bib files
Fix allfortranstubs rule to rm generated files from correct directory, not outdated location
ierr set but not checked
Remove initial refine so test runs faster and does not time out on some machines
Gail's copyedits for bibtex items
Docs: manual: add further description of 3 different current testing options
DM: check for ops->localtolocalbegin/end before calling
PetscSF: fix typo in tutorial ex1
Vec+HDF5: Fix output for complex - Need to check for empty group name
SNES: SNESDestroy() can be called with snes->dm == NULL
SNES: SNESDestroy() can be called with snes->dm == NULL
Vec+HDF5: Fix output for complex - Need to check for empty group name
Docs: Manual: Update tests section
gmakegentest: also exclude .#filenames created by emacs
DMPlex: Fix output of test ex1 after changes to Gmsh reader
...

show more ...

Merge remote-tracking branch 'origin/maint'

Fix typos and whitespaces already fixed in stefano_zampini/feature-continuousadjoint

Merged in dalcinl/ts-solve (pull request #722)

Proper support for successive TSSolve() calls

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

TS: Add TSGetStepNumber() and TSSetStepNumber()

* Remove TSGetTotalSteps()
* Remove TSGetTimeStepNumber()

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Merge branch 'scott/test-datafiles-fix' of https://bitbucket.org/petsc/petsc into scott/test-datafiles-fix

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'master' into stefano_zampini/feature-fetidp-ex69

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]' to showup in '-help' Reported-by: Mark Adams <mfadams@lbl.gov>
Plex: Remove dead code
TS tutorials ex11: remove unused functions
TSAdapt: Set TSADAPTNONE as default adapt type
DMPlex: missed viewer change in synchronized output
Revert "Merge branch 'hzhang/ts-ex9busdmnetwork'"
TSAdapt: Update changes/dev.html
TSAdapt: Set default type for TSGLEE
TS tutorials ex11: make work with complex scalars
Bib: Added ref
TS ex18: Fix initializer
TS ex11: Fix M_PI
Plex ex1f90: FUCK FORTRAN
f2cblaslapack: remove duplicate xerbla.o and xerbla_array.o from lapack [they are already in blas]
TSAdapt: Refactor handling of default adapt type
TSAdapt: Update changes/dev.html
TSAdapt: Update manual
TSAdapt: Refactor interface and implementations
...

show more ...

Merged in dalcinl/refactor-ts-adapt (pull request #669)

TSAdapt: Refactor interface and implementations

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

TSAdapt: Refactor interface and implementations

* Move the handling of step limits, clipping factors, and safety factors
to the base TSAdapt type to simplify implementation of subtypes.
* Add TSAd

TSAdapt: Refactor interface and implementations

* Move the handling of step limits, clipping factors, and safety factors
to the base TSAdapt type to simplify implementation of subtypes.
* Add TSAdapt{Set|Get}Clip() and remove TSAdaptBasic{Set|Get}Clip().
* Add TSAdapt{Set|Get}Safety() to set safety factors.
* Add TSAdaptGetStepLimits().

show more ...

Merge branch 'master' into knepley/feature-plex-torus

* master: (174 commits)
Bib: Another ref
Increase patchlevel to 3.7.6
Explicitly listing the LTO library causes difficulties on MacOS so a

Merge branch 'master' into knepley/feature-plex-torus

* master: (174 commits)
Bib: Another ref
Increase patchlevel to 3.7.6
Explicitly listing the LTO library causes difficulties on MacOS so avoid it
TSBDF: Update changes/dev.html
Added Fortran TaoType and TaoLineSearchType definitions
Add Fortran TaoType and TaoLineSearchType definitions
setblocksize for iscol_sub
TSBDF: Use standard TS API and options to control adaptivity
Bib: More refs and a correction
SNESTest: Bug-fix in SNESTest when threshold printing option is turned on.
fix warning and valgrind complains reported by the nightly tests
Section+Doc: Small doc fix
pflotran: switch to using the new upstream git repo
DMPlex: Error if attempt to partition a distributed graph with Chaco
fix complex build error
fix complex build
PetscError() did not properly copy over the specific error message when error type was PETSC_ERROR_INITIAL
TSAdapt: Refactor handling of the always_accept flag
Additional clarification for MatMeshToCellGraph() manual page
optimize MatCreateSubMatrix_MPIAIJ() by merging check of sameXXXDist() into one MPI_AllReduce
...

Conflicts:
config/BuildSystem/config/packages/med.py

show more ...

Merge branch 'dalcinl/fix-bdf-adapt' into barry/update-petscfileretrieve

Merged in dalcinl/refactor-ts-adapt (pull request #665)

TSAdapt: Refactor handling of the always_accept flag

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>
Approved-by: Jed Brown <jed@59a2.org>