Make PetscErrorCode a non-discardable enum

Merge remote-tracking branch 'origin/release'

Merge branch 'barry/2022-11-17/fix-collective-on-man-pages/release' into 'release'

Remove unneeded " on xxx" from most Collective comments in manual pages; move no Fortran support to Collective line

Merge branch 'barry/2022-11-17/fix-collective-on-man-pages/release' into 'release'

Remove unneeded " on xxx" from most Collective comments in manual pages; move no Fortran support to Collective line

See merge request petsc/petsc!5850

show more ...

Remove unneeded " on xxx" from most Collective comments in manual pages

The phrase was unneeded 99% of the time

I did not remove in the dm directory since another MR is still active that affects th

Remove unneeded " on xxx" from most Collective comments in manual pages

The phrase was unneeded 99% of the time

I did not remove in the dm directory since another MR is still active that affects that directory

Commit-type: documentation
/spend 20m

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'barry/2022-10-16/fix-ts-man-pages/release' into 'release'

Clean up ts manual pages

See merge request petsc/petsc!5748

Clean up ts manual pages

To be safe I am triggering a full test even though this was intended to be docs-only

Commit-type: documentation
/spend 4h

Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

source code format changes due to .clang-format changes

Merge branch 'jacobf/2022-09-17/slimmer-petscobject' into 'main'

Feature: Slimmer PetscObject

See merge request petsc/petsc!5649

Remove parent, parentid, flops, time, mem, and memchildren. Deprecate PetscLogObjectParent(), PetscLogObjectMemory(), and PetscNewLog()

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

clang-format: convert PETSc sources to comply with clang-format

Merge branch 'barry/2022-06-28/add-petsccallmethod' into 'main'

Introduce PetscTryTypeMethod and PetscUseTypeMethod to replace ad hoc use of (*obj->ops->method) in source

See merge request petsc/

Merge branch 'barry/2022-06-28/add-petsccallmethod' into 'main'

Introduce PetscTryTypeMethod and PetscUseTypeMethod to replace ad hoc use of (*obj->ops->method) in source

See merge request petsc/petsc!5376

show more ...

Convert setfromoptions methods over to PetscTryTypeMethod() approach

Flipped the order of the arguments for the function pointers (*setfromoptions)(PetscOptionItem*,obj); and friends to make them co

Convert setfromoptions methods over to PetscTryTypeMethod() approach

Flipped the order of the arguments for the function pointers (*setfromoptions)(PetscOptionItem*,obj); and friends to make them consistent with PetscTryTypeMethod() and all the other methods

Commit-type: refactorization
/spend 4h

show more ...

Merge branch 'wence/petsc-check-do-while' into 'main'

Wrap PetscCheck and PetscAssert in do { } while (0)

Closes #1199

See merge request petsc/petsc!5291

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these macros being "if (...)
statement_without_semicolon". Fixes #1199.

show more ...

Merge branch 'barry/2022-06-13/make-one-line-if-call' into 'main'

Change if () { PetscCall() } three liner to one liner

See merge request petsc/petsc!5344

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$[ ]*}\$?\1if (\2) PetscCall(\3$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

for i in `git ls-files | grep "\.[hc]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ }else]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$\([ ]*\)} \([- ._+=a-z0-9A-Z>*,()]*);\)\$?\1if (\2) PetscCall(\3$\4\5$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

Yes, really ugly but Barry still cannot master awk

Commit-type: housekeeping

show more ...

Merge branch 'stefanozampini/fix-function-composition' into 'main'

fix function composition

See merge request petsc/petsc!5274

PetscObjectFunctionCompose: clean up composed functions at Destroy time

Merge branch 'psanan/docs-sphinx-man-pages' into 'main'

Integrate Man Pages into Sphinx Docs

Closes #1132 and #1015

See merge request petsc/petsc!4989

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (wor

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (word.rstrip(","), comma)

def _process_stripped_line(line):
return " ".join(map(_process_word, line.split()))

start_pattern = re.compile(r"^( *\.seealso:? )(.*$)")

def process_file(filename_full):
with fileinput.FileInput(filename_full, inplace=True) as f:
in_block = False
for line in f:
line_stripped = line.strip()
# end ".seealso blocks" on a blank line or C-style comment close
line_modified = None
if not line_stripped:
in_block = False
elif line_stripped.endswith("*/"):
in_block = False
else:
match = re.match(start_pattern,
line) # not stripped line
if match:
indent = " " * len(match.group(1))
in_block = True
line_modified = match.group(
1) + _process_stripped_line(
match.group(2).strip())
elif in_block:
line_modified = indent + _process_stripped_line(
line_stripped)
if line_modified:
print(line_modified) # prints to the file
else:
print(line, end="") # prints to the file

BASE_DIRS = ["src", "include"]
EXT = [".c", ".cxx", ".cpp", ".cu", ".h", ".hpp", ".hxx"]
EXCLUDE_DIRS = ["tests", "tutorials", "ftn-auto", "ftn-custom", "benchmarks"]

def main():
""" Process everything """
for base in BASE_DIRS:
for root, dirs, files in os.walk(base):
for filename in files:
if os.path.splitext(filename)[1] in EXT:
filename_full = os.path.join(root, filename)
print("FILE ---", filename_full)
process_file(filename_full)
for exclude_dir in EXCLUDE_DIRS:
if exclude_dir in dirs:
dirs.remove(exclude_dir)

if __name__ == "__main__":
main()
```

show more ...

Merge branch 'jacobf/2022-04-05/petscattrformat-all-the-rest' into 'main'

Enable PETSC_ATTRIBUTE_FORMAT()

See merge request petsc/petsc!5085

Enable PETSC_ATTRIBUTE_FORMAT()