Fix many dead assignments, mostly due to missing CHKERRQ(ierr);

Commit-type: style-fix
Reported-by: clang static analyzer

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]' to showup in '-help' Reported-by: Mark Adams <mfadams@lbl.gov>
Plex: Remove dead code
TS tutorials ex11: remove unused functions
TSAdapt: Set TSADAPTNONE as default adapt type
DMPlex: missed viewer change in synchronized output
Revert "Merge branch 'hzhang/ts-ex9busdmnetwork'"
TSAdapt: Update changes/dev.html
TSAdapt: Set default type for TSGLEE
TS tutorials ex11: make work with complex scalars
Bib: Added ref
TS ex18: Fix initializer
TS ex11: Fix M_PI
Plex ex1f90: FUCK FORTRAN
f2cblaslapack: remove duplicate xerbla.o and xerbla_array.o from lapack [they are already in blas]
TSAdapt: Refactor handling of default adapt type
TSAdapt: Update changes/dev.html
TSAdapt: Update manual
TSAdapt: Refactor interface and implementations
...

show more ...

Merge branch 'master' into knepley/feature-plex-torus

* master: (174 commits)
Bib: Another ref
Increase patchlevel to 3.7.6
Explicitly listing the LTO library causes difficulties on MacOS so a

Merge branch 'master' into knepley/feature-plex-torus

* master: (174 commits)
Bib: Another ref
Increase patchlevel to 3.7.6
Explicitly listing the LTO library causes difficulties on MacOS so avoid it
TSBDF: Update changes/dev.html
Added Fortran TaoType and TaoLineSearchType definitions
Add Fortran TaoType and TaoLineSearchType definitions
setblocksize for iscol_sub
TSBDF: Use standard TS API and options to control adaptivity
Bib: More refs and a correction
SNESTest: Bug-fix in SNESTest when threshold printing option is turned on.
fix warning and valgrind complains reported by the nightly tests
Section+Doc: Small doc fix
pflotran: switch to using the new upstream git repo
DMPlex: Error if attempt to partition a distributed graph with Chaco
fix complex build error
fix complex build
PetscError() did not properly copy over the specific error message when error type was PETSC_ERROR_INITIAL
TSAdapt: Refactor handling of the always_accept flag
Additional clarification for MatMeshToCellGraph() manual page
optimize MatCreateSubMatrix_MPIAIJ() by merging check of sameXXXDist() into one MPI_AllReduce
...

Conflicts:
config/BuildSystem/config/packages/med.py

show more ...

Merge branch 'master' into knepley/feature-plex-tests-new

* master: (108 commits)
Bib: Added ref
Bib: Updated reference
Bib: Updated reference
Work around problems with Apple Xcode 8.3 and h

Merge branch 'master' into knepley/feature-plex-tests-new

* master: (108 commits)
Bib: Added ref
Bib: Updated reference
Bib: Updated reference
Work around problems with Apple Xcode 8.3 and handling of rpath argument with gfortran
help menu update for MatCreateSubMatrices() Reported-by: Brad Aagaard <baagaard@usgs.gov>
fix flops for PCApply_PBJacobi_1 and PCApply_PBJacobi_7 Reported-by: Pierre Jolivet <pierre.jolivet@enseeiht.fr>
TSRK: Fix FSAL optimization to not skip update and check or stages.
Travis-CI: Workaround too long TMPDIR in macOS with Open MPI
test: Fix type mismatch in KSP test.
test: Fix warnings from gfortran -Wconversion (OS X, Homebrew build)
MPIUNI: Silence GCC -Wconversion warnings
Fortran: Add error checking for incorrect PETSC_NULL_XXX argument when expecting function
fix test output per changes in 517c9301b2e9239931bfd644803fd6bb859387ea
MUMPS: update to version 5.1.1 with opensolaris compile fixes
TSRK: Mention 5BS in the changelog.
TSRK: Mention the new 5BS scheme in the manual.
fix 'unused variable' warning
Remove unused code
added hbw_realloc
fixed undefined ptr
...

Conflicts:
config/BuildSystem/config/packages/med.py

show more ...

Merge remote-tracking branch 'origin/barry/improve-ts-trajectory-viz'

Add TSTrajectorySetTransform() to allow transforming the solutions before saving

Updates extchem.c to is TSTrajectorySetTransform() to save the trajectory in mole fraction

Funded-by: IMEX
Project:

Add TSTrajectorySetTransform() to allow transforming the solutions before saving

Updates extchem.c to is TSTrajectorySetTransform() to save the trajectory in mole fraction

Funded-by: IMEX
Project: IMEX
Thanks-to: Shashikant M. Aithal <aithal@cels.anl.gov>

show more ...

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
superlu: libray is installed in PREFIX/lib64 - fix this to use PREFIX/lib
backport fixes cc105cc3 2b35c90a - required for 3bf428d - that was backported from master - 80c96bb
'echo -n' fails on opensolaris/osx - so avoid using it.
fix diffs in nightlybuilds due to options in ~/.petscrc
add Kelley03 to src/docs/tex/petsc.bib
build: determine moudles, mpi.h used during buildtime and print in 'info'
fix analyzer warnings
fix build failure on opensolaris - where -lm from flibs is removed due to -lm in cxxlibs. But then - only flib gets used for some configure tests [blaslapack, parms]
config: prefer __restrict over C99 restrict keyword
...

show more ...

A variety of improvements/fixes for saving and accessing trajectories.

Fixed bugs in PetscReadBinaryTrajectory.m
Added PetscBinaryIOTrajectory.py to read in trajectories in Python
Fixed bug in all t

A variety of improvements/fixes for saving and accessing trajectories.

Fixed bugs in PetscReadBinaryTrajectory.m
Added PetscBinaryIOTrajectory.py to read in trajectories in Python
Fixed bug in all the trajectory file saving routines that used PETSC_COMM_WORLD instead of the MPI_Comm associated with the TS object.

Funded-by: IMEX
Project: adjoints
Time: 2 hours
Reported-by: Shashikant M. Aithal <aithal@cels.anl.gov>

show more ...

Merge branch 'barry/remove-funct'

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-t

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-to: Andreas Mang <andreas@ices.utexas.edu>

show more ...

Merge branch 'master' into stefano_zampini/feature-pcbddc-saddlepoint

Conflicts:
src/ksp/pc/impls/bddc/bddc.c
src/ksp/pc/impls/bddc/bddcgraph.c
src/ksp/pc/impls/bddc/bddcprivate.c

Merged in dalcinl/fix-ts-declarations (pull request #450)

TS: Fix function declarations and visibility

TS: Fix function declarations and visibility

* Most of these fixes where spotted by GCC -Wmissing-declarations

Merge branch 'tisaac/sf-fix-multi-sf-leaves' into tisaac/dmp4est-feature-injection

* tisaac/sf-fix-multi-sf-leaves: (174 commits)
PetscSF: fix PetscSFGetMultiSF() for sparse leaves
PetscSF: make

Merge branch 'tisaac/sf-fix-multi-sf-leaves' into tisaac/dmp4est-feature-injection

* tisaac/sf-fix-multi-sf-leaves: (174 commits)
PetscSF: fix PetscSFGetMultiSF() for sparse leaves
PetscSF: make regression test that fails
few more clang static analyzer fixes
many issues detected by clang static analyzer
Update hypre to its release version
Updates for xSDKTrilinos builds
Added --download-xsdktrilinos
Communicator passed to VecCreateSeq should be PETSC_COMM_SELF
PCMG man page: fix typo in options name
Bib: Added refs
DMLabel: Removed unused variable
Metis tries to use backtrace which requires -lexecinfo on some systems such as freebsd Remove -lexecinfo from freebsd configure files since it is only needed by metis
add alternative output that occurs on some systems due to use of random number generator in partitioner
Plex: When creating cohesive submeshes, fix memory leak
Plex ex11: Updated output for new distribution algorithm
Plex: When explicitly distributing the depth label, we must recreate empty strata
Plex: When partitioning, the cell numbering should include hybrid points
Plex: Allow cell and vertex numberings to include hybrid points
need to show diffs of ex22 if it fails
Support two different output for test example, since due to roundoff this example can produce slightly different convergence history
...

show more ...

Merge branch 'master' into stefano_zampini/feature-pcbddc-saddlepoint

Merge branch 'hongzh/update-ts-trajectory'

just a typo in comment

create tstrajectory_type visiaulzation